Page MenuHomePhabricator

Optionally demote fatal errors to non-fatal errors.

Authored by milianw on Feb 20 2016, 5:29 PM.



This behavior is enabled when the new CXTranslationUnit_KeepGoing
option is passed to clang_parseTranslationUnit{,2}. It is geared
towards use by IDEs and similar consumers of the clang-c API where
fatal errors may arise when parsing incomplete code mid-edit, or
when include paths are not properly configured yet. In such situations
one still wants to get as much information as possible about a TU.
Previously, the semantic analysis would not instantiate templates
or report additional fatal errors after the first fatal error was

Fixes bug

Diff Detail

Event Timeline

milianw updated this revision to Diff 48603.Feb 20 2016, 5:29 PM
milianw retitled this revision from to Optionally demote fatal errors to non-fatal errors..
milianw updated this object.
milianw added a subscriber: llvm-commits.
milianw added a project: Restricted Project.Feb 20 2016, 5:30 PM
ehsan resigned from this revision.Feb 22 2016, 12:26 PM
ehsan removed a reviewer: ehsan.

I don't feel confident in reviewing this, but based on a cursory look the patch looks fine. :-)

Ping? This patch would be very helpful for us to have in KDevelop. Can anyone give us a review please? I'm willing to amend it as needed to get this issue resolved.


klimek added inline comments.Feb 29 2016, 1:51 AM

Add '.'.


That block seems superfluous?

milianw updated this revision to Diff 49352.Feb 29 2016, 3:05 AM

attended klimek's review comments

klimek accepted this revision.Feb 29 2016, 3:08 AM
klimek edited edge metadata.


This revision is now accepted and ready to land.Feb 29 2016, 3:08 AM

Thanks Manuel!

Can someone please commit the change for me? I don't have the required permissions yet to do so.

klimek closed this revision.Mar 1 2016, 3:01 AM

Submitted as r262318. Now go get submit access ;)