User Details
- User Since
- Aug 20 2015, 3:56 AM (432 w, 4 d)
Apr 7 2021
Looks good to me!
Nov 13 2019
Is someone willing to pick up this patch again? It's still an issue.
Feb 25 2019
Due to https://blog.qt.io/blog/2018/10/29/deprecation-of-qbs/ this should probably be abandoned.
Nov 27 2017
Marking this Diff properly -- it needs more work.
Sep 20 2017
Bump? This is a trivial one
Sep 5 2017
Aug 25 2017
Jul 25 2017
Seems to have worked:
Committing to https://llvm.org/svn/llvm-project/clang-tools-extra/trunk ... A test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml A test/clang-apply-replacements/invalid-files.cpp M clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp Committed r308974
Addressed concerns
Jul 11 2017
Jul 10 2017
Remove unnecessary sed line in test driver
Add test
Apr 25 2017
Looks good from my side. Can push if it gets another +1.
Feb 28 2017
@erikjv Ready for review? Does this reliably fix https://bugreports.qt.io/browse/QTCREATORBUG-15449?
Feb 24 2017
Feb 22 2017
Dec 20 2016
Dec 15 2016
Dec 14 2016
Nov 3 2016
Sep 15 2016
@other LLVM devs: Please review so we can finally ship this?
Jun 13 2016
Mar 24 2016
Mar 15 2016
Remove unrelated hunk
Mar 10 2016
Mar 8 2016
Committed. Will use "Differential Revision: <id>" next time, forgot to amend...
Mar 7 2016
@klimek: Ping?
Okay, just gave this another look. Unit test seems fine as-is. Let's call loadPlugins there explicitly.
Remove TODO statement
Mar 5 2016
Note: Unit test is still not functional. I'll have another look at it now.
Mar 3 2016
Bump? Waiting for another +1 here.
Mar 2 2016
Note: I don't have commit rights yet
Feb 21 2016
Jan 12 2016
@realincubus: Sorry, I didn't know you had put this up for review already.
Jan 11 2016
Just uploading my WIP patch, now that the branching comes close. I added a test, unfortunately it doesn't do what I expect.
Please see the FIXME.
Dec 24 2015
Dec 22 2015
By the way; prove that it really works: http://wstaw.org/m/2015/12/23/kdevelop-clazy.png (loving it!) :)
Doing as requested by http://lists.llvm.org/pipermail/cfe-dev/2014-October/039381.html, let's put this up for review in its initial form, so we can discuss a better approach.
Nov 24 2015
Looks good to me now. I'd also appreciate another +1 from somone else, though.