Page MenuHomePhabricator

kfunk (Kevin Funk)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2015, 3:56 AM (203 w, 6 d)

Recent Activity

Feb 25 2019

kfunk requested changes to D32141: docs: Explain how to generate a compilation database for Qt projects.

Due to https://blog.qt.io/blog/2018/10/29/deprecation-of-qbs/ this should probably be abandoned.

Feb 25 2019, 6:20 AM

Nov 27 2017

kfunk committed rCTE319148: run-clang-tidy: Use check_call instead of check_output.
run-clang-tidy: Use check_call instead of check_output
Nov 27 2017, 11:18 PM
kfunk committed rL319148: run-clang-tidy: Use check_call instead of check_output.
run-clang-tidy: Use check_call instead of check_output
Nov 27 2017, 11:17 PM
kfunk closed D37482: run-clang-tidy: Use check_call instead of check_output by committing rL319148: run-clang-tidy: Use check_call instead of check_output.
Nov 27 2017, 11:17 PM
kfunk planned changes to D15729: Load compiler plugins in ASTUnit, too.

Marking this Diff properly -- it needs more work.

Nov 27 2017, 10:30 PM

Sep 20 2017

kfunk added a comment to D37482: run-clang-tidy: Use check_call instead of check_output.

Bump? This is a trivial one

Sep 20 2017, 11:26 AM

Sep 5 2017

kfunk added a comment to D37479: run-clang-tidy: Report progress.

I think will be good idea to introduce command line option to control progress display: turn it off, show in absolute numbers or percents.

Sep 5 2017, 3:55 PM
kfunk updated the summary of D37482: run-clang-tidy: Use check_call instead of check_output.
Sep 5 2017, 8:32 AM
kfunk updated the summary of D37479: run-clang-tidy: Report progress.
Sep 5 2017, 8:32 AM
kfunk added reviewers for D37482: run-clang-tidy: Use check_call instead of check_output: cfe-commits, alexfh.
Sep 5 2017, 8:25 AM
kfunk created D37482: run-clang-tidy: Use check_call instead of check_output.
Sep 5 2017, 8:24 AM
kfunk added reviewers for D37479: run-clang-tidy: Report progress: cfe-commits, alexfh.
Sep 5 2017, 8:18 AM
kfunk created D37479: run-clang-tidy: Report progress.
Sep 5 2017, 8:17 AM
kfunk committed rL312532: Make run-clang-tidy compatible with Python 3.x.
Make run-clang-tidy compatible with Python 3.x
Sep 5 2017, 5:37 AM
kfunk closed D37138: Make run-clang-tidy compatible with Python 3.x by committing rL312532: Make run-clang-tidy compatible with Python 3.x.
Sep 5 2017, 5:37 AM · Restricted Project

Aug 25 2017

kfunk added a reviewer for D37138: Make run-clang-tidy compatible with Python 3.x: alexfh.
Aug 25 2017, 4:55 AM · Restricted Project
kfunk created D37138: Make run-clang-tidy compatible with Python 3.x.
Aug 25 2017, 4:53 AM · Restricted Project

Jul 25 2017

kfunk committed rL308975: [clang-tidy] Fixup clang-apply-replacements/invalid-files test.
[clang-tidy] Fixup clang-apply-replacements/invalid-files test
Jul 25 2017, 7:39 AM
kfunk added a comment to D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.

Seems to have worked:

Committing to https://llvm.org/svn/llvm-project/clang-tools-extra/trunk ...
        A       test/clang-apply-replacements/Inputs/invalid-files/invalid-files.yaml
        A       test/clang-apply-replacements/invalid-files.cpp
        M       clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp
Committed r308974
Jul 25 2017, 7:30 AM · Restricted Project
kfunk committed rL308974: [clang-tidy] clang-apply-replacements: Don't insert null entry.
[clang-tidy] clang-apply-replacements: Don't insert null entry
Jul 25 2017, 7:29 AM
kfunk closed D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry by committing rL308974: [clang-tidy] clang-apply-replacements: Don't insert null entry.
Jul 25 2017, 7:29 AM · Restricted Project
kfunk updated the diff for D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.

Addressed concerns

Jul 25 2017, 6:00 AM · Restricted Project

Jul 11 2017

kfunk added inline comments to D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.
Jul 11 2017, 2:41 AM · Restricted Project

Jul 10 2017

kfunk updated the summary of D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.
Jul 10 2017, 4:25 PM · Restricted Project
kfunk updated the diff for D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.

Remove unnecessary sed line in test driver

Jul 10 2017, 3:56 PM · Restricted Project
kfunk updated the summary of D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.
Jul 10 2017, 3:55 PM · Restricted Project
kfunk updated the summary of D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.
Jul 10 2017, 3:53 PM · Restricted Project
kfunk updated the diff for D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.

Add test

Jul 10 2017, 3:51 PM · Restricted Project
kfunk added reviewers for D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry: alexfh, yawanng.
Jul 10 2017, 5:53 AM · Restricted Project
kfunk created D35194: [clang-tidy] clang-apply-replacements: Don't insert null entry.
Jul 10 2017, 3:46 AM · Restricted Project

Apr 25 2017

kfunk accepted D32141: docs: Explain how to generate a compilation database for Qt projects.

Looks good from my side. Can push if it gets another +1.

Apr 25 2017, 7:25 AM

Feb 28 2017

kfunk added a comment to D27810: FileManager: mark virtual file entries as valid entries.

@erikjv Ready for review? Does this reliably fix https://bugreports.qt.io/browse/QTCREATORBUG-15449?

Feb 28 2017, 1:32 AM

Feb 24 2017

kfunk committed rL296098: Add clazy to external Clang examples page.
Add clazy to external Clang examples page
Feb 24 2017, 12:41 AM
kfunk closed D30252: Add clazy to external Clang examples page by committing rL296098: Add clazy to external Clang examples page.
Feb 24 2017, 12:41 AM

Feb 22 2017

kfunk added reviewers for D30252: Add clazy to external Clang examples page: silvas, rizsotto.mailinglist, sergio.martins.
Feb 22 2017, 5:49 AM
kfunk created D30252: Add clazy to external Clang examples page.
Feb 22 2017, 5:49 AM

Dec 20 2016

kfunk committed rL290172: Fix for clang_Cursor_getSpellingNameRange().
Fix for clang_Cursor_getSpellingNameRange()
Dec 20 2016, 2:07 AM
kfunk closed D18462: Fix for clang_Cursor_getSpellingNameRange() by committing rL290172: Fix for clang_Cursor_getSpellingNameRange().
Dec 20 2016, 2:07 AM · Unknown Object (Project)

Dec 15 2016

kfunk added a reviewer for D27810: FileManager: mark virtual file entries as valid entries: kfunk.
Dec 15 2016, 8:58 AM

Dec 14 2016

kfunk added a reviewer for D27764: File descriptor leaks on header files that contain errors: kfunk.
Dec 14 2016, 11:02 AM · Unknown Object (Project)

Nov 3 2016

kfunk added a reviewer for D26285: [index] Expose FriendDecl: Unknown Object (Project).
Nov 3 2016, 12:31 PM

Sep 26 2016

kfunk updated subscribers of D21279: Fix some issues in clang-format's AlignConsecutive modes.
Sep 26 2016, 1:29 AM · Unknown Object (Project)
kfunk updated subscribers of D21279: Fix some issues in clang-format's AlignConsecutive modes.
Sep 26 2016, 1:29 AM · Unknown Object (Project)

Sep 15 2016

kfunk added a comment to D18462: Fix for clang_Cursor_getSpellingNameRange().

@other LLVM devs: Please review so we can finally ship this?

Sep 15 2016, 2:11 AM · Unknown Object (Project)

Jun 28 2016

kfunk updated subscribers of D21279: Fix some issues in clang-format's AlignConsecutive modes.
Jun 28 2016, 7:51 AM · Unknown Object (Project)

Jun 13 2016

kfunk added a comment to D21279: Fix some issues in clang-format's AlignConsecutive modes.

Generally, please subscribe cfe-commits when sending patches via phab.
See http://llvm.org/docs/Phabricator.html

Jun 13 2016, 3:51 AM · Unknown Object (Project)

Apr 20 2016

kfunk updated subscribers of D19327: Keep invalid function body as part of the AST.
Apr 20 2016, 11:50 AM

Mar 24 2016

kfunk added reviewers for D18462: Fix for clang_Cursor_getSpellingNameRange(): skalinichev, milianw.
Mar 24 2016, 3:10 PM · Unknown Object (Project)
kfunk added reviewers for D18462: Fix for clang_Cursor_getSpellingNameRange(): akyrtzi, craigt.
Mar 24 2016, 3:08 PM · Unknown Object (Project)
kfunk retitled D18462: Fix for clang_Cursor_getSpellingNameRange() from to Fix for clang_Cursor_getSpellingNameRange().
Mar 24 2016, 3:07 PM · Unknown Object (Project)

Mar 15 2016

kfunk updated the diff for D15729: Load compiler plugins in ASTUnit, too.

Remove unrelated hunk

Mar 15 2016, 6:09 AM

Mar 10 2016

kfunk added inline comments to D11797: [LIbClang] Report the named type for ElaboratedType.
Mar 10 2016, 10:01 AM
kfunk added a comment to D15729: Load compiler plugins in ASTUnit, too.

@bkramer: Thoughts about my patch? I wonder if this makes your "work-around" in D17808 redundant.

Mar 10 2016, 9:38 AM

Mar 8 2016

kfunk closed D17824: Bump libclang API version after r262318.

Committed. Will use "Differential Revision: <id>" next time, forgot to amend...

Mar 8 2016, 2:43 AM · Unknown Object (Project)
kfunk committed rL262922: Bump libclang API version after r262318.
Bump libclang API version after r262318
Mar 8 2016, 2:39 AM

Mar 7 2016

kfunk added a comment to D17824: Bump libclang API version after r262318.

@klimek: Ping?

Mar 7 2016, 2:59 PM · Unknown Object (Project)
kfunk added a comment to D15729: Load compiler plugins in ASTUnit, too.

Okay, just gave this another look. Unit test seems fine as-is. Let's call loadPlugins there explicitly.

Mar 7 2016, 2:57 PM
kfunk updated the diff for D15729: Load compiler plugins in ASTUnit, too.

Remove TODO statement

Mar 7 2016, 2:54 PM

Mar 5 2016

kfunk planned changes to D15729: Load compiler plugins in ASTUnit, too.

Note: Unit test is still not functional. I'll have another look at it now.

Mar 5 2016, 5:48 AM

Mar 3 2016

kfunk added a comment to D17824: Bump libclang API version after r262318.

Bump? Waiting for another +1 here.

Mar 3 2016, 3:52 AM · Unknown Object (Project)

Mar 2 2016

kfunk added reviewers for D17824: Bump libclang API version after r262318: akyrtzi, compnerd.
Mar 2 2016, 12:47 PM · Unknown Object (Project)
kfunk added a comment to D17824: Bump libclang API version after r262318.

Note: I don't have commit rights yet

Mar 2 2016, 12:22 PM · Unknown Object (Project)
kfunk added reviewers for D17824: Bump libclang API version after r262318: milianw, klimek.
Mar 2 2016, 12:21 PM · Unknown Object (Project)
kfunk retitled D17824: Bump libclang API version after r262318 from to Bump libclang API version after r262318.
Mar 2 2016, 12:19 PM · Unknown Object (Project)

Feb 21 2016

kfunk added a reviewer for D17486: Optionally demote fatal errors to non-fatal errors.: kfunk.
Feb 21 2016, 11:34 AM · Unknown Object (Project)

Jan 12 2016

kfunk added a comment to D15729: Load compiler plugins in ASTUnit, too.

@realincubus: Sorry, I didn't know you had put this up for review already.

Jan 12 2016, 9:28 AM

Jan 11 2016

kfunk updated the diff for D15729: Load compiler plugins in ASTUnit, too.

Just uploading my WIP patch, now that the branching comes close. I added a test, unfortunately it doesn't do what I expect.
Please see the FIXME.

Jan 11 2016, 2:01 AM

Dec 24 2015

kfunk added reviewers for D15729: Load compiler plugins in ASTUnit, too: akyrtzi, doug.gregor, bkramer.
Dec 24 2015, 5:15 AM

Dec 22 2015

kfunk updated D15729: Load compiler plugins in ASTUnit, too.
Dec 22 2015, 3:58 PM
kfunk added a comment to D15729: Load compiler plugins in ASTUnit, too.

By the way; prove that it really works: http://wstaw.org/m/2015/12/23/kdevelop-clazy.png (loving it!) :)

Dec 22 2015, 3:58 PM
kfunk added a comment to D15729: Load compiler plugins in ASTUnit, too.

Doing as requested by http://lists.llvm.org/pipermail/cfe-dev/2014-October/039381.html, let's put this up for review in its initial form, so we can discuss a better approach.

Dec 22 2015, 3:54 PM
kfunk added reviewers for D15729: Load compiler plugins in ASTUnit, too: realincubus, cfe-commits.
Dec 22 2015, 3:53 PM
kfunk retitled D15729: Load compiler plugins in ASTUnit, too from to Load compiler plugins in ASTUnit, too.
Dec 22 2015, 3:53 PM

Dec 17 2015

kfunk updated subscribers of D15606: Remove clang-modernize..
Dec 17 2015, 4:31 AM

Nov 24 2015

kfunk accepted D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface.

Looks good to me now. I'd also appreciate another +1 from somone else, though.

Nov 24 2015, 12:35 PM · Restricted Project

Nov 4 2015

kfunk added inline comments to D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface.
Nov 4 2015, 12:57 AM · Restricted Project

Aug 20 2015

kfunk updated subscribers of D11976: [libclang] Return deduced type for auto type, not the one written in the source..
Aug 20 2015, 3:56 AM