Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

People erikjv

erikjv (Erik Verbruggen)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2012, 7:36 AM (570 w, 6 d)

Recent Activity
View All

Jun 14 2019

erikjv added a comment to D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++.
In D63329#1543407, @lebedev.ri wrote:

Tests?

Jun 14 2019, 6:46 AM · Restricted Project, Restricted Project
erikjv created D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++.
Jun 14 2019, 4:59 AM · Restricted Project, Restricted Project

Apr 26 2018

erikjv added a comment to D45815: [libclang] Allow skipping function bodies in preamble only.

About the timing testing: I'm not very familiar with boost, but it probably has a library that's using templates more than either LLVM or Qt. Maybe you can test one of those too?

Apr 26 2018, 3:10 AM

Apr 24 2018

erikjv closed D38615: [libclang] Only mark CXCursors for explicit attributes with a type.

Committed as r330692

Apr 24 2018, 1:43 AM
erikjv committed rL330692: [libclang] Only mark CXCursors for explicit attributes with a type.
[libclang] Only mark CXCursors for explicit attributes with a type
Apr 24 2018, 1:43 AM
erikjv committed rC330692: [libclang] Only mark CXCursors for explicit attributes with a type.
[libclang] Only mark CXCursors for explicit attributes with a type
Apr 24 2018, 1:43 AM

Jan 5 2018

erikjv added a comment to D20124: [PCH] Serialize skipped preprocessor ranges.

lgtm. Ilya?

Jan 5 2018, 12:55 AM

Dec 6 2017

erikjv committed rL319881: [libclang] Add function to get the buffer for a file.
[libclang] Add function to get the buffer for a file
Dec 6 2017, 1:03 AM
erikjv committed rC319881: [libclang] Add function to get the buffer for a file.
[libclang] Add function to get the buffer for a file
Dec 6 2017, 1:03 AM
erikjv closed D40643: [libclang] Add function to get the buffer for a file by committing rL319881: [libclang] Add function to get the buffer for a file.
Dec 6 2017, 1:03 AM

Nov 30 2017

erikjv updated the diff for D40643: [libclang] Add function to get the buffer for a file.

Bumped the CINDEX_VERSION_MINOR.

Nov 30 2017, 3:32 AM
erikjv updated the diff for D33765: Show correct column nr. when multi-byte utf8 chars are used..

I moved all code to the TextDiagnostics, so all other interfaces still get byte offsets.

Nov 30 2017, 3:26 AM
erikjv created D40643: [libclang] Add function to get the buffer for a file.
Nov 30 2017, 2:14 AM
erikjv created D40640: Fix code completion crash with unresolved member expr and explicit base.
Nov 30 2017, 1:32 AM

Nov 28 2017

erikjv closed D38578: [preamble] Also record the "skipping" state of the preprocessor.

Submitted as r317308.

Nov 28 2017, 3:12 AM
erikjv added a comment to D20124: [PCH] Serialize skipped preprocessor ranges.

Maybe something like this works:

Nov 28 2017, 2:29 AM

Nov 14 2017

erikjv committed rL318142: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS.
[libclang] Allow crash recovery with LIBCLANG_NOTHREADS
Nov 14 2017, 1:37 AM
erikjv closed D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS.

Committed as r318142.

Nov 14 2017, 1:37 AM

Nov 3 2017

erikjv committed rL317308: [preamble] Also record the "skipping" state of the preprocessor.
[preamble] Also record the "skipping" state of the preprocessor
Nov 3 2017, 2:40 AM
erikjv added a comment to D20124: [PCH] Serialize skipped preprocessor ranges.

The patch has aged a bit since upload, so does it still apply? And, can you add a testcase please?

Nov 3 2017, 2:10 AM

Oct 24 2017

erikjv committed rL316436: Do not add a colon chunk to the code completion of class inheritance access….
Do not add a colon chunk to the code completion of class inheritance access…
Oct 24 2017, 6:47 AM
erikjv closed D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers by committing rL316436: Do not add a colon chunk to the code completion of class inheritance access….
Oct 24 2017, 6:47 AM

Oct 6 2017

erikjv added a comment to D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers.

lgtm, but someone else will probably have to review it too.

Oct 6 2017, 6:30 AM
erikjv updated the diff for D38578: [preamble] Also record the "skipping" state of the preprocessor.
Oct 6 2017, 6:19 AM
erikjv added a reviewer for D38615: [libclang] Only mark CXCursors for explicit attributes with a type: ilya-biryukov.
Oct 6 2017, 6:11 AM
erikjv updated the diff for D38615: [libclang] Only mark CXCursors for explicit attributes with a type.

Added more context to the diff

Oct 6 2017, 3:57 AM
erikjv created D38615: [libclang] Only mark CXCursors for explicit attributes with a type.
Oct 6 2017, 3:56 AM

Oct 5 2017

erikjv created D38578: [preamble] Also record the "skipping" state of the preprocessor.
Oct 5 2017, 3:53 AM

Oct 4 2017

erikjv updated the diff for D33765: Show correct column nr. when multi-byte utf8 chars are used..
Oct 4 2017, 5:28 AM
erikjv added a reviewer for D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS: arphaman.
Oct 4 2017, 2:57 AM

Sep 12 2017

erikjv added a comment to D37700: Fix recording preamble's conditional stack in skipped PP branches..

I'd put/fix Nik's issue in a separate patch.

Sep 12 2017, 1:03 AM
erikjv accepted D37700: Fix recording preamble's conditional stack in skipped PP branches..
Sep 12 2017, 1:02 AM

Sep 8 2017

erikjv added a comment to D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence).

Will this fix PR25023 and PR21144?

Sep 8 2017, 5:32 AM
erikjv committed rL312785: Don't show deleted function (constructor) candidates for code completion.
Don't show deleted function (constructor) candidates for code completion
Sep 8 2017, 3:24 AM
erikjv closed D37435: Don't show deleted function (constructor) candidates for code completion by committing rL312785: Don't show deleted function (constructor) candidates for code completion.
Sep 8 2017, 3:24 AM
erikjv committed rL312780: Fix templated type alias completion when using global completion cache.
Fix templated type alias completion when using global completion cache
Sep 8 2017, 2:33 AM

Aug 29 2017

erikjv committed rL311990: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*.
[libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*
Aug 29 2017, 2:09 AM
erikjv closed D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit* by committing rL311990: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*.
Aug 29 2017, 2:09 AM

Aug 22 2017

erikjv committed rL311445: Revert r311442 (Fix templated type alias completion when using global….
Revert r311442 (Fix templated type alias completion when using global…
Aug 22 2017, 3:55 AM
erikjv committed rL311442: Fix templated type alias completion when using global completion cache.
Fix templated type alias completion when using global completion cache
Aug 22 2017, 3:27 AM
erikjv closed D35355: Fix templated type alias completion when using global completion cache by committing rL311442: Fix templated type alias completion when using global completion cache.
Aug 22 2017, 3:27 AM

Aug 18 2017

erikjv added a comment to D35355: Fix templated type alias completion when using global completion cache.

I'll commit it, probably next Tuesday.

Aug 18 2017, 7:06 AM
erikjv added a comment to D36872: Fixed a crash on replaying Preamble's PP conditional stack..

Can you check if the example in https://bugs.llvm.org/show_bug.cgi?id=33574 works correctly?

Aug 18 2017, 5:44 AM

Jul 19 2017

erikjv committed rL308438: Fix compilation problem introduced in r308433.
Fix compilation problem introduced in r308433
Jul 19 2017, 4:16 AM
erikjv committed rL308433: Add default values for function parameter chunks.
Add default values for function parameter chunks
Jul 19 2017, 3:46 AM
erikjv closed D33644: Add default values for function parameter chunks by committing rL308433: Add default values for function parameter chunks.
Jul 19 2017, 3:46 AM

Jul 14 2017

erikjv committed rL308012: [analyzer] Add annotation for functions taking user-facing strings.
[analyzer] Add annotation for functions taking user-facing strings
Jul 14 2017, 3:25 AM
erikjv closed D35186: [analyzer] Add annotation for functions taking user-facing strings by committing rL308012: [analyzer] Add annotation for functions taking user-facing strings.
Jul 14 2017, 3:25 AM

Jul 9 2017

erikjv updated the diff for D35186: [analyzer] Add annotation for functions taking user-facing strings.

Sorry, now with more context in the diff.

Jul 9 2017, 12:53 PM
erikjv created D35186: [analyzer] Add annotation for functions taking user-facing strings.
Jul 9 2017, 12:47 PM

Jul 5 2017

erikjv committed rL307134: Fix invalid warnings for header guards in preambles.
Fix invalid warnings for header guards in preambles
Jul 5 2017, 2:44 AM
erikjv closed D34882: Fix invalid warnings for header guards in preambles by committing rL307134: Fix invalid warnings for header guards in preambles.
Jul 5 2017, 2:44 AM
erikjv added reviewers for D34098: Allow to set incremental processing from CIndex: arphaman, klimek.
Jul 5 2017, 2:29 AM
erikjv added reviewers for D34873: Fix miscompiled 32bit binaries by mingw: bkramer, klimek.
Jul 5 2017, 2:28 AM

Jun 30 2017

erikjv created D34882: Fix invalid warnings for header guards in preambles.
Jun 30 2017, 7:27 AM

Jun 9 2017

erikjv committed rL305061: Speed up preamble loading.
Speed up preamble loading
Jun 9 2017, 1:30 AM
erikjv closed D33493: Speed up preamble loading by committing rL305061: Speed up preamble loading.
Jun 9 2017, 1:30 AM

Jun 1 2017

erikjv created D33765: Show correct column nr. when multi-byte utf8 chars are used..
Jun 1 2017, 3:14 AM

May 30 2017

erikjv closed D33042: [libclang] Allow to suspend a translation unit..

Committed as r304212.

May 30 2017, 7:28 AM
erikjv committed rL304212: [libclang] Allow to suspend a translation unit..
[libclang] Allow to suspend a translation unit.
May 30 2017, 7:26 AM
erikjv abandoned D21075: Correct invalid end location in diagnostics for some identifiers..
May 30 2017, 5:01 AM
erikjv added a comment to D33405: Mark all ARCMT test files as binary files in git, just like with svn.

Ping?

May 30 2017, 4:57 AM
erikjv committed rL304207: Allow for unfinished #if blocks in preambles.
Allow for unfinished #if blocks in preambles
May 30 2017, 4:55 AM
erikjv closed D15994: Allow for unfinished #if blocks in preambles. by committing rL304207: Allow for unfinished #if blocks in preambles.
May 30 2017, 4:55 AM

May 22 2017

erikjv created D33405: Mark all ARCMT test files as binary files in git, just like with svn.
May 22 2017, 4:46 AM

May 16 2017

erikjv added a reviewer for D15994: Allow for unfinished #if blocks in preambles.: arphaman.
May 16 2017, 1:15 AM

May 12 2017

erikjv updated the diff for D15994: Allow for unfinished #if blocks in preambles..
May 12 2017, 6:53 AM
erikjv added a comment to D15994: Allow for unfinished #if blocks in preambles..

Fixed with the next patch.

May 12 2017, 6:51 AM

Mar 28 2017

erikjv closed D27810: FileManager: mark virtual file entries as valid entries.

Committed as r298905.

Mar 28 2017, 4:33 AM
erikjv committed rL298905: FileManager: mark virtual file entries as valid entries.
FileManager: mark virtual file entries as valid entries
Mar 28 2017, 2:30 AM
erikjv updated the diff for D27810: FileManager: mark virtual file entries as valid entries.

Added a test for the specific scenario, and added asserts for validity of UFEs returned by getVirtualFile.

Mar 28 2017, 2:14 AM
erikjv closed D30248: [libclang] Fix crash in member access code completion with implicit base.

Landed as r298903.

Mar 28 2017, 12:46 AM
erikjv committed rL298903: [libclang] Fix crash in member access code completion with implicit base.
[libclang] Fix crash in member access code completion with implicit base
Mar 28 2017, 12:34 AM

Mar 8 2017

erikjv added a comment to D27810: FileManager: mark virtual file entries as valid entries.

@klimek no, it's a 1 line fix. The rest was the previous version of the patch.

Mar 8 2017, 4:14 AM
erikjv added a comment to D27810: FileManager: mark virtual file entries as valid entries.

@kfunk yes and yes, so @bkramer or @klimek : ping?

Mar 8 2017, 1:59 AM

Feb 22 2017

erikjv created D30248: [libclang] Fix crash in member access code completion with implicit base.
Feb 22 2017, 2:45 AM

Feb 17 2017

erikjv updated the diff for D27810: FileManager: mark virtual file entries as valid entries.
Feb 17 2017, 5:24 AM

Feb 16 2017

erikjv committed rL295301: Cache FileID when translating diagnostics in PCH files.
Cache FileID when translating diagnostics in PCH files
Feb 16 2017, 2:01 AM
erikjv closed D29755: Cache FileID when translating diagnostics in PCH files by committing rL295301: Cache FileID when translating diagnostics in PCH files.
Feb 16 2017, 2:01 AM

Feb 14 2017

erikjv updated the diff for D29755: Cache FileID when translating diagnostics in PCH files.
Feb 14 2017, 6:32 AM

Feb 9 2017

erikjv updated the diff for D15994: Allow for unfinished #if blocks in preambles..
Feb 9 2017, 4:28 AM
erikjv updated the summary of D29755: Cache FileID when translating diagnostics in PCH files.
Feb 9 2017, 2:27 AM
erikjv created D29755: Cache FileID when translating diagnostics in PCH files.
Feb 9 2017, 2:16 AM

Feb 7 2017

erikjv updated the diff for D27810: FileManager: mark virtual file entries as valid entries.

Fixed all failing tests on Windows.

Feb 7 2017, 1:56 AM

Jan 27 2017

erikjv added inline comments to D27810: FileManager: mark virtual file entries as valid entries.
Jan 27 2017, 2:43 AM
erikjv added a comment to D27810: FileManager: mark virtual file entries as valid entries.

besc: I can't reproduce any crash. I tried trunk and the release_39 branch with msvc2015.

Jan 27 2017, 2:42 AM

Dec 15 2016

erikjv added a comment to D27764: File descriptor leaks on header files that contain errors.

That's actually working around the real problem, see https://reviews.llvm.org/D27810 . I'm also not sure if this is safe: if the memory buffer is mmap-backed, this could lead to some kind of use-after-free, because clang often uses StringRefs back into buffers in order to minimise string copies.

Dec 15 2016, 7:53 AM · Restricted Project
erikjv retitled D27810: FileManager: mark virtual file entries as valid entries from to Normalize all filenames before searching FileManager caches.
Dec 15 2016, 7:51 AM

Dec 8 2016

erikjv updated the diff for D21075: Correct invalid end location in diagnostics for some identifiers..
Dec 8 2016, 2:41 AM

Dec 7 2016

erikjv updated the diff for D15994: Allow for unfinished #if blocks in preambles..
Dec 7 2016, 7:01 AM
erikjv added inline comments to D15994: Allow for unfinished #if blocks in preambles..
Dec 7 2016, 6:59 AM

Oct 28 2016

erikjv closed D25990: Sema: do not warn about unused const vars if main file is a header.

Committed as r285386.

Oct 28 2016, 6:32 AM
erikjv committed rL285386: Sema: do not warn about unused const vars if main file is a header.
Sema: do not warn about unused const vars if main file is a header
Oct 28 2016, 1:38 AM

Oct 27 2016

erikjv committed rL285295: Do not print include_next/pragma once warnings when input is a header..
Do not print include_next/pragma once warnings when input is a header.
Oct 27 2016, 7:26 AM
erikjv closed D25989: Do not print include_next/pragma once warnings when input is a header. by committing rL285295: Do not print include_next/pragma once warnings when input is a header..
Oct 27 2016, 7:26 AM
erikjv committed rL285287: Add const versions of Expr::getInits() and Expr::inits().
Add const versions of Expr::getInits() and Expr::inits()
Oct 27 2016, 5:21 AM
erikjv committed rL285275: Mark invalid RecordDecls as completed..
Mark invalid RecordDecls as completed.
Oct 27 2016, 1:46 AM
erikjv closed D21176: Mark invalid RecordDecls as completed. by committing rL285275: Mark invalid RecordDecls as completed..
Oct 27 2016, 1:46 AM

Oct 26 2016

erikjv added inline comments to D21075: Correct invalid end location in diagnostics for some identifiers..
Oct 26 2016, 1:05 PM
erikjv retitled D25990: Sema: do not warn about unused const vars if main file is a header from to Sema: do not warn about unused const vars if main file is a header.
Oct 26 2016, 7:52 AM