ehsan (Ehsan Akhgari)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2012, 6:06 AM (312 w, 4 d)

Recent Activity

Feb 17 2017

ehsan committed rL295482: [clang-tidy] Add -path option to clang-tidy-diff.py.
[clang-tidy] Add -path option to clang-tidy-diff.py
Feb 17 2017, 2:32 PM
ehsan closed D29806: [clang-tidy] Add -path option to clang-tidy-diff.py by committing rL295482: [clang-tidy] Add -path option to clang-tidy-diff.py.
Feb 17 2017, 2:32 PM
ehsan updated the diff for D29806: [clang-tidy] Add -path option to clang-tidy-diff.py.

Addressed the review comments.

Feb 17 2017, 6:24 AM

Feb 16 2017

ehsan added a comment to D29806: [clang-tidy] Add -path option to clang-tidy-diff.py.

Gentle ping. :-)

Feb 16 2017, 8:03 PM

Feb 10 2017

ehsan added a comment to D29806: [clang-tidy] Add -path option to clang-tidy-diff.py.

What's your use case? Can it be addressed by just forwarding the -p flag to clang-tidy?

Feb 10 2017, 7:28 AM

Feb 9 2017

ehsan created D29806: [clang-tidy] Add -path option to clang-tidy-diff.py.
Feb 9 2017, 6:47 PM
ehsan committed rL294607: [clang-tidy] Add -quiet option to suppress extra output.
[clang-tidy] Add -quiet option to suppress extra output
Feb 9 2017, 10:43 AM
ehsan closed D29661: [clang-tidy] Add -quiet option to suppress extra output by committing rL294607: [clang-tidy] Add -quiet option to suppress extra output.
Feb 9 2017, 10:43 AM

Feb 8 2017

ehsan committed rL294491: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py.
[clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py
Feb 8 2017, 10:02 AM
ehsan closed D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py by committing rL294491: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py.
Feb 8 2017, 10:01 AM

Feb 7 2017

ehsan added a comment to D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py.

This is equivalent to https://reviews.llvm.org/D28334 for clang-tidy-diff.py.

Feb 7 2017, 6:22 PM
ehsan created D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py.
Feb 7 2017, 6:19 PM
ehsan created D29661: [clang-tidy] Add -quiet option to suppress extra output.
Feb 7 2017, 9:20 AM

Jan 18 2017

ehsan committed rL292415: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py.
[clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py
Jan 18 2017, 10:00 AM
ehsan closed D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py by committing rL292415: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py.
Jan 18 2017, 10:00 AM
ehsan added inline comments to D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py.
Jan 18 2017, 9:59 AM

Jan 4 2017

ehsan retitled D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py from to [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py.
Jan 4 2017, 4:36 PM

Oct 14 2016

ehsan resigned from D22221: Decide whether to enable plugin tests based on cmake variables.

I also don't know enough about the build system to review this, sorry!

Oct 14 2016, 8:33 AM

Jul 17 2016

collieradam47 awarded rL217522: Recognize .lib files as linker input explicitly a Like token.
Jul 17 2016, 3:36 AM

May 31 2016

ehsan committed rL271292: clang-c: Add the clang_getCursorVisibility() API.
clang-c: Add the clang_getCursorVisibility() API
May 31 2016, 9:02 AM
ehsan committed rL271291: Revert r253909 because it was committed with an incorrect message.
Revert r253909 because it was committed with an incorrect message
May 31 2016, 8:48 AM

May 4 2016

ehsan resigned from D19825: Power9 - Add exploitation of vector load and store that do not require swaps.
May 4 2016, 8:57 AM

Mar 3 2016

ehsan accepted D17767: [ms-inline-asm][AVX512] Add ability to use k registers in MS inline asm + fix bag with curly braces.

This looks good to me, but I would prefer someone else to also look over both parts...

Mar 3 2016, 9:19 AM

Mar 1 2016

ehsan accepted D17766: [ms-inline-asm][AVX512] Add ability to use k registers in MS inline asm + fix bag with curly braces.

LGTM.

Mar 1 2016, 7:36 AM

Feb 24 2016

ehsan resigned from D16798: Update cmake build on recent Haiku.

I'm afraid I'm not a good reviewer for this. Sorry!

Feb 24 2016, 6:57 AM

Feb 22 2016

ehsan added a comment to D17358: llvm-config: Don't check for "lib" prefix.

I think http://reviews.llvm.org/D17300 is a better solution for this. Can you please try that patch?

Feb 22 2016, 12:47 PM
ehsan accepted D17496: [ms-inline-asm] Fix bug in single asm statement support.

Thanks, LGTM!

Feb 22 2016, 12:39 PM
ehsan accepted D17300: llvm-config: fix --libs on Linux.
Feb 22 2016, 12:37 PM
ehsan added a comment to D17300: llvm-config: fix --libs on Linux.

(Sorry for the delay, I just got back from vacation!)

Feb 22 2016, 12:37 PM
ehsan resigned from D17486: Optionally demote fatal errors to non-fatal errors..

I don't feel confident in reviewing this, but based on a cursory look the patch looks fine. :-)

Feb 22 2016, 12:26 PM · Restricted Project

Feb 10 2016

ehsan committed rL260386: Disable all llvm-config tests for now, will investigate later.
Disable all llvm-config tests for now, will investigate later
Feb 10 2016, 9:34 AM

Feb 9 2016

ehsan committed rL260281: Remove system-libs.test for now.
Remove system-libs.test for now
Feb 9 2016, 1:22 PM
ehsan committed rL260280: Fix a test added in r260263.
Fix a test added in r260263
Feb 9 2016, 1:14 PM
ehsan committed rL260276: Fix the test added in r260266.
Fix the test added in r260266
Feb 9 2016, 12:53 PM
ehsan committed rL260269: Fix a typo in r260263.
Fix a typo in r260263
Feb 9 2016, 12:07 PM
ehsan committed rL260266: clang-cl: Enable plugins on Windows.
clang-cl: Enable plugins on Windows
Feb 9 2016, 11:47 AM
ehsan committed rL260265: clang-cl: Support loading plugins on Windows.
clang-cl: Support loading plugins on Windows
Feb 9 2016, 11:47 AM
ehsan committed rL260263: llvm-config: Add preliminary Windows support.
llvm-config: Add preliminary Windows support
Feb 9 2016, 11:45 AM
ehsan closed D16762: llvm-config: Add preliminary Windows support by committing rL260263: llvm-config: Add preliminary Windows support.
Feb 9 2016, 11:45 AM
ehsan committed rL260262: Turn on LLVM_ENABLE_PLUGINS by default on Windows.
Turn on LLVM_ENABLE_PLUGINS by default on Windows
Feb 9 2016, 11:41 AM
ehsan committed rL260261: Add support for importing and exporting Registry objects on Windows.
Add support for importing and exporting Registry objects on Windows
Feb 9 2016, 11:41 AM
ehsan closed D16760: Add support for importing and exporting Registry objects on Windows by committing rL260262: Turn on LLVM_ENABLE_PLUGINS by default on Windows.
Feb 9 2016, 11:41 AM

Feb 5 2016

ehsan updated the diff for D16761: clang-cl: Support loading plugins on Windows.

Sorry for the noise, arconist fail...

Feb 5 2016, 2:55 PM
ehsan updated the diff for D16761: clang-cl: Support loading plugins on Windows.

Updating based on the LLVM side changes.

Feb 5 2016, 2:54 PM
ehsan updated the diff for D16760: Add support for importing and exporting Registry objects on Windows.

Addressed the review comments.

Feb 5 2016, 2:50 PM
ehsan added inline comments to D16760: Add support for importing and exporting Registry objects on Windows.
Feb 5 2016, 2:43 PM
ehsan updated the diff for D16762: llvm-config: Add preliminary Windows support.

This fixes a couple of bugs in the previous iteration of the patch.

Feb 5 2016, 2:01 PM
ehsan updated the diff for D16465: [MS ABI] Prevent some expressions from evaluating to a constant.

Addressed the review comments.

Feb 5 2016, 9:00 AM

Feb 2 2016

ehsan added a comment to D16503: [MSVC Compat] Warn when suppressing a trailing comma in macro args.

Sorry for the slow response. I was reading http://reviews.llvm.org/D15670 to understand this patch, and I couldn't find anything in that patch that enables this extension only in Microsoft mode. Trying suppressed-comma-msextension.cpp locally, it seems to pass without -fms-compatibility too. Am I missing something, or does http://reviews.llvm.org/D15670 lack a check for MicrosoftExt?

Feb 2 2016, 3:24 PM
ehsan added a comment to D16760: Add support for importing and exporting Registry objects on Windows.
In D16760#342227, @rnk wrote:

Importing symbols on Windows is a hopeless effort. We'd either need to spray everything in clang with a CLANG_API macro that resolves to dllimport/dllexport depending on what you're building, or maintain a .def file with mangled names of everything we export, both of which are terrible solutions IMO. This setup is intended to be used with static linking:

CMake has some new auto-export functionality that I want to look into at some point. It didn't work immediately out of the box, so I had to put it aside for now, but eventually, I would like to stop statically linking clang.exe.

Feb 2 2016, 3:15 PM
ehsan added a comment to D16760: Add support for importing and exporting Registry objects on Windows.
In D16760#342008, @rnk wrote:

How do you deal with importing symbols from the clang exectuable? For Chromium, we statically link our plugins into the clang binary and let the registry do its thing that way.

Feb 2 2016, 12:09 PM

Jan 31 2016

ehsan retitled D16762: llvm-config: Add preliminary Windows support from to llvm-config: Add preliminary Windows support.
Jan 31 2016, 4:41 PM
ehsan retitled D16761: clang-cl: Support loading plugins on Windows from to clang-cl: Support loading plugins on Windows.
Jan 31 2016, 3:58 PM
ehsan retitled D16760: Add support for importing and exporting Registry objects on Windows from to Add support for importing and exporting Registry objects on Windows.
Jan 31 2016, 3:57 PM

Jan 25 2016

ehsan committed rL258776: Recommit the test for r258720 using -###.
Recommit the test for r258720 using -###
Jan 25 2016, 6:27 PM
ehsan committed rL258772: Revert the test for r258720 temporarily.
Revert the test for r258720 temporarily
Jan 25 2016, 5:55 PM
ehsan committed rL258720: [MSVC Compat] Only warn for unknown clang-cl arguments.
[MSVC Compat] Only warn for unknown clang-cl arguments
Jan 25 2016, 1:19 PM
ehsan closed D16511: [MSVC Compat] Only warn for unknown clang-cl arguments by committing rL258720: [MSVC Compat] Only warn for unknown clang-cl arguments.
Jan 25 2016, 1:18 PM
ehsan added a comment to D16511: [MSVC Compat] Only warn for unknown clang-cl arguments.

Thanks for the reviews! Will address both when landing.

Jan 25 2016, 1:03 PM

Jan 23 2016

ehsan retitled D16511: [MSVC Compat] Only warn for unknown clang-cl arguments from to [MSVC Compat] Only warn for unknown clang-cl arguments.
Jan 23 2016, 10:34 AM

Jan 22 2016

ehsan retitled D16503: [MSVC Compat] Warn when suppressing a trailing comma in macro args from to [MSVC Compat] Warn when suppressing a trailing comma in macro args.
Jan 22 2016, 7:47 PM
ehsan committed rL258530: [MSVC Compat] Accept elided commas in macro function arguments.
[MSVC Compat] Accept elided commas in macro function arguments
Jan 22 2016, 11:30 AM
ehsan closed D15670: Accept elided commas in macro function arguments for MS compatibility by committing rL258530: [MSVC Compat] Accept elided commas in macro function arguments.
Jan 22 2016, 11:30 AM
ehsan added a comment to D15670: Accept elided commas in macro function arguments for MS compatibility.

Sure. I'd be happy to address any comments post-landing.

Jan 22 2016, 11:28 AM
ehsan added a comment to D16465: [MS ABI] Prevent some expressions from evaluating to a constant.
In D16465#333688, @rnk wrote:

Your code won't catch this test case:

static int x;
extern inline const bool *f() {
  static const bool p = !&x;
  return &p;
}

Getting this exactly right is going to be a challenge. =/

Jan 22 2016, 11:17 AM
ehsan added inline comments to D16465: [MS ABI] Prevent some expressions from evaluating to a constant.
Jan 22 2016, 7:17 AM
ehsan retitled D16465: [MS ABI] Prevent some expressions from evaluating to a constant from to [MS ABI] Prevent some expressions from evaluating to a constant.
Jan 22 2016, 7:15 AM

Jan 20 2016

ehsan added a comment to D15670: Accept elided commas in macro function arguments for MS compatibility.

Richard: ping?

Jan 20 2016, 2:07 PM

Dec 31 2015

ehsan abandoned D15839: Move _xgetbv to immintrin.h.

Oops, sorry, I submitted this by mistake.

Dec 31 2015, 1:58 PM
ehsan retitled D15839: Move _xgetbv to immintrin.h from to Move _xgetbv to immintrin.h.
Dec 31 2015, 1:40 PM

Dec 28 2015

ehsan accepted D15795: [ms inline asm] Add support for label names with '$' chars.

LGTM.

Dec 28 2015, 8:20 AM

Dec 19 2015

ehsan retitled D15670: Accept elided commas in macro function arguments for MS compatibility from to Accept elided commas in macro function arguments for MS compatibility.
Dec 19 2015, 1:40 PM

Nov 23 2015

ehsan accepted D13388: Add support for querying the visibility of a cursor.

Landed in r253909.

Nov 23 2015, 11:59 AM
ehsan committed rL253909: Make clang_Cursor_getMangling not mangle if the declaration isn't mangled.
Make clang_Cursor_getMangling not mangle if the declaration isn't mangled
Nov 23 2015, 11:59 AM

Oct 29 2015

ehsan committed rL251638: Add a link to the DXR project.
Add a link to the DXR project
Oct 29 2015, 10:22 AM

Oct 7 2015

ehsan committed rL249639: Make clang_Cursor_getMangling not mangle if the declaration isn't mangled.
Make clang_Cursor_getMangling not mangle if the declaration isn't mangled
Oct 7 2015, 5:03 PM

Oct 6 2015

ehsan committed rL249440: Revert r249437.
Revert r249437
Oct 6 2015, 11:55 AM
ehsan closed D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled.

Landed in r249437.

Oct 6 2015, 11:26 AM
ehsan committed rL249437: Make clang_Cursor_getMangling don't mangle if the declaration isn't mangled.
Make clang_Cursor_getMangling don't mangle if the declaration isn't mangled
Oct 6 2015, 11:26 AM

Oct 2 2015

ehsan updated subscribers of D13388: Add support for querying the visibility of a cursor.
Oct 2 2015, 11:34 AM
ehsan updated subscribers of D13317: clang_Cursor_getMangling shouldn't mangle if the declaration isn't mangled.
Oct 2 2015, 8:14 AM

Aug 18 2015

ehsan committed rL245401: Insert override at the same line as the end of the function declaration.
Insert override at the same line as the end of the function declaration
Aug 18 2015, 7:06 PM
ehsan closed D9286: Insert override at the same line as the end of the function declaration by committing rL245401: Insert override at the same line as the end of the function declaration.
Aug 18 2015, 7:06 PM
ehsan abandoned D9285: Add a KeepVirtual option to misc-use-override.
Aug 18 2015, 5:44 PM

Aug 14 2015

ehsan added a comment to D9286: Insert override at the same line as the end of the function declaration.

I should land this, but let's wait to see if we want http://reviews.llvm.org/D9285 or not, since this patch is built on top of it. If not, I can rebase it on top of master as well.

Aug 14 2015, 1:40 PM
ehsan added a comment to D9285: Add a KeepVirtual option to misc-use-override.

Sorry, I kind of dropped the ball here!

Aug 14 2015, 1:36 PM

Jun 8 2015

ehsan added a comment to D10313: [clang-cl] Ignore the /o option when /P is specified..

http://llvm.org/PR20894 is a good read here.

Jun 8 2015, 7:29 AM

Apr 26 2015

ehsan retitled D9286: Insert override at the same line as the end of the function declaration from to Insert override at the same line as the end of the function declaration.
Apr 26 2015, 6:34 PM
ehsan retitled D9285: Add a KeepVirtual option to misc-use-override from to Add a KeepVirtual option to misc-use-override.
Apr 26 2015, 5:43 PM

Mar 25 2015

ehsan committed rL233211: Fix coverage-ld.c on systems with an Android linker in $PATH.
Fix coverage-ld.c on systems with an Android linker in $PATH
Mar 25 2015, 1:20 PM
ehsan closed D8598: Fix coverage-ld.c on systems with an Android linker in $PATH by committing rL233211: Fix coverage-ld.c on systems with an Android linker in $PATH.
Mar 25 2015, 1:20 PM

Mar 24 2015

ehsan retitled D8598: Fix coverage-ld.c on systems with an Android linker in $PATH from to Fix coverage-ld.c on systems with an Android linker in $PATH.
Mar 24 2015, 6:04 PM
ehsan committed rL233160: Diagnose declspecs occuring after virt-specifier-seq and generate fixit hints.
Diagnose declspecs occuring after virt-specifier-seq and generate fixit hints
Mar 24 2015, 5:56 PM
ehsan committed rL233161: Diagnose ref-qualifiers occuring after virt-specifier-seq and generate fixit….
Diagnose ref-qualifiers occuring after virt-specifier-seq and generate fixit…
Mar 24 2015, 5:56 PM
ehsan added a comment to D6828: Diagnose declspecs occuring after virt-specifier-seq and generate fixit hints.

I'm having difficulty fixing the issue that caused this patch to bounce when I landed it earlier this morning. Here is a link to the log of the test failure: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/24611/steps/check-all/logs/FAIL%3A%20Clang%3A%3Afixit-cxx0x.cpp

Mar 24 2015, 2:28 PM
ehsan committed rL233074: Revert "Diagnose declspecs occuring after virt-specifier-seq and generate fixit….
Revert "Diagnose declspecs occuring after virt-specifier-seq and generate fixit…
Mar 24 2015, 6:28 AM
ehsan committed rL233073: Revert "Diagnose ref-qualifiers occuring after virt-specifier-seq and generate….
Revert "Diagnose ref-qualifiers occuring after virt-specifier-seq and generate…
Mar 24 2015, 6:28 AM
ehsan committed rL233069: Diagnose declspecs occuring after virt-specifier-seq and generate fixit hints.
Diagnose declspecs occuring after virt-specifier-seq and generate fixit hints
Mar 24 2015, 6:05 AM
ehsan committed rL233070: Diagnose ref-qualifiers occuring after virt-specifier-seq and generate fixit….
Diagnose ref-qualifiers occuring after virt-specifier-seq and generate fixit…
Mar 24 2015, 6:05 AM
ehsan closed D7012: Diagnose ref-qualifiers occuring after virt-specifier-seq and generate fixit hints by committing rL233070: Diagnose ref-qualifiers occuring after virt-specifier-seq and generate fixit….
Mar 24 2015, 6:05 AM