Page MenuHomePhabricator

milianw (Milian Wolff)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2015, 3:14 PM (209 w, 6 d)

Recent Activity

May 21 2019

milianw added a comment to D60672: [libclang] visit c++14 lambda capture init expressions.

thanks!

May 21 2019, 4:39 AM · Restricted Project
milianw added a comment to D60672: [libclang] visit c++14 lambda capture init expressions.

Do you have commit rights? Can you push that for me?

May 21 2019, 1:57 AM · Restricted Project

May 17 2019

milianw added a comment to D60672: [libclang] visit c++14 lambda capture init expressions.

@nik odd, it works for me, I just switched to master (previously I used the 8x release branch) and applied this patch and build it all. Then I run:

May 17 2019, 2:51 AM · Restricted Project

Apr 17 2019

milianw added a reviewer for D60672: [libclang] visit c++14 lambda capture init expressions: klimek.
Apr 17 2019, 3:40 AM · Restricted Project

Apr 14 2019

milianw created D60672: [libclang] visit c++14 lambda capture init expressions.
Apr 14 2019, 11:58 AM · Restricted Project
Herald added a project to D43763: libclang: Visit class template instantiations: Restricted Project.

looks good, but this needs a test, could you add one please?

Apr 14 2019, 2:34 AM · Restricted Project, Unknown Object (Project)

Jan 9 2018

milianw requested changes to D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.

I'm pretty sure this is not ABI compatible. You change the size of CXCompletionResult, so when anyone is iterating over the array in CXCompletionResults it will break. If you don't want to, I can try to find some time to take this over again ;-)

Jan 9 2018, 4:52 AM
milianw added a comment to D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface.

still looks good to me. can someone else please review and commit this?

Jan 9 2018, 4:50 AM · Restricted Project
milianw set the repository for D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface to rC Clang.
Jan 9 2018, 4:47 AM · Restricted Project
milianw set the repository for D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result to rC Clang.
Jan 9 2018, 4:47 AM
milianw added a comment to D27764: File descriptor leaks on header files that contain errors.

Can this be abandoned now that the issue Erik has mentioned got fixed?

Jan 9 2018, 4:31 AM · Unknown Object (Project)

Sep 21 2017

milianw requested changes to D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.

I don't think this upholds the ABI guarantee, but maybe I'm wrong? Can someone else chime in please? @klimek ?

Sep 21 2017, 6:43 AM

Sep 9 2017

milianw added a comment to D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result.

lgtm, but could we get some more tests rather than only this one for templates?

Sep 9 2017, 1:58 AM
milianw abandoned D13599: Add a way to get the CXCursor that corresponds to a completion result..

superseded by https://reviews.llvm.org/D37650

Sep 9 2017, 1:54 AM

Aug 30 2017

milianw added a comment to D13599: Add a way to get the CXCursor that corresponds to a completion result..

Long time no see - sorry for the delay. I want to pick this up again. Would you say I should add the tests as separate tests (i.e. something like -code-completion-cursors-at), or should I rather output the cursor in addition when requesting -code-completion-at, and then extend all existing unit tests with the cursor information?

As it's a new function, I'd add a separate test.

Aug 30 2017, 1:19 AM

Apr 19 2017

milianw requested changes to D32152: Expose NoReturn attribute to libclang.

lgtm in general, but this patch is missing a unit test

Apr 19 2017, 12:54 AM · Unknown Object (Project)

Sep 15 2016

milianw accepted D18462: Fix for clang_Cursor_getSpellingNameRange().

agreed, lgtm but someone else must accept this upstream

Sep 15 2016, 2:35 AM · Unknown Object (Project)

Sep 12 2016

milianw added a comment to D13599: Add a way to get the CXCursor that corresponds to a completion result..

Long time no see - sorry for the delay. I want to pick this up again. Would you say I should add the tests as separate tests (i.e. something like -code-completion-cursors-at), or should I rather output the cursor in addition when requesting -code-completion-at, and then extend all existing unit tests with the cursor information?

Sep 12 2016, 7:05 AM

Sep 11 2016

milianw added a comment to D18462: Fix for clang_Cursor_getSpellingNameRange().

ping, any update on this?

Sep 11 2016, 12:54 PM · Unknown Object (Project)

Mar 24 2016

milianw added a reviewer for D18462: Fix for clang_Cursor_getSpellingNameRange(): klimek.
Mar 24 2016, 4:03 PM · Unknown Object (Project)
milianw added a comment to D18462: Fix for clang_Cursor_getSpellingNameRange().

+1 from my side, but someone else has to approve

Mar 24 2016, 4:03 PM · Unknown Object (Project)
milianw added a comment to D5041: Fix for clang_Cursor_getSpellingNameRange() reportage of C++ functions.

+1 from my side, but someone else has to approve.

Mar 24 2016, 4:02 PM · Unknown Object (Project)
milianw added reviewers for D5041: Fix for clang_Cursor_getSpellingNameRange() reportage of C++ functions: milianw, klimek.
Mar 24 2016, 4:02 PM · Unknown Object (Project)

Mar 5 2016

milianw accepted D15729: Load compiler plugins in ASTUnit, too.

Still good from my side. @klimek, @rsmith: Could you please review this as well?

Mar 5 2016, 5:42 AM
milianw added reviewers for D15729: Load compiler plugins in ASTUnit, too: klimek, rsmith.
Mar 5 2016, 5:42 AM

Mar 2 2016

milianw accepted D17824: Bump libclang API version after r262318.

lgtm - I should have done that directly. Sadly, I didn't receive my commit rights either yet ;-)

Mar 2 2016, 12:23 PM · Unknown Object (Project)
milianw added a comment to D17820: Clang Code Completion Filtering .

@akyrtzi raises a very valid point - I did not think about that. KDevelop uses the clang-c API and does fuzzy matching on top of the results, e.g. for camel-case matching. But, we currently always request code completion at a word start boundary so nothing would change for us. That said, I see how this patch could be seen as a breaking behavior change, and thus should probably only get enabled by an explicit option - if at all.

Mar 2 2016, 11:54 AM
milianw added a comment to D17820: Clang Code Completion Filtering .

I'm not yet acquainted enough with the code at hand, but I wonder whether I'm understanding the code correctly:

Mar 2 2016, 11:40 AM

Feb 29 2016

milianw added a comment to D17486: Optionally demote fatal errors to non-fatal errors..

Thanks Manuel!

Feb 29 2016, 3:57 AM · Unknown Object (Project)
milianw updated the diff for D17486: Optionally demote fatal errors to non-fatal errors..

attended klimek's review comments

Feb 29 2016, 3:05 AM · Unknown Object (Project)
milianw added a comment to D17486: Optionally demote fatal errors to non-fatal errors..

Ping? This patch would be very helpful for us to have in KDevelop. Can anyone give us a review please? I'm willing to amend it as needed to get this issue resolved.

Feb 29 2016, 1:19 AM · Unknown Object (Project)

Feb 21 2016

milianw added a reviewer for D17486: Optionally demote fatal errors to non-fatal errors.: rsmith.
Feb 21 2016, 2:14 AM · Unknown Object (Project)

Feb 20 2016

milianw added a project to D17486: Optionally demote fatal errors to non-fatal errors.: Unknown Object (Project).
Feb 20 2016, 5:30 PM · Unknown Object (Project)
milianw retitled D17486: Optionally demote fatal errors to non-fatal errors. from to Optionally demote fatal errors to non-fatal errors..
Feb 20 2016, 5:29 PM · Unknown Object (Project)
milianw closed D13388: Add support for querying the visibility of a cursor.

closing then, since this has been landed

Feb 20 2016, 5:29 PM

Dec 23 2015

milianw added a comment to D15729: Load compiler plugins in ASTUnit, too.

lgtm, but someone else should approve

Dec 23 2015, 2:12 PM

Dec 13 2015

milianw added a comment to D13001: [libclang] Handle AutoType in clang_getTypeDeclaration.

lgtm, but someone else should approve

Dec 13 2015, 2:28 PM

Nov 22 2015

milianw accepted D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface.

From my POV this is still fine. Manuel, Sergey - could you have a look at this please and push it upstream if you agree with me?

Nov 22 2015, 10:55 AM · Restricted Project

Nov 14 2015

milianw accepted D13388: Add support for querying the visibility of a cursor.

From my POV, this looks good.

Nov 14 2015, 9:05 AM

Nov 1 2015

milianw accepted D13844: [libclang] Visit TypeAliasTemplateDecl.

+1 from my side, but someone else has to approve

Nov 1 2015, 3:53 PM

Oct 19 2015

milianw added a comment to D13000: [libclang] Expose AutoType.

Looks good to me!

Oct 19 2015, 4:39 AM
milianw added a comment to D13001: [libclang] Handle AutoType in clang_getTypeDeclaration.

Adding tests wouldn't hurt though, quite the contrary. Especially if it wasn't tested before. Otherwise, this looks good to me.

Oct 19 2015, 4:39 AM

Oct 13 2015

milianw added reviewers for D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface: skalinichev, kfunk, OlivierJG.
Oct 13 2015, 5:03 AM · Restricted Project
milianw added a comment to D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface.

This looks good to me, but it's missing a unit test. Take a look at http://reviews.llvm.org/D13388 for how to do that in principle.

Oct 13 2015, 5:03 AM · Restricted Project
milianw added reviewers for D13388: Add support for querying the visibility of a cursor: skalinichev, OlivierJG, kfunk.
Oct 13 2015, 4:17 AM
milianw added a comment to D13388: Add support for querying the visibility of a cursor.

Yep, looks good to me as well - thanks!

Oct 13 2015, 4:16 AM

Oct 9 2015

milianw updated D13599: Add a way to get the CXCursor that corresponds to a completion result..
Oct 9 2015, 11:12 AM
milianw added a comment to D13599: Add a way to get the CXCursor that corresponds to a completion result..

any suggestion as to where put unit tests for this?

Oct 9 2015, 11:11 AM
milianw retitled D13599: Add a way to get the CXCursor that corresponds to a completion result. from to Add a way to get the CXCursor that corresponds to a completion result..
Oct 9 2015, 11:10 AM

Oct 1 2015

milianw added a comment to D13344: Keep the IfStmt node even if the condition is invalid .

Is there still an error reported for the invalid condition?

Oct 1 2015, 7:27 AM
milianw added reviewers for D13344: Keep the IfStmt node even if the condition is invalid : klimek, skalinichev, milianw, kfunk, OlivierJG.
Oct 1 2015, 7:24 AM

Sep 18 2015

milianw added a comment to D12666: [LibClang] Fix clang_getCursorAvailability.

Ping? Can someone please submit this upstream?

Sep 18 2015, 5:25 AM