Page MenuHomePhabricator

ogoffart (Olivier Goffart)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 21 2013, 12:48 AM (315 w, 11 h)

Recent Activity

Nov 23 2017

ogoffart committed rL318900: Do not perform the analysis based warning if the warnings are ignored.
Do not perform the analysis based warning if the warnings are ignored
Nov 23 2017, 12:17 AM
ogoffart closed D40242: Do not perform the analysis based warning if all warnings are ignored by committing rL318900: Do not perform the analysis based warning if the warnings are ignored.
Nov 23 2017, 12:17 AM

Nov 20 2017

ogoffart updated the diff for D40242: Do not perform the analysis based warning if all warnings are ignored.

I added a test.
I did not add such test before because i know that calling Reset() on the diagnostics is kind of a hack.

Nov 20 2017, 11:48 PM
ogoffart added a comment to D40242: Do not perform the analysis based warning if all warnings are ignored.

You should add a test case that demonstrates code which would otherwise trigger an analysis-based warning but doesn't due to disabling all warnings.

Nov 20 2017, 10:57 PM
ogoffart added inline comments to D40242: Do not perform the analysis based warning if all warnings are ignored.
Nov 20 2017, 6:30 AM
ogoffart added a comment to D40242: Do not perform the analysis based warning if all warnings are ignored.

I do not know how to add a test: there is no real visible change for clang. It just should be faster when passing "-w".

Nov 20 2017, 4:44 AM
ogoffart created D40242: Do not perform the analysis based warning if all warnings are ignored.
Nov 20 2017, 3:47 AM

Oct 16 2017

ogoffart updated the diff for D26350: Keep invalid Switch in the AST.

Updated the patch so that ActOnStartOfSwitchStmt returns void, and ActOnFinishSwitchStmt will skip some checks in case of error

Oct 16 2017, 5:49 AM

Oct 10 2017

ogoffart added a reviewer for D26350: Keep invalid Switch in the AST: erikjv.
Oct 10 2017, 2:58 AM

Jul 25 2017

ogoffart added a comment to D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant.

ping

Jul 25 2017, 1:33 AM

Jul 14 2017

ogoffart added a comment to D26350: Keep invalid Switch in the AST.

Thanks for your review and i'll try to address the concerns.

Jul 14 2017, 11:33 PM
ogoffart added a comment to D26350: Keep invalid Switch in the AST.

The problem i'm trying to solve is precisely to keep as much as possible of the valid AST in the main AST, despite errors.
I've already done some work with r249982, r272962 and more, and there is still a lot to do. But the goal is to keep as much as possible of it.

Jul 14 2017, 6:27 AM
ogoffart committed rL308008: Keep the IdentifierInfo in the Token for alternative operator keyword.
Keep the IdentifierInfo in the Token for alternative operator keyword
Jul 14 2017, 2:24 AM
ogoffart closed D35172: Keep the IdentifierInfo in the Token for alternative operator keyword by committing rL308008: Keep the IdentifierInfo in the Token for alternative operator keyword.
Jul 14 2017, 2:24 AM
ogoffart added a comment to D26350: Keep invalid Switch in the AST.

re-ping

Jul 14 2017, 12:53 AM
ogoffart added a comment to D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant.

Is there any objections for this patch?

Jul 14 2017, 12:51 AM

Jul 13 2017

ogoffart added a comment to D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant.

Thanks for the link to the bug report.
This patch mostly address the evaluation within a constexpr, which is orthogonal to the changes in the backend suggered in that bug report.

Jul 13 2017, 12:16 AM

Jul 12 2017

ogoffart added a comment to D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant.
What if the constexpr function is called with in a non-constexpr context, e.g. with a random global variable as argument?
Jul 12 2017, 7:20 AM

Jul 11 2017

ogoffart added a comment to D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant.

Ping

Jul 11 2017, 11:48 PM

Jul 10 2017

ogoffart created D35190: __builtin_constant_p should consider the parameter of a constexpr function as constant.
Jul 10 2017, 1:00 AM
ogoffart updated the diff for D35172: Keep the IdentifierInfo in the Token for alternative operator keyword.
Jul 10 2017, 12:50 AM
ogoffart updated the diff for D35172: Keep the IdentifierInfo in the Token for alternative operator keyword.

Added check for "#if and_eq"

Jul 10 2017, 12:46 AM
ogoffart added inline comments to D35172: Keep the IdentifierInfo in the Token for alternative operator keyword.
Jul 10 2017, 12:44 AM

Jul 9 2017

ogoffart updated the summary of D35172: Keep the IdentifierInfo in the Token for alternative operator keyword.
Jul 9 2017, 6:14 AM
ogoffart created D35172: Keep the IdentifierInfo in the Token for alternative operator keyword.
Jul 9 2017, 6:13 AM

Jul 7 2017

ogoffart committed rL307371: Fix crash parsing invalid code.
Fix crash parsing invalid code
Jul 7 2017, 2:39 AM
ogoffart closed D35108: Fix crash parsing invalid code by committing rL307371: Fix crash parsing invalid code.
Jul 7 2017, 2:39 AM
ogoffart created D35108: Fix crash parsing invalid code.
Jul 7 2017, 12:51 AM

Mar 17 2017

ogoffart added a comment to D26350: Keep invalid Switch in the AST.

Ping

Mar 17 2017, 3:05 AM

Dec 22 2016

ogoffart added a comment to D26350: Keep invalid Switch in the AST.

ping2

Dec 22 2016, 3:35 AM
ogoffart updated the diff for D26465: [Diag] Optimize DiagnosticIDs::getDiagnosticSeverity.
Dec 22 2016, 3:35 AM
ogoffart added a comment to D26465: [Diag] Optimize DiagnosticIDs::getDiagnosticSeverity.

What did you test the parsing on? Will this patch get similar improvements for code that compiles without errors and warnings?

Dec 22 2016, 3:32 AM

Nov 29 2016

ogoffart added a comment to D26465: [Diag] Optimize DiagnosticIDs::getDiagnosticSeverity.

Ping 2

Nov 29 2016, 6:52 AM

Nov 20 2016

ogoffart added a comment to D26465: [Diag] Optimize DiagnosticIDs::getDiagnosticSeverity.

ping?

Nov 20 2016, 4:24 AM
ogoffart added a comment to D26350: Keep invalid Switch in the AST.

ping?

Nov 20 2016, 4:24 AM

Nov 9 2016

ogoffart retitled D26465: [Diag] Optimize DiagnosticIDs::getDiagnosticSeverity from to [Diag] Optimize DiagnosticIDs::getDiagnosticSeverity.
Nov 9 2016, 10:38 AM

Nov 7 2016

ogoffart added a comment to D26350: Keep invalid Switch in the AST.

I believe only the change in ActOnFinishSwitchStmt might be controversial.
Is it breaking an invariant than having switches kept in the AST?

Nov 7 2016, 6:42 AM
ogoffart retitled D26350: Keep invalid Switch in the AST from to Keep invalid Switch in the AST.
Nov 7 2016, 6:40 AM

Nov 4 2016

ogoffart committed rL285994: [test] Test that static_assert is properly visited in liblcang.
[test] Test that static_assert is properly visited in liblcang
Nov 4 2016, 11:07 AM
ogoffart committed rL285986: [python bindings] Expose CXCursor_FriendDecl as CursorKind.FRIEND_DECL.
[python bindings] Expose CXCursor_FriendDecl as CursorKind.FRIEND_DECL
Nov 4 2016, 12:00 AM

Nov 3 2016

ogoffart committed rL285984: [index] Expose FriendDecl.
[index] Expose FriendDecl
Nov 3 2016, 11:39 PM
ogoffart closed D26285: [index] Expose FriendDecl by committing rL285984: [index] Expose FriendDecl.
Nov 3 2016, 11:39 PM
ogoffart edited reviewers for D26285: [index] Expose FriendDecl, added: klimek; removed: alexey.klimov.dev.
Nov 3 2016, 11:25 AM
ogoffart added a comment to D26285: [index] Expose FriendDecl.

KDevelop bug report: https://bugs.kde.org/show_bug.cgi?id=360509

Nov 3 2016, 10:40 AM
ogoffart retitled D26285: [index] Expose FriendDecl from to [index] Expose FriendDecl.
Nov 3 2016, 10:35 AM
ogoffart committed rL285883: Fix heuristics skipping invalid ctor-initializers with C++11.
Fix heuristics skipping invalid ctor-initializers with C++11
Nov 3 2016, 12:46 AM
ogoffart closed D21502: Fix heuristics skipping invalid ctor-initializers with C++11 by committing rL285883: Fix heuristics skipping invalid ctor-initializers with C++11.
Nov 3 2016, 12:45 AM

Oct 22 2016

ogoffart added a comment to D21502: Fix heuristics skipping invalid ctor-initializers with C++11.

Ping?
I guess i coud just commit it now.

Oct 22 2016, 8:46 AM

Aug 30 2016

ogoffart committed rL280118: Fix colored diagnostics from tools.
Fix colored diagnostics from tools
Aug 30 2016, 10:51 AM
ogoffart closed D23837: Fix colored diagnostics from tools by committing rL280118: Fix colored diagnostics from tools.
Aug 30 2016, 10:50 AM
ogoffart added a comment to D21502: Fix heuristics skipping invalid ctor-initializers with C++11.

Ping

Aug 30 2016, 3:00 AM
ogoffart added a comment to D21502: Fix heuristics skipping invalid ctor-initializers with C++11.

ping

Aug 30 2016, 2:55 AM
ogoffart added a comment to D23837: Fix colored diagnostics from tools .

Ping

Aug 30 2016, 2:55 AM

Aug 25 2016

ogoffart updated the diff for D23837: Fix colored diagnostics from tools .

This new patch make sure the test run fine as part of the testsuite, where the output is not a terminal and the color are disabled by default

Aug 25 2016, 5:07 AM
ogoffart added a comment to D21502: Fix heuristics skipping invalid ctor-initializers with C++11.

Regarding this:

Aug 25 2016, 4:52 AM
ogoffart updated the diff for D21502: Fix heuristics skipping invalid ctor-initializers with C++11.

Made the requested changes

Aug 25 2016, 4:42 AM
ogoffart updated the diff for D23837: Fix colored diagnostics from tools .

Added a test.

Aug 25 2016, 4:14 AM

Aug 24 2016

ogoffart retitled D23837: Fix colored diagnostics from tools from to Fix colored diagnostics from tools .
Aug 24 2016, 7:13 AM
ogoffart added a comment to D21502: Fix heuristics skipping invalid ctor-initializers with C++11.

Ping!

Aug 24 2016, 7:11 AM

Jun 28 2016

ogoffart added a comment to D21502: Fix heuristics skipping invalid ctor-initializers with C++11.

The problem i'm fixing here is how we recover invalid code in the ctor-init part as we skip the function body.
In particular, we want to know if the '{' is the begining of the body or not. In C++03, we always consider it as the beginng of the body. The problem was that in C++11 we don't, making the code skip too much, causing worse parse error later.

Jun 28 2016, 1:55 AM

Jun 19 2016

ogoffart added a comment to D21497: Fix test to specify C++03 (fails with C++11)..

I made http://reviews.llvm.org/D21502 that should also fix this test.

Jun 19 2016, 2:38 AM
ogoffart added a reviewer for D21502: Fix heuristics skipping invalid ctor-initializers with C++11: cfe-commits.
Jun 19 2016, 2:37 AM
ogoffart retitled D21502: Fix heuristics skipping invalid ctor-initializers with C++11 from to Fix heuristics skipping invalid ctor-initializers with C++11.
Jun 19 2016, 2:37 AM
ogoffart added a comment to D21497: Fix test to specify C++03 (fails with C++11)..

I'm sorry for commiting broken test.

Jun 19 2016, 12:38 AM

Jun 16 2016

ogoffart committed rL272963: Fix a few issues while skipping function bodies.
Fix a few issues while skipping function bodies
Jun 16 2016, 2:47 PM
ogoffart abandoned D19327: Keep invalid function body as part of the AST.

Replaced by http://reviews.llvm.org/D19764

Jun 16 2016, 2:47 PM
ogoffart closed D20821: Fix a few issues while skipping function bodies by committing rL272963: Fix a few issues while skipping function bodies.
Jun 16 2016, 2:47 PM
ogoffart committed rL272962: Keep invalid functions as part of the AST.
Keep invalid functions as part of the AST
Jun 16 2016, 2:46 PM
ogoffart closed D19764: Keep invalid functions as part of the AST by committing rL272962: Keep invalid functions as part of the AST.
Jun 16 2016, 2:46 PM
ogoffart committed rL272961: Functions declared in a scope should not hide previous declaration in earlier….
Functions declared in a scope should not hide previous declaration in earlier…
Jun 16 2016, 2:46 PM
ogoffart closed D19763: Functions declared in a scope should not hide previous declaration in earlier scopes by committing rL272961: Functions declared in a scope should not hide previous declaration in earlier….
Jun 16 2016, 2:46 PM

Jun 10 2016

ogoffart updated the diff for D20821: Fix a few issues while skipping function bodies.

Using Parser::ConsumeAndStoreFunctionPrologue this time

Jun 10 2016, 4:48 AM

Jun 9 2016

ogoffart committed rL272274: Make sizeof and alignof a CXCursor_UnaryExpr.
Make sizeof and alignof a CXCursor_UnaryExpr
Jun 9 2016, 9:23 AM
ogoffart closed D18081: Make sizeof and alignof a CXCursor_UnaryExpr by committing rL272274: Make sizeof and alignof a CXCursor_UnaryExpr.
Jun 9 2016, 9:22 AM
ogoffart committed rL272273: CIndex: add support for static_assert.
CIndex: add support for static_assert
Jun 9 2016, 9:22 AM
ogoffart closed D18080: CIndex: add support for static_assert by committing rL272273: CIndex: add support for static_assert.
Jun 9 2016, 9:22 AM
ogoffart added a reviewer for D18080: CIndex: add support for static_assert: bkramer.
Jun 9 2016, 6:18 AM
ogoffart added a reviewer for D18081: Make sizeof and alignof a CXCursor_UnaryExpr: bkramer.
Jun 9 2016, 6:18 AM
ogoffart added a comment to D20821: Fix a few issues while skipping function bodies.

The idea is that when we see a ") {" or "} {" in the ctor-initializers, (optionally with "..."), it is necessarily the start of the body.

Jun 9 2016, 5:11 AM
ogoffart added a comment to D19763: Functions declared in a scope should not hide previous declaration in earlier scopes .

Ping.
This would be required for http://reviews.llvm.org/D19764

Jun 9 2016, 5:03 AM
ogoffart added a comment to D18080: CIndex: add support for static_assert.

Ping 2.

Jun 9 2016, 5:01 AM
ogoffart added a comment to D18081: Make sizeof and alignof a CXCursor_UnaryExpr.

Ping 2.

Jun 9 2016, 5:01 AM

Jun 1 2016

ogoffart updated the diff for D20821: Fix a few issues while skipping function bodies.

Right, i forgot about the C++11 initializer list syntax. I hope I got it right now.

Jun 1 2016, 4:29 AM

May 31 2016

ogoffart retitled D20821: Fix a few issues while skipping function bodies from to Fix a few issues while skipping function bodies.
May 31 2016, 10:03 AM

May 26 2016

ogoffart committed rL270845: Fix crash while parsing variable template with variadic template arguments.
Fix crash while parsing variable template with variadic template arguments
May 26 2016, 6:02 AM
ogoffart closed D20511: Fix crash while parsing variable template with variadic template arguments by committing rL270845: Fix crash while parsing variable template with variadic template arguments.
May 26 2016, 6:02 AM

May 25 2016

ogoffart added a comment to D20511: Fix crash while parsing variable template with variadic template arguments.

I believe this is trivial so i will just commit it.

May 25 2016, 2:33 AM
ogoffart added a comment to D19327: Keep invalid function body as part of the AST.

Is this better than the alternative http://reviews.llvm.org/D19764 ?

May 25 2016, 2:32 AM

May 21 2016

ogoffart retitled D20511: Fix crash while parsing variable template with variadic template arguments from to Fix crash while parsing variable template with variadic template arguments.
May 21 2016, 10:58 AM

May 9 2016

ogoffart committed rL268895: Fix spurious warnings about unused private field.
Fix spurious warnings about unused private field
May 9 2016, 12:16 AM
ogoffart closed D20054: Fix spurious warnings about unused private field by committing rL268895: Fix spurious warnings about unused private field.
May 9 2016, 12:16 AM

May 8 2016

ogoffart retitled D20054: Fix spurious warnings about unused private field from to Fix spurious warnings about unused private field.
May 8 2016, 4:08 AM
ogoffart added a comment to D19764: Keep invalid functions as part of the AST.

Ping?

May 8 2016, 2:00 AM

Apr 30 2016

ogoffart added a comment to D19327: Keep invalid function body as part of the AST.

An alternative patch is uploaded there: http://reviews.llvm.org/D19764

Apr 30 2016, 4:48 AM
ogoffart retitled D19764: Keep invalid functions as part of the AST from to Keep invalid functions as part of the AST.
Apr 30 2016, 4:47 AM
ogoffart retitled D19763: Functions declared in a scope should not hide previous declaration in earlier scopes from to Functions declared in a scope should not hide previous declaration in earlier scopes .
Apr 30 2016, 4:42 AM

Apr 27 2016

ogoffart added inline comments to D19327: Keep invalid function body as part of the AST.
Apr 27 2016, 12:45 AM

Apr 26 2016

ogoffart added a comment to D19327: Keep invalid function body as part of the AST.

Ping?

Apr 26 2016, 6:26 AM

Apr 22 2016

ogoffart updated D19327: Keep invalid function body as part of the AST.
Apr 22 2016, 1:26 AM

Apr 20 2016

ogoffart retitled D19327: Keep invalid function body as part of the AST from to Keep invalid function body as part of the AST.
Apr 20 2016, 8:38 AM