Page MenuHomePhabricator

skalinichev (Sergey Kalinichev)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2015, 2:58 AM (206 w, 5 d)

Recent Activity

Apr 23 2017

skalinichev added inline comments to D32152: Expose NoReturn attribute to libclang.
Apr 23 2017, 3:49 AM · Restricted Project

Apr 22 2017

skalinichev added a reviewer for D32152: Expose NoReturn attribute to libclang: skalinichev.
Apr 22 2017, 9:17 AM · Restricted Project

Apr 21 2017

skalinichev added inline comments to D32152: Expose NoReturn attribute to libclang.
Apr 21 2017, 10:40 AM · Restricted Project

Apr 20 2017

skalinichev added a comment to D32152: Expose NoReturn attribute to libclang.

Patch lacking changes in tools/libclang/libclang.exports

Apr 20 2017, 10:52 AM · Restricted Project

Dec 13 2016

skalinichev added inline comments to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.
Dec 13 2016, 9:52 AM · Restricted Project

Dec 11 2016

skalinichev added inline comments to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.
Dec 11 2016, 1:38 PM · Restricted Project

Dec 4 2016

skalinichev added inline comments to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.
Dec 4 2016, 3:52 AM · Restricted Project
skalinichev added inline comments to D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.
Dec 4 2016, 2:03 AM · Restricted Project
skalinichev updated subscribers of D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType.

Some suggestions in D27384 from @compnerd also apply to your patch (at least about using auto), so you should probably fix it too.

Dec 4 2016, 1:49 AM · Restricted Project
skalinichev added a reviewer for D26907: libclang: Restore the CXXRecordDecl path for clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType: skalinichev.

Please, integrate test cases from D27384 into this patch and make sure that tests still pass.

Dec 4 2016, 1:40 AM · Restricted Project
skalinichev abandoned D27384: [libclang] Restore clang_getNumTemplateArguments/clang_getTemplateArgumentAsType functionality.

Turns out we already have another patch that fixes the same problem: D26907

Dec 4 2016, 1:36 AM · Restricted Project
skalinichev added a comment to D26663: libclang: Generalize clang_getNumTemplateArguments and clang_getTemplateArgumentAsType to other kind of specializations..

Ah, sorry I didn't notice that review, let's keep to your version of the patch then.

Dec 4 2016, 1:33 AM · Restricted Project

Dec 3 2016

skalinichev added a comment to D26663: libclang: Generalize clang_getNumTemplateArguments and clang_getTemplateArgumentAsType to other kind of specializations..

This breaks functionality of clang_getNumTemplateArguments/clang_getTemplateArgumentAsType in some case.

Dec 3 2016, 5:37 AM · Restricted Project
skalinichev removed a reviewer for D27384: [libclang] Restore clang_getNumTemplateArguments/clang_getTemplateArgumentAsType functionality: EricWF.
Dec 3 2016, 5:34 AM · Restricted Project
skalinichev updated the diff for D27384: [libclang] Restore clang_getNumTemplateArguments/clang_getTemplateArgumentAsType functionality.
Dec 3 2016, 5:33 AM · Restricted Project
skalinichev retitled D27384: [libclang] Restore clang_getNumTemplateArguments/clang_getTemplateArgumentAsType functionality from to [libclang] Restore clang_getNumTemplateArguments/clang_getTemplateArgumentAsType functionality.
Dec 3 2016, 5:32 AM · Restricted Project
skalinichev added a comment to D26446: libclang: Avoid returning an extra token in clang_tokenize.

This patch breaks python binding tests (which I fixes just now).
Please, next time launch python tests too

Dec 3 2016, 5:09 AM
skalinichev committed rL288582: [libclang] Fix python tests.
[libclang] Fix python tests
Dec 3 2016, 5:03 AM

May 3 2016

skalinichev committed rL268366: [libclang] Expose the ElaboratedType.
[libclang] Expose the ElaboratedType
May 3 2016, 12:04 AM
skalinichev closed D11797: [LIbClang] Report the named type for ElaboratedType by committing rL268366: [libclang] Expose the ElaboratedType.
May 3 2016, 12:04 AM

Apr 12 2016

skalinichev accepted D15469: Expose cxx constructor and method properties through libclang and python bindings..

LGTM!

Apr 12 2016, 11:41 AM

Mar 26 2016

skalinichev added a comment to D11797: [LIbClang] Report the named type for ElaboratedType.

Ok, If there are no objections, I'll commit this revision next week then.

Mar 26 2016, 4:54 AM
skalinichev added inline comments to D18462: Fix for clang_Cursor_getSpellingNameRange().
Mar 26 2016, 4:50 AM · Restricted Project

Mar 19 2016

skalinichev added a comment to D17180: Fix failing python bindings test.

It reminded me http://reviews.llvm.org/D17278

Mar 19 2016, 4:41 AM
skalinichev added a comment to D15469: Expose cxx constructor and method properties through libclang and python bindings..

I see. There were some changes recently in the indexing functionality. I'm not sure whether this change is intended or not, but since it's not your fault and we already have a lot of tests confirming that clang_CXXMethod_isDeleted is working as expected (e.g. c-index-test -test-print-type) I think it's ok to remove this part of the test then

Mar 19 2016, 4:32 AM
skalinichev updated the diff for D11797: [LIbClang] Report the named type for ElaboratedType.

Looking a bit more at the recent commits in libclang, it seems like all recently added functions follow this naming convention:
clang_Cursor_*
clang_Type_*
e.t.c.

Mar 19 2016, 3:56 AM

Mar 8 2016

skalinichev accepted D17226: libclang python bindings: Fix for bug 26394.

Yes, I've seen that python tests segfaulted too, never had time to investigate it though.

Mar 8 2016, 1:56 AM
skalinichev added a comment to D15469: Expose cxx constructor and method properties through libclang and python bindings..

Generally looks pretty good to me. Maybe it's worth to factor out duplicating code, but I guess it's not so important.

Mar 8 2016, 1:47 AM
skalinichev updated the diff for D11797: [LIbClang] Report the named type for ElaboratedType.

Ok, after some more testing I found out that elaborated types can have cv specifiers attached, but after using ET->getNamedType() we lose that information. So obviously the previous solution was wrong. Therefore I'm falling back to the original idea here once again: exposing the elaborated type. Also extending tests to account for the found bug.

Mar 8 2016, 1:31 AM

Jan 7 2016

skalinichev committed rL257043: [libclang] Handle AutoType in clang_getTypeDeclaration.
[libclang] Handle AutoType in clang_getTypeDeclaration
Jan 7 2016, 1:24 AM
skalinichev closed D13001: [libclang] Handle AutoType in clang_getTypeDeclaration by committing rL257043: [libclang] Handle AutoType in clang_getTypeDeclaration.
Jan 7 2016, 1:24 AM

Dec 13 2015

skalinichev added inline comments to D15469: Expose cxx constructor and method properties through libclang and python bindings..
Dec 13 2015, 4:29 AM
skalinichev closed D12666: [LibClang] Fix clang_getCursorAvailability.
Dec 13 2015, 4:05 AM
skalinichev added a comment to D14329: Show inclusions from a preamble in clang_getInclusions..

I've seen this bug too. Generally this patch looks good to me.

Dec 13 2015, 4:00 AM
skalinichev updated the diff for D13001: [libclang] Handle AutoType in clang_getTypeDeclaration.

Added tests

Dec 13 2015, 3:23 AM

Nov 15 2015

skalinichev committed rL253166: [libclang] Visit TypeAliasTemplateDecl.
[libclang] Visit TypeAliasTemplateDecl
Nov 15 2015, 5:51 AM
skalinichev closed D13844: [libclang] Visit TypeAliasTemplateDecl by committing rL253166: [libclang] Visit TypeAliasTemplateDecl.
Nov 15 2015, 5:51 AM
skalinichev committed rL253165: [libclang] Expose AutoType.
[libclang] Expose AutoType
Nov 15 2015, 5:12 AM
skalinichev closed D13000: [libclang] Expose AutoType by committing rL253165: [libclang] Expose AutoType.
Nov 15 2015, 5:12 AM
skalinichev committed rL253164: Remove some trailing whitespace.
Remove some trailing whitespace
Nov 15 2015, 4:39 AM

Nov 3 2015

skalinichev added a comment to D13844: [libclang] Visit TypeAliasTemplateDecl.

Yes, I have commit acces now (didn't test it yet though). I'll try to submit this patch soon.

Nov 3 2015, 11:20 PM
skalinichev added a comment to D13388: Add support for querying the visibility of a cursor.

Well, I think it's ok then. Still there is no test for visibility set from command line case.
Also adding comment to clang_getCursorVisibility explaining that it also works with visibility set from command line would be very useful.

Nov 3 2015, 11:16 PM

Oct 17 2015

skalinichev added reviewers for D13001: [libclang] Handle AutoType in clang_getTypeDeclaration: klimek, milianw.
Oct 17 2015, 2:14 AM
skalinichev added reviewers for D13000: [libclang] Expose AutoType: klimek, milianw.
Oct 17 2015, 2:12 AM
skalinichev retitled D13844: [libclang] Visit TypeAliasTemplateDecl from to [libclang] Visit TypeAliasTemplateDecl.
Oct 17 2015, 2:04 AM
skalinichev added a comment to D13388: Add support for querying the visibility of a cursor.

Isn't r246931 what you're looking for?

Oct 17 2015, 1:45 AM

Sep 20 2015

skalinichev retitled D13001: [libclang] Handle AutoType in clang_getTypeDeclaration from to [libclang] Handle AutoType in clang_getTypeDeclaration.
Sep 20 2015, 1:52 AM
skalinichev retitled D13000: [libclang] Expose AutoType from to [libclang] Expose AutoType.
Sep 20 2015, 1:42 AM

Sep 10 2015

skalinichev added a comment to D11797: [LIbClang] Report the named type for ElaboratedType.

AFAIUI the canonical type could never be an elaborated type, but just type could.

Sep 10 2015, 11:03 AM

Sep 9 2015

skalinichev updated the diff for D11797: [LIbClang] Report the named type for ElaboratedType.

Yes, I've noticed that inconsistency too. But, seems like, this is an unrelated issue: TemplateSpecializationType type for some reasons uses id instead of qid (See also all other tests with templates in print-type.cpp, e.g. FieldDecl=baz). To get the type with nested name specifiers for the TemplateSpecializationType c-index-test should use the clang_getCanonicalType. But it doesn't use it for pointers. (Compare c-index-test.c:1289 and c-index-test.c:1335)

Sep 9 2015, 10:56 AM

Sep 6 2015

skalinichev retitled D12666: [LibClang] Fix clang_getCursorAvailability from to [LibClang] Fix clang_getCursorAvailability.
Sep 6 2015, 5:17 AM

Sep 4 2015

skalinichev updated the diff for D11797: [LIbClang] Report the named type for ElaboratedType.

Yes, now it's ready.

Sep 4 2015, 2:11 AM

Sep 2 2015

skalinichev updated the diff for D11797: [LIbClang] Report the named type for ElaboratedType.

It just occured to me, why do we need to expose the ElaboratedType if we can retrieve the original type and return it to user. Especially when we already do that for Attributed and Decayed types. So here is a much simplier solution.

Sep 2 2015, 2:31 AM

Aug 31 2015

skalinichev added a comment to D11976: [libclang] Return deduced type for auto type, not the one written in the source..

Yes, please submit it.

Aug 31 2015, 2:20 AM

Aug 22 2015

skalinichev added a comment to D11976: [libclang] Return deduced type for auto type, not the one written in the source..

This is actually an unrelated issue (clang_getTypeDeclaration doesn't handle the auto type)

Aug 22 2015, 1:38 AM

Aug 18 2015

skalinichev updated D11976: [libclang] Return deduced type for auto type, not the one written in the source..
Aug 18 2015, 4:30 AM
skalinichev added a comment to D11797: [LIbClang] Report the named type for ElaboratedType.

Ping? Can someone commit it?

Aug 18 2015, 4:20 AM

Aug 12 2015

skalinichev retitled D11976: [libclang] Return deduced type for auto type, not the one written in the source. from to [libclang] Return deduced type for auto type, not the one written in the source..
Aug 12 2015, 4:09 AM

Aug 8 2015

skalinichev updated the diff for D11797: [LIbClang] Report the named type for ElaboratedType.

Address raised issues.

Aug 8 2015, 3:42 AM

Aug 7 2015

skalinichev updated the diff for D11797: [LIbClang] Report the named type for ElaboratedType.

Fixed minor formatting issues.

Aug 7 2015, 2:15 AM
skalinichev updated D11797: [LIbClang] Report the named type for ElaboratedType.
Aug 7 2015, 2:08 AM

Aug 6 2015

skalinichev retitled D11797: [LIbClang] Report the named type for ElaboratedType from to [libclang] Expose the ElaboratedType.
Aug 6 2015, 3:23 AM