Related to http://reviews.llvm.org/D15772
Adds support for third operand for [D]DIV[U] instructions. Additional test for case when destination reg is zero register.
Paths
| Differential D16888
[mips] Addition of a third operand to the instructions [d]div, [d]divu
ClosedPublic Authored by obucina on Feb 4 2016, 8:20 AM.
Details Summary Related to http://reviews.llvm.org/D15772 Adds support for third operand for [D]DIV[U] instructions. Additional test for case when destination reg is zero register.
Diff Detail Event Timelinedsanders edited edge metadata. Comment ActionsCould you make the summary more like a commit message? I don't see any code to handle things like 'ddiv $zero, $4, $5' but it's possible that the real instruction has priority over the macro because $zero is more specific. Could you add tests for 'ddiv $zero, $4, $5' and check that it only expands to a single 'ddiv $zero, $4, $5' instruction? Similarly for ddivu/dmod/dmodu This revision now requires changes to proceed.Feb 12 2016, 9:27 AM obucina updated this object. obucina edited edge metadata. Comment ActionsReview changes applied. Added additional test for case when destination register is zero register. Comment Actions Ping... We need review on this, since it is prerequisite for http://reviews.llvm.org/D16889 dsanders edited edge metadata. Comment ActionsWith the indentation and missing predicates fixed it will LGTM
This revision is now accepted and ready to land.Mar 15 2016, 9:17 AM obucina edited edge metadata. Comment ActionsWe fixed indentation and we added predicates to the MipsInstAlias's. Closed by commit rL269636: [mips] Addition of a third operand to the instructions [d]div, [d]divu (authored by zjovanovic). · Explain WhyMay 16 2016, 2:04 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 52042 lib/Target/Mips/AsmParser/MipsAsmParser.cpp
lib/Target/Mips/MipsInstrInfo.td
test/MC/Mips/macro-ddiv-bad.s
test/MC/Mips/macro-ddiv.s
test/MC/Mips/macro-ddivu-bad.s
test/MC/Mips/macro-ddivu.s
test/MC/Mips/macro-div-bad.s
test/MC/Mips/macro-div.s
test/MC/Mips/macro-divu-bad.s
test/MC/Mips/macro-divu.s
|
Indentation is off by one. There are similar cases below.