Page MenuHomePhabricator

obucina (Srdjan Obucina)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 10:38 AM (397 w, 3 d)

Recent Activity

Apr 18 2016

obucina updated the diff for D14390: [mips] Expansion of LI.S and LI.D.

Previous patch did not contain test cases. Added here.

Apr 18 2016, 5:19 AM

Apr 13 2016

obucina added inline comments to D14390: [mips] Expansion of LI.S and LI.D.
Apr 13 2016, 7:51 AM
obucina updated the diff for D14390: [mips] Expansion of LI.S and LI.D.

Expansion of LI.S and LI.D without introducing new floating-point operands.

Apr 13 2016, 7:50 AM

Apr 12 2016

obucina added a comment to D16675: [mips] Expansion of SC[D] for pre-r6.
Apr 12 2016, 5:25 AM
obucina updated the diff for D16675: [mips] Expansion of SC[D] for pre-r6.

Changes in accordance to last review (if replaced with ternary operator).

Apr 12 2016, 5:24 AM

Apr 6 2016

obucina added a comment to D16675: [mips] Expansion of SC[D] for pre-r6.

Vasilis, patch is rebased. Please be faster with reviewing so that outdating does not happens again.

Apr 6 2016, 9:35 AM
obucina updated the diff for D16675: [mips] Expansion of SC[D] for pre-r6.

Rebased.

Apr 6 2016, 9:34 AM

Mar 30 2016

obucina added inline comments to D16889: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu.
Mar 30 2016, 6:20 AM
obucina updated the diff for D16889: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu.

Adding 64bit constants to ddiv[u] test cases.

Mar 30 2016, 6:19 AM
obucina added a comment to D16888: [mips] Addition of a third operand to the instructions [d]div, [d]divu .
Mar 30 2016, 6:12 AM
obucina updated the diff for D16888: [mips] Addition of a third operand to the instructions [d]div, [d]divu .

We fixed indentation and we added predicates to the MipsInstAlias's.
This led to changes in the macro-div-bad.s, macro-divu-bad.s, macro-ddiv-bad.s and macro-ddivu-bad.s test cases.

Mar 30 2016, 6:11 AM

Mar 23 2016

obucina added inline comments to D16889: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu.
Mar 23 2016, 8:34 AM

Mar 22 2016

obucina added inline comments to D16807: [mips] MUL macro variations.
Mar 22 2016, 2:17 PM
obucina updated the diff for D16807: [mips] MUL macro variations.

According to feedback - using ternary operators.

Mar 22 2016, 2:15 PM
obucina updated the diff for D17040: [mips] Expansion of BEQL and BNEL with immediate operands.

According to feedback - split long line, redundant tests removed.

Mar 22 2016, 9:51 AM

Mar 15 2016

obucina added a comment to D17036: [mips] Addition of the [d]rem and [d]remu instructions.

Ping, dependant on D16888 and 16889

Mar 15 2016, 9:03 AM
obucina added inline comments to D16889: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu.
Mar 15 2016, 8:57 AM
obucina added a comment to D16889: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu.
Mar 15 2016, 8:19 AM
obucina updated the diff for D16889: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu.

Adding 64bit constants to test cases.
Macro definitions updated to simm32, imm64
Tests reorganized.

Mar 15 2016, 8:14 AM
obucina added a comment to D16888: [mips] Addition of a third operand to the instructions [d]div, [d]divu .

Ping... We need review on this, since it is prerequisite for http://reviews.llvm.org/D16889

Mar 15 2016, 8:08 AM

Mar 8 2016

obucina updated the diff for D17040: [mips] Expansion of BEQL and BNEL with immediate operands.

Aditional tests added.

Mar 8 2016, 10:57 AM

Mar 7 2016

obucina added a comment to D17040: [mips] Expansion of BEQL and BNEL with immediate operands.

Can You please be more precise what exactly You are expecting to be changed?

Mar 7 2016, 7:20 AM

Feb 26 2016

obucina updated the diff for D17036: [mips] Addition of the [d]rem and [d]remu instructions.

Patch reduced to contain only changes for adding REM macro.

Feb 26 2016, 4:49 AM
obucina updated the diff for D16889: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu.

Patch reduced to contain only changes for adding immediate operand for DIV macro.

Feb 26 2016, 4:46 AM
obucina updated the diff for D16888: [mips] Addition of a third operand to the instructions [d]div, [d]divu .
Feb 26 2016, 4:44 AM

Feb 25 2016

obucina added a comment to D17040: [mips] Expansion of BEQL and BNEL with immediate operands.

Ping

Feb 25 2016, 7:54 AM
obucina added a comment to D16925: [mips] Support LA expansion in PIC mode.

Ping

Feb 25 2016, 7:54 AM
obucina added a comment to D16807: [mips] MUL macro variations.

Ping

Feb 25 2016, 7:54 AM

Feb 24 2016

obucina updated the diff for D16888: [mips] Addition of a third operand to the instructions [d]div, [d]divu .

Review changes applied. Added additional test for case when destination register is zero register.

Feb 24 2016, 7:10 AM

Feb 11 2016

obucina abandoned D15772: [mips] Macros for [d]div[u],[d]rem[u].

This patch is split into three separate patches, and is now abandoned. Related patches:

Feb 11 2016, 7:29 AM
obucina updated the diff for D15745: [mips] added support for trunc macro.

Changes according to last feedback

Feb 11 2016, 7:23 AM

Feb 10 2016

obucina updated the diff for D16925: [mips] Support LA expansion in PIC mode.

We couldn't extend test/MC/Mips/macro-la.s because some tests in it failed in pic mode. For example, 'la $5, symbol+8' gives: 'LLVM ERROR: unsupported reloc value'. Also, istruction la in the case 'la $5, 1f' does not expand properly because symbol 1 is defined at the end of the test file, so condition 'Sym->isInSection()' fails because of one pass structure of assembler.

Feb 10 2016, 7:49 AM

Feb 9 2016

obucina retitled D17040: [mips] Expansion of BEQL and BNEL with immediate operands from to [mips] Expansion of BEQL and BNEL with immediate operands.
Feb 9 2016, 1:54 PM
obucina retitled D17036: [mips] Addition of the [d]rem and [d]remu instructions from to [mips] Addition of the [d]rem and [d]remu instructions.
Feb 9 2016, 11:41 AM
obucina updated the diff for D16807: [mips] MUL macro variations.

Added DMUL macro for non CnMips. Please, take a look at the predicates of DMULMacro, and confirm are they OK.

Feb 9 2016, 10:56 AM
obucina updated the diff for D16807: [mips] MUL macro variations.

Old file accidentally left in the patch - removed.

Feb 9 2016, 8:46 AM
obucina updated the diff for D16807: [mips] MUL macro variations.

Changes according to the comments

Feb 9 2016, 8:37 AM

Feb 5 2016

obucina retitled D16925: [mips] Support LA expansion in PIC mode from [mips] Support LA expandsion in PIC mode to [mips] Support LA expansion in PIC mode.
Feb 5 2016, 7:22 AM
obucina retitled D16925: [mips] Support LA expansion in PIC mode from to [mips] Support LA expandsion in PIC mode.
Feb 5 2016, 7:19 AM

Feb 4 2016

obucina retitled D16889: [mips] Addition of the immediate cases for the instructions [d]div, [d]divu from to [mips] Addition of the immediate cases for the instructions [d]div, [d]divu.
Feb 4 2016, 8:25 AM
obucina retitled D16888: [mips] Addition of a third operand to the instructions [d]div, [d]divu from to [mips] Addition of a third operand to the instructions [d]div, [d]divu .
Feb 4 2016, 8:20 AM

Feb 2 2016

obucina added a comment to D16807: [mips] MUL macro variations.

In original test example there is one more instruction

Feb 2 2016, 8:42 AM
obucina retitled D16807: [mips] MUL macro variations from to [mips] MUL macro variations.
Feb 2 2016, 8:28 AM

Jan 28 2016

obucina updated subscribers of D16675: [mips] Expansion of SC[D] for pre-r6.
Jan 28 2016, 1:19 AM
obucina retitled D16675: [mips] Expansion of SC[D] for pre-r6 from to [mips] Expansion of SC[D] for pre-r6.
Jan 28 2016, 1:18 AM
obucina retitled D16674: [mips] Expansion of SC[D] and LL[D] for R6 from to [mips] Expansion of SC[D] and LL[D] for R6.
Jan 28 2016, 1:17 AM

Jan 26 2016

obucina added a comment to D16323: [mips] Absolute value macro expansion.
Jan 26 2016, 8:54 AM
obucina updated the diff for D16323: [mips] Absolute value macro expansion.

New diff contains suggested changes

Jan 26 2016, 8:54 AM

Jan 22 2016

obucina abandoned D14874: [mips] added support for trunc macro.
Jan 22 2016, 8:52 AM
obucina commandeered D14874: [mips] added support for trunc macro.

I am continuing here http://reviews.llvm.org/D15745

Jan 22 2016, 8:52 AM

Jan 19 2016

obucina retitled D16323: [mips] Absolute value macro expansion from to [mips] Absolute value macro expansion.
Jan 19 2016, 9:39 AM

Dec 24 2015

obucina retitled D15772: [mips] Macros for [d]div[u],[d]rem[u] from to [mips] Macros for [d]div[u],[d]rem[u].
Dec 24 2015, 8:07 AM

Dec 23 2015

obucina added a comment to D14874: [mips] added support for trunc macro.

Continued here http://reviews.llvm.org/D15745

Dec 23 2015, 10:40 AM
obucina updated subscribers of D15745: [mips] added support for trunc macro.
Dec 23 2015, 6:32 AM
obucina retitled D15745: [mips] added support for trunc macro from to [mips] added support for trunc macro.
Dec 23 2015, 6:32 AM

Nov 17 2015

obucina updated the diff for D10611: [mips] Expansion of ROL and ROR macros.

New diff contains adaptations to the latest source code, using emit* functions for generating instructions.

Nov 17 2015, 7:36 AM

Nov 5 2015

obucina retitled D14390: [mips] Expansion of LI.S and LI.D from to [mips] Expansion of LI.S and LI.D.
Nov 5 2015, 1:02 PM

Nov 2 2015

obucina updated the diff for D10611: [mips] Expansion of ROL and ROR macros.

New diff contains nit corrections, usage of TmpReg as suggested, and necessary changes to be applicable to latest source code.

Nov 2 2015, 8:36 AM

Oct 19 2015

obucina added a comment to D10611: [mips] Expansion of ROL and ROR macros.
Oct 19 2015, 5:06 AM
obucina updated the diff for D10611: [mips] Expansion of ROL and ROR macros.

New diff contains nit fixes

Oct 19 2015, 5:02 AM

Sep 16 2015

obucina added a comment to D10539: [mips] Handling of immediates bigger than 16 bits.
Sep 16 2015, 6:10 AM

Sep 14 2015

obucina added a comment to D10537: [mips] Add support for branch-likely pseudo-instructions.
Sep 14 2015, 10:39 AM
obucina updated the diff for D10537: [mips] Add support for branch-likely pseudo-instructions.

Nit corrections

Sep 14 2015, 10:39 AM

Sep 11 2015

obucina added a comment to D10539: [mips] Handling of immediates bigger than 16 bits.
Sep 11 2015, 12:08 PM
obucina updated the diff for D10537: [mips] Add support for branch-likely pseudo-instructions.

New diff contains changes necessary to make patch applicable. Predicates are removed from few pseudo instructions in order to enable including PredicateControl into MipsAsmPseudoInst inheritance hierarchy. Some tests are disabled.

Sep 11 2015, 11:47 AM
obucina added a comment to D10537: [mips] Add support for branch-likely pseudo-instructions.

The same problem appeared with latest changes from http://reviews.llvm.org/D11675

Sep 11 2015, 7:47 AM

Sep 8 2015

obucina updated the diff for D10539: [mips] Handling of immediates bigger than 16 bits.

New diff contains nit fixes and changes needed to apply and properly build this fix.

Sep 8 2015, 2:09 PM
obucina updated the diff for D10539: [mips] Handling of immediates bigger than 16 bits.

New diff contains nit fixes and changes needed to apply and properly build this fix.

Sep 8 2015, 2:04 PM
obucina added a comment to D10537: [mips] Add support for branch-likely pseudo-instructions.

My bad, its:

Sep 8 2015, 7:50 AM
obucina added a comment to D10537: [mips] Add support for branch-likely pseudo-instructions.

The problem expands, because now another instruction prevents adding PredicateControl to MIspAsmPseudoInst.

Sep 8 2015, 6:37 AM

Sep 7 2015

obucina added a comment to D10537: [mips] Add support for branch-likely pseudo-instructions.

OK. I agree this is a good way to go. Then, the final corrections for this patch would be to remove AsmToken::Identifier case, remove ISA_MIPS1_NOT_32R6_64R6 from ULHU/ULW, and change tests appropriately.

Sep 7 2015, 7:22 AM
obucina added a comment to D10537: [mips] Add support for branch-likely pseudo-instructions.

Hi,

I believe you already have a conditional LGTM for this patch (for diff 28228) and that the quoted text above contains the only remaining issue. It was asking that you remove the AsmToken::Identifier code (because it introduces another way to parse labels which is already handled elsewhere) and fix the wrong-error issue it was intended to fix in a later patch that deals with other cases too.

Sep 7 2015, 6:28 AM

Sep 4 2015

obucina updated the diff for D10537: [mips] Add support for branch-likely pseudo-instructions.

New diff contain changes that are needed to apply patch to latest version of source code.

Sep 4 2015, 6:24 AM

Jul 8 2015

obucina updated the diff for D10611: [mips] Expansion of ROL and ROR macros.

Nit corrections + context

Jul 8 2015, 5:58 AM
obucina updated the diff for D10611: [mips] Expansion of ROL and ROR macros.

New diff contains expansions for ROL, ROR, DROL, DROR, for all cpus and test cases.

Jul 8 2015, 5:31 AM

Jul 2 2015

obucina updated the diff for D10539: [mips] Handling of immediates bigger than 16 bits.
Jul 2 2015, 9:08 AM
obucina updated the diff for D10539: [mips] Handling of immediates bigger than 16 bits.
Jul 2 2015, 9:02 AM
obucina added inline comments to D10539: [mips] Handling of immediates bigger than 16 bits.
Jul 2 2015, 8:44 AM

Jun 30 2015

obucina updated the diff for D10611: [mips] Expansion of ROL and ROR macros.

New diff contains ROL/ROR expansion for all 32rN and 64rN platforms, where these instructions are aliasses for ROTR and ROTRV.

Jun 30 2015, 8:25 AM

Jun 24 2015

obucina updated the diff for D10537: [mips] Add support for branch-likely pseudo-instructions.

PredicateControl moved from CondBranchPseudo to the MipsAsmPseudoInst

Jun 24 2015, 4:12 AM

Jun 23 2015

obucina abandoned D10511: Support for branch-likely pseudo-instructions.
Jun 23 2015, 10:36 AM
obucina added a comment to D10611: [mips] Expansion of ROL and ROR macros.

Daniel, my task was the expansion of these macros, by mips bugzilla report 723.

Jun 23 2015, 8:07 AM
obucina updated the diff for D10611: [mips] Expansion of ROL and ROR macros.

New diff contains formatting fixes and renamed variables where suggested.

Jun 23 2015, 7:33 AM
obucina updated D10537: [mips] Add support for branch-likely pseudo-instructions.
Jun 23 2015, 5:59 AM
obucina updated the diff for D10537: [mips] Add support for branch-likely pseudo-instructions.

New diff includes formatting fixes, test cases for error on using BL instructions on r6, and a fix for other test cases in test files test/MC/Mips/mips??r6/invalid.s, which were not executing.

Jun 23 2015, 5:55 AM

Jun 22 2015

obucina retitled D10611: [mips] Expansion of ROL and ROR macros from to Expansion of ROL and ROR instructions.
Jun 22 2015, 12:31 PM

Jun 19 2015

obucina updated the diff for D10537: [mips] Add support for branch-likely pseudo-instructions.

New diff contains fix for error reporting when branch likely instructions are used on mips32r6/mips64r6.

Jun 19 2015, 7:23 AM

Jun 18 2015

obucina retitled D10539: [mips] Handling of immediates bigger than 16 bits from to [mips] Handling of immediates bigger than 16 bits.
Jun 18 2015, 8:10 AM
obucina retitled D10537: [mips] Add support for branch-likely pseudo-instructions from Add support for branch-likely pseudo-instructions to [mips] Add support for branch-likely pseudo-instructions.
Jun 18 2015, 7:45 AM
obucina retitled D10537: [mips] Add support for branch-likely pseudo-instructions from to Add support for branch-likely pseudo-instructions.
Jun 18 2015, 7:22 AM

Jun 17 2015

obucina retitled D10511: Support for branch-likely pseudo-instructions from to Support for branch-likely pseudo-instructions.
Jun 17 2015, 11:14 AM