Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

zoran.jovanovic (Zoran Jovanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2014, 6:33 AM (507 w, 1 d)

Recent Activity

Oct 17 2019

zoran.jovanovic committed rG78c78cb5a12d: [mips] [builtins] Remove clear_mips_cache Differential Revision: https… (authored by zoran.jovanovic).
[mips] [builtins] Remove clear_mips_cache Differential Revision: https…
Oct 17 2019, 5:26 AM

Oct 16 2019

zoran.jovanovic added a comment to D69021: [mips] [builtins] Remove clear_mips_cache.

It is because of "defined(ANDROID) && defined(LP64)" part.

Oct 16 2019, 3:54 AM · Restricted Project, Restricted Project
zoran.jovanovic created D69021: [mips] [builtins] Remove clear_mips_cache.
Oct 16 2019, 12:47 AM · Restricted Project, Restricted Project

Jul 31 2017

zoran.jovanovic accepted D35765: [SelectionDAG][mips] Fix PR33883.

LGTM.

Jul 31 2017, 3:08 AM

Mar 13 2017

zoran.jovanovic accepted D27845: [SelectionDAG] Enable target specific vector scalarization of calls and returns.

LGTM with few nits.

Mar 13 2017, 12:52 PM

Jan 1 2017

zoran.jovanovic accepted D23652: [mips] N64 static relocation model support.

LGTM with a few nits.

Jan 1 2017, 4:52 PM

Dec 30 2016

zoran.jovanovic accepted D24510: [mips] Correct c.cond.fmt instruction definition..

LGTM with a nit.

Dec 30 2016, 8:35 AM

Dec 12 2016

zoran.jovanovic accepted D27209: [mips] Fix compact branch hazard detection.

LGTM with a nit.

Dec 12 2016, 6:57 AM

Nov 18 2016

zoran.jovanovic added a comment to D26398: [mips][msa] Implement f16 support.

LGTM.

Nov 18 2016, 6:21 AM

Nov 16 2016

zoran.jovanovic accepted D26398: [mips][msa] Implement f16 support.

LGTM otherwise.

Nov 16 2016, 7:34 AM
zoran.jovanovic added a reviewer for D26398: [mips][msa] Implement f16 support: zoran.jovanovic.
Nov 16 2016, 7:34 AM
zoran.jovanovic added inline comments to D26398: [mips][msa] Implement f16 support.
Nov 16 2016, 7:33 AM

Sep 20 2016

zoran.jovanovic accepted D23399: [mips][ias] fix li macro when values are negated with ~ .

LGTM.

Sep 20 2016, 6:04 AM

Sep 7 2016

zoran.jovanovic accepted D23118: [mips] Fix c.<cc>.<fmt> instruction definition..

LGTM.

Sep 7 2016, 7:33 AM

Aug 25 2016

zoran.jovanovic accepted D21473: [mips] Fix aui/daui/dahi/dati for MIPSR6.

LGTM.

Aug 25 2016, 6:55 AM

May 4 2016

zoran.jovanovic added a comment to D12199: Add framework for iterative compilation to llvm.

In order to use iterative compilation algorithm for target different then MIPS it is necessary to implement appropriate function fitness pass that evaluates generated code. In our patch criteria used is code size and pass is implemented in lib/Target/Mips/MipsFunctionFitness.cpp file.
In case of X86 code size calculation is more complex because of variable-length machine instruction encoding.
We are looking for possibilities to issue more informative error message until architecture is supported.

May 4 2016, 10:59 AM

Apr 25 2016

zoran.jovanovic updated the diff for D15417: [mips][microMIPS] Implement BEQZC and BNEZC instructions.

New patch version.
Patch rebased and formatting comments addressed.

Apr 25 2016, 6:58 AM

Apr 22 2016

zoran.jovanovic updated the diff for D12200: Add framework for iterative compilation to clang.

New patch version rebased to r256194.
Any comments to this work?

Apr 22 2016, 6:30 AM
zoran.jovanovic updated the diff for D12199: Add framework for iterative compilation to llvm.

New patch version rebased to r256194.
Any comments on this work?

Apr 22 2016, 6:27 AM

Apr 13 2016

zoran.jovanovic updated the diff for D18995: [mips] Fix emitAtomicCmpSwapPartword to handle 64 bit pointers correctly.

New patch version.
Generated code is correct (sd/ld are used to store/restore pointer value).
It passes -verify-machineinstrs for o32, n32 and n64.

Apr 13 2016, 7:13 AM
zoran.jovanovic updated the diff for D18995: [mips] Fix emitAtomicCmpSwapPartword to handle 64 bit pointers correctly.

New patch version that only changes type of AlignedAddr and uses appropriate AND instruction for calculating value of AlignedAddr (although correct output will be produced with any AND instruction because they all work on register size data - functionally there is no AND32 and AND64).

Apr 13 2016, 2:50 AM
zoran.jovanovic added a comment to D18995: [mips] Fix emitAtomicCmpSwapPartword to handle 64 bit pointers correctly.

As stated in description of the patch it is new revision of: http://reviews.llvm.org/D13649, which was created by Jelena Losic, and all following revisions were based on received comments.
This revision is based on latest set of comments received on http://reviews.llvm.org/D13649.
I do believe that it produces correct output.
Also, I do agree that particular issue can be fixed by only changing type of alignedaddr pseudo to i64 when pointers are 64 bit.
I will prepare new patch version that handles issue in that manner.

Apr 13 2016, 12:54 AM

Apr 11 2016

zoran.jovanovic retitled D18995: [mips] Fix emitAtomicCmpSwapPartword to handle 64 bit pointers correctly from to [mips] Fix emitAtomicCmpSwapPartword to handle 64 bit pointers correctly.
Apr 11 2016, 3:24 PM

Feb 4 2016

zoran.jovanovic added a comment to D12199: Add framework for iterative compilation to llvm.

Just to PING.
Any comments on this work?

Feb 4 2016, 2:42 AM
zoran.jovanovic added a comment to D5295: [mips][microMIPS] Implement ADDIUPC instruction.

Replaced by:
http://reviews.llvm.org/D6582

Feb 4 2016, 2:30 AM
zoran.jovanovic added a comment to D3789: [mips][microMIPS] Mark symbols as microMIPS if necessary.

Replaced by:
http://reviews.llvm.org/D6039

Feb 4 2016, 2:25 AM
zoran.jovanovic abandoned D3789: [mips][microMIPS] Mark symbols as microMIPS if necessary.

Replaced by:

Feb 4 2016, 2:23 AM

Dec 30 2015

zoran.jovanovic updated the diff for D12200: Add framework for iterative compilation to clang.

New patch version that corresponds to latest version of:
http://reviews.llvm.org/D12199

Dec 30 2015, 9:32 AM
zoran.jovanovic updated the diff for D12199: Add framework for iterative compilation to llvm.

This version introduces new algorithm for exploring decision trees.
As stated in the last patch, splitting one big decision tree into multiple ones for every function in compilation unit can improve results.
Furthermore, separate decision trees are needed for each optimization phase (interprocedural, precodegen and codegen).

Dec 30 2015, 9:27 AM

Dec 18 2015

zoran.jovanovic added inline comments to D15417: [mips][microMIPS] Implement BEQZC and BNEZC instructions.
Dec 18 2015, 2:00 AM

Dec 15 2015

zoran.jovanovic retitled D15026: [mips][microMIPS] Add R_MICROMIPS_PC18_S3 relocation from [mips][microMIPS] Add R_MICROMIPS_PC19_S3 relocation to [mips][microMIPS] Add R_MICROMIPS_PC18_S3 relocation.
Dec 15 2015, 7:22 AM
zoran.jovanovic retitled D15526: [mips][microMIPS] Add R_MICROMIPS_PC21_S1 relocation from to [mips][microMIPS] Add R_MICROMIPS_PC21_S1 relocation.
Dec 15 2015, 6:56 AM

Dec 10 2015

zoran.jovanovic retitled D15417: [mips][microMIPS] Implement BEQZC and BNEZC instructions from to [mips][microMIPS] Implement BEQZC and BNEZC instructions.
Dec 10 2015, 6:44 AM
zoran.jovanovic added inline comments to D14822: [mips][microMIPS] Add R_MICROMIPS_PC26_S1 relocation.
Dec 10 2015, 6:30 AM

Nov 26 2015

zoran.jovanovic retitled D15026: [mips][microMIPS] Add R_MICROMIPS_PC18_S3 relocation from to [mips][microMIPS] Add R_MICROMIPS_PC19_S3 relocation.
Nov 26 2015, 7:56 AM
zoran.jovanovic updated the diff for D15009: [mips][microMIPS] Implement ldpc instruction.

Usage of simm19_lsl2 replaced by simm18_lsl3.

Nov 26 2015, 6:07 AM
zoran.jovanovic retitled D15009: [mips][microMIPS] Implement ldpc instruction from to [mips][microMIPS] Implement ldpc instruction.
Nov 26 2015, 3:01 AM

Nov 23 2015

zoran.jovanovic retitled D14915: [mips][microMIPS] Add R_MICROMIPS_PC19_S2 relocation from to [mips][microMIPS] Add R_MICROMIPS_PC19_S2 relocation.
Nov 23 2015, 2:30 AM

Nov 19 2015

zoran.jovanovic retitled D14822: [mips][microMIPS] Add R_MICROMIPS_PC26_S1 relocation from to [mips][microMIPS] Add R_MICROMIPS_PC26_S1 relocation.
Nov 19 2015, 8:06 AM

Nov 18 2015

zoran.jovanovic retitled D14770: [mips][microMIPS] Fix issue with offset operand of BALC and BC instructions from to [mips][microMIPS] Fix issue with offset operand of BALC and BC instructions.
Nov 18 2015, 4:20 AM

Nov 12 2015

zoran.jovanovic updated the diff for D14206: [mips][microMIPS] Implement BGEC, BGEUC, BLTC, BLTUC, BEQC and BNEC instructions.

Rebased to work with top of the tree. There were issues with recently added RDHWR and RDPGPR instructions.

Nov 12 2015, 7:59 AM

Oct 30 2015

zoran.jovanovic retitled D14206: [mips][microMIPS] Implement BGEC, BGEUC, BLTC, BLTUC, BEQC and BNEC instructions from to [mips][microMIPS] Implement BGEC, BGEUC, BLTC, BLTUC, BEQC and BNEC instructions.
Oct 30 2015, 8:57 AM

Oct 13 2015

zoran.jovanovic updated D13649: [mips] Clang ll/sc illegal instruction on mips64r2 with -O0.
Oct 13 2015, 4:19 AM
zoran.jovanovic updated D13649: [mips] Clang ll/sc illegal instruction on mips64r2 with -O0.
Oct 13 2015, 4:05 AM

Sep 25 2015

zoran.jovanovic updated the diff for D12200: Add framework for iterative compilation to clang.

Updated to follow new revision of patch for iterative compilation in llvm:
http://reviews.llvm.org/D12199

Sep 25 2015, 8:43 AM
zoran.jovanovic updated the diff for D12199: Add framework for iterative compilation to llvm.

*Places for improvement*

Sep 25 2015, 8:39 AM

Sep 18 2015

zoran.jovanovic updated the diff for D12798: [mips][micromips] Initial support for micrmomips DSP instructions and addu.qb implementation.

Test files renamed and changed usage of predicates.

Sep 18 2015, 9:35 AM
zoran.jovanovic accepted D12959: [mips][microMIPS] Fix an invalid read for lwm32 and reserved reglist values..

LGTM.

Sep 18 2015, 7:05 AM

Sep 15 2015

zoran.jovanovic retitled D12881: [mips][microMIPS] Fix an issue with disassembling lwm32 instruction from to [mips][microMIPS] Fix an issue with disassembling lwm32 instruction.
Sep 15 2015, 8:01 AM

Sep 14 2015

zoran.jovanovic accepted D10537: [mips] Add support for branch-likely pseudo-instructions.

LGTM with a nit.

Sep 14 2015, 8:10 AM

Sep 11 2015

zoran.jovanovic retitled D12798: [mips][micromips] Initial support for micrmomips DSP instructions and addu.qb implementation from to [mips][micromips] Initial support for micrmomips DSP instructions and addu.qb implementation.
Sep 11 2015, 5:09 AM

Aug 25 2015

zoran.jovanovic accepted D12279: [mips][microMIPS] Implement ADDIUR1SP, ADDIUR2, ADDIUS5 and ADDIUSP instructions.

LGTM

Aug 25 2015, 1:40 AM

Aug 20 2015

zoran.jovanovic added a comment to D12199: Add framework for iterative compilation to llvm.

This patch needs to be applied along with the patch for clang.
See http://reviews.llvm.org/D12200 for more details.

Aug 20 2015, 10:59 AM
zoran.jovanovic added a comment to D12200: Add framework for iterative compilation to clang.

This patch needs to be applied along with the patch for llvm.
See http://reviews.llvm.org/D12199 for more details.

Aug 20 2015, 10:50 AM
zoran.jovanovic retitled D12200: Add framework for iterative compilation to clang from to Add framework for iterative compilation to clang.
Aug 20 2015, 10:45 AM
zoran.jovanovic added a comment to D12199: Add framework for iterative compilation to llvm.

This is a follow-up work on the iterative compilation framework for clang/llvm.
Initial discussion as well as the introduction to this approach has been presented at:

Aug 20 2015, 10:37 AM
zoran.jovanovic retitled D12199: Add framework for iterative compilation to llvm from to Add framework for iterative compilation to llvm.
Aug 20 2015, 10:35 AM

Aug 4 2015

zoran.jovanovic retitled D10640: [mips][microMIPS] Implement LWP and SWP instructions from [mips][microMIPS] Implement LWXS, LWP and SWP instructions to [mips][microMIPS] Implement LWP and SWP instructions.
Aug 4 2015, 2:16 AM

May 29 2015

zoran.jovanovic retitled D10119: [mips][microMIPS] Implement SB, SBE, SCE, SH and SHE instructions from to [mips][microMIPS] Implement SB, SBE, SCE, SH and SHE instructions.
May 29 2015, 4:18 AM

May 27 2015

zoran.jovanovic accepted D10031: [mips][microMIPSr6] Implement BEQZALC, BGEZALC, BGTZALC, BLEZALC, BLTZALC and BNEZALC instructions.

LGTM.

May 27 2015, 6:12 AM

May 18 2015

zoran.jovanovic accepted D8919: [mips][microMIPSr6] Implement LSA instruction.

LGTM with a nit.

May 18 2015, 7:55 AM

May 15 2015

zoran.jovanovic accepted D8782: [mips][microMIPSr6] Implement ALIGN and AUI instructions.

LGTM

May 15 2015, 7:04 AM

May 13 2015

zoran.jovanovic retitled D9739: [mips][microMIPSr6] Implement SEB and SEH instructions from to [mips][microMIPSr6] Implement SEB and SEH instructions.
May 13 2015, 5:29 AM
zoran.jovanovic added a comment to D8823: [mips][microMIPSr6] Implement LL and SC instructions.

There may be encoding changes for these instructions.

May 13 2015, 5:09 AM

May 12 2015

zoran.jovanovic accepted D8553: [mips][microMIPSr6] Implement CLO and CLZ instructions.

LGTM with a nit.

May 12 2015, 8:18 AM
zoran.jovanovic accepted D8497: [mips][microMIPSr6] Implement SELEQZ and SELNEZ instructions.

LGTM with a nit.

May 12 2015, 8:14 AM

May 8 2015

zoran.jovanovic accepted D8415: [mips][microMIPSr6] Implement ADDIUPC and LWPC instructions.

LGTM with a nit.

May 8 2015, 5:42 AM

May 7 2015

zoran.jovanovic accepted D8389: [mips][microMIPSr6] Implement JIALC and JIC instructions.

LGTM.

May 7 2015, 7:19 AM

May 5 2015

zoran.jovanovic added inline comments to D8389: [mips][microMIPSr6] Implement JIALC and JIC instructions.
May 5 2015, 2:21 AM

Apr 20 2015

zoran.jovanovic accepted D8387: [mips][microMIPSr6] Implement initial mapping support.

LGTM.

Apr 20 2015, 4:47 AM
zoran.jovanovic accepted D8386: [mips][microMIPSr6] Implement initial subtarget support.

LGTM.

Apr 20 2015, 4:44 AM

Apr 8 2015

zoran.jovanovic retitled D8894: Implement MUL, MUH, MULU and MUHU instructions from to Implement MUL, MUH, MULU and MUHU instructions.
Apr 8 2015, 6:49 AM

Apr 2 2015

zoran.jovanovic retitled D8800: [mips][microMIPSr6] Implement NOR, OR, ORI, XOR and XORI instructions from to [mips][microMIPSr6] Implement NOR, OR, ORI, XOR and XORI instructions.
Apr 2 2015, 6:06 AM

Apr 1 2015

zoran.jovanovic retitled D8772: [mips][microMIPSr6] Implement AND and ANDI instructions from to [mips][microMIPSr6] Implement AND and ANDI instructions.
Apr 1 2015, 8:01 AM
zoran.jovanovic retitled D8769: [mips][microMIPSr6] Implement DIV, DIVU, MOD and MODU instructions from to [mips][microMIPSr6] Implement DIV, DIVU, MOD and MODU instructions.
Apr 1 2015, 6:56 AM
zoran.jovanovic retitled D8764: [mips][microMIPSr6] Implement SUB and SUBU instructions from to [mips][microMIPSr6] Implement SUB and SUBU instructions.
Apr 1 2015, 3:35 AM

Mar 30 2015

zoran.jovanovic retitled D8704: [mips][microMIPSr6] Implement ADD, ADDU and ADDIU instructions from to [mips][microMIPSr6] Implement ADD, ADDU and ADDIU instructions.
Mar 30 2015, 7:56 AM

Mar 27 2015

zoran.jovanovic retitled D8661: [mips][microMIPSr6] Implement mips32 to microMIPSr6 mapping support from to [mips][microMIPSr6] Implement mips32 to microMIPSr6 mapping support .
Mar 27 2015, 6:25 AM

Mar 11 2015

zoran.jovanovic accepted D7748: [mips][microMIPS] Make usage of NOT16 by code generator.

LGTM

Mar 11 2015, 7:43 AM

Feb 27 2015

zoran.jovanovic retitled D7934: [mips][microMIPS] Change register class for GP register from to [mips][microMIPS] Change register class for GP register.
Feb 27 2015, 1:05 AM

Feb 23 2015

zoran.jovanovic updated the diff for D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.

Fixed issues. Rebased.

Feb 23 2015, 5:54 AM

Feb 19 2015

zoran.jovanovic accepted D7611: [mips][microMIPS] Make usage of AND16, OR16 and XOR16 by code generator.

LGTM

Feb 19 2015, 2:45 AM

Feb 18 2015

zoran.jovanovic accepted D7609: [mips][microMIPS] Make usage of ADDU16 and SUBU16 by code generator.

LGTM

Feb 18 2015, 8:43 AM

Feb 13 2015

zoran.jovanovic accepted D7522: [mips][microMIPS] Delay slot filler: Replace the microMIPS JR with the JRC.

LGTM.

Feb 13 2015, 8:39 AM

Feb 10 2015

zoran.jovanovic updated the diff for D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.

Fixed issue with non sequential register allocation order.

Feb 10 2015, 4:36 AM
zoran.jovanovic accepted D7443: [mips][microMIPS] Add disassembler tests for 16-bit instructions BREAK16 and SDBBP16.
Feb 10 2015, 3:14 AM
zoran.jovanovic accepted D7436: [mips][microMIPS] Fix disassembling of 16-bit microMIPS instructions LWM16 and SWM16.
Feb 10 2015, 3:13 AM
zoran.jovanovic added a comment to D7436: [mips][microMIPS] Fix disassembling of 16-bit microMIPS instructions LWM16 and SWM16.

LGTM

Feb 10 2015, 2:49 AM
zoran.jovanovic added a comment to D7443: [mips][microMIPS] Add disassembler tests for 16-bit instructions BREAK16 and SDBBP16.

LGTM

Feb 10 2015, 2:45 AM

Feb 9 2015

zoran.jovanovic updated the diff for D7465: [mips][microMIPS] Implement movep instruction.

Disassembler test cases added.

Feb 9 2015, 4:20 AM

Feb 6 2015

zoran.jovanovic retitled D7465: [mips][microMIPS] Implement movep instruction from to [mips][microMIPS] Implement movep instruction.
Feb 6 2015, 5:48 AM

Feb 2 2015

zoran.jovanovic updated the diff for D6581: [mips][microMIPS] Implement CodeGen support for SW16 and LW16 instructions.

Fixed issue with lw16 and reg+offset addresses.

Feb 2 2015, 8:11 AM

Jan 29 2015

zoran.jovanovic updated the diff for D6229: [mips][microMIPS] Use swm32/lwm32 instructions in function prologue/epilogue.

Fixed issues with test cases.

Jan 29 2015, 1:17 AM

Jan 26 2015

zoran.jovanovic updated the diff for D5820: [mips][microMIPS] Implement SWM and LWM aliases.

Modified and rebased patch.

Jan 26 2015, 4:36 AM

Jan 23 2015

zoran.jovanovic retitled D7148: Change representation of member function pointers for MIPS targets from to Change representation of member function pointers for MIPS targets.
Jan 23 2015, 7:46 AM

Dec 31 2014

zoran.jovanovic updated the diff for D6815: [mips][microMIPS] Fix issue with 16b instructions in jr instruction delay slot.

There is the same issue with PseudoReturn.

Dec 31 2014, 7:46 AM
zoran.jovanovic retitled D6815: [mips][microMIPS] Fix issue with 16b instructions in jr instruction delay slot from to [mips][microMIPS] Fix issue with 16b instructions in jr instruction delay slot.
Dec 31 2014, 1:36 AM

Dec 30 2014

zoran.jovanovic updated the diff for D6796: [mips][microMIPS] Relocate with symbol for micromips function symbols.

Test case modified according to review.

Dec 30 2014, 6:35 AM
zoran.jovanovic updated the diff for D6796: [mips][microMIPS] Relocate with symbol for micromips function symbols.

Labels also relocated with the symbol.

Dec 30 2014, 2:11 AM

Dec 29 2014

zoran.jovanovic retitled D6796: [mips][microMIPS] Relocate with symbol for micromips function symbols from to [mips][microMIPS] Relocate with symbol for micromips function symbols.
Dec 29 2014, 7:44 AM