Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[CodeLayout] Add unittest for cache-directed sort
Needs ReviewPublic

Authored by MaskRay on Sun, Sep 17, 4:09 PM.

Details

Summary

The function reordering algorithm added by https://reviews.llvm.org/D152834 and
used by BOLT (https://reviews.llvm.org/D153039) is untested.

Add some tests at the appropriate layer.

Depends on D159526

Diff Detail

Event Timeline

MaskRay created this revision.Sun, Sep 17, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Sep 17, 4:09 PM
Herald added a subscriber: pengfei. · View Herald Transcript
MaskRay requested review of this revision.Sun, Sep 17, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Sep 17, 4:09 PM

Another example would be where the algorithm stops merging functions (with call edges) because the temporal locality degrades too much, but this can be done in a separate patch.

llvm/unittests/Transforms/Utils/CodeLayoutTest.cpp
14

I might be missing something. Isn't this supposed to be the same size as Counts?