Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D159527

[CodeLayout] Add unittest for cache-directed sort
Needs ReviewPublic
Actions

Authored by MaskRay on Sun, Sep 17, 4:09 PM.

Details

Reviewers
spupyrev
wenlei
hoy
wlei
rahmanl
Summary

The function reordering algorithm added by https://reviews.llvm.org/D152834 and
used by BOLT (https://reviews.llvm.org/D153039) is untested.

Add some tests at the appropriate layer.

Depends on D159526

Diff Detail

Event Timeline

MaskRay created this revision.Sun, Sep 17, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Sep 17, 4:09 PM
Herald added a subscriber: pengfei. · View Herald Transcript
MaskRay requested review of this revision.Sun, Sep 17, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Sep 17, 4:09 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B257324: Diff 556918.Sun, Sep 17, 4:20 PM
MaskRay updated this revision to Diff 556921.Sun, Sep 17, 4:39 PM
MaskRay edited the summary of this revision. (Show Details)
MaskRay added a parent revision: D159526: [CodeLayout] Refactor std::vector uses, namespace, and EdgeCountT. NFC.

rebase

MaskRay mentioned this in D152840: [ELF] A new code layout algorithm for function reordering [3a/3].Sun, Sep 17, 4:48 PM
Harbormaster completed remote builds in B257327: Diff 556921.Sun, Sep 17, 5:10 PM
MaskRay updated this revision to Diff 556974.Mon, Sep 18, 2:26 PM

rebase

Harbormaster completed remote builds in B257359: Diff 556974.Mon, Sep 18, 4:11 PM
rahmanl added a comment.Thu, Sep 21, 1:33 PM

Another example would be where the algorithm stops merging functions (with call edges) because the temporal locality degrades too much, but this can be done in a separate patch.

llvm/unittests/Transforms/Utils/CodeLayoutTest.cpp
14

I might be missing something. Isn't this supposed to be the same size as Counts?

Revision Contents
Changeset List

PathSize
llvm/
test/
CodeGen/
X86/
1 line
unittests/
Transforms/
Utils/
1 line
63 lines

Diff 556974

View Options

llvm/test/CodeGen/X86/code_placement_ext_tsp.ll

Loading...
View Options

llvm/unittests/Transforms/Utils/CMakeLists.txt

Loading...
View Options

llvm/unittests/Transforms/Utils/CodeLayoutTest.cpp

Loading...