Page MenuHomePhabricator

rahmanl (Rahman Lavaee)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2019, 2:02 PM (152 w, 6 d)

Recent Activity

Tue, Jun 28

rahmanl committed rG0aa6df65756d: [Propeller] Encode address offsets of basic blocks relative to the end of the… (authored by rahmanl).
[Propeller] Encode address offsets of basic blocks relative to the end of the…
Tue, Jun 28, 7:43 AM · Restricted Project, Restricted Project
rahmanl closed D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Tue, Jun 28, 7:43 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Final nits.
Tue, Jun 28, 7:41 AM · Restricted Project, Restricted Project

Mon, Jun 27

rahmanl added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Mon, Jun 27, 7:47 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Add a llvm-readobj unit test with unsupported versions.
Mon, Jun 27, 7:46 PM · Restricted Project, Restricted Project

Fri, Jun 24

rahmanl added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Fri, Jun 24, 10:40 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Cleanups.
Fri, Jun 24, 10:40 AM · Restricted Project, Restricted Project

Thu, Jun 23

rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Cleanups.
Thu, Jun 23, 2:21 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Cleanups.
Thu, Jun 23, 2:16 PM · Restricted Project, Restricted Project
rahmanl added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Thu, Jun 23, 2:12 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Cleanups.
Thu, Jun 23, 2:11 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Cleanups.
Thu, Jun 23, 2:04 PM · Restricted Project, Restricted Project

Tue, Jun 21

rahmanl added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Thanks for the review @jhenderson

Tue, Jun 21, 11:01 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Use the same checks for SHT_LLVM_BB_ADDR_MAP (with version=0) and SHT_LLVM_BB_ADDR_MAP_V0.
Tue, Jun 21, 11:00 AM · Restricted Project, Restricted Project

Sun, Jun 19

rahmanl added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Sun, Jun 19, 12:04 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Address comments
Sun, Jun 19, 12:04 AM · Restricted Project, Restricted Project

Thu, Jun 16

rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • clang-format.
Thu, Jun 16, 2:30 PM · Restricted Project, Restricted Project
rahmanl added inline comments to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Thu, Jun 16, 2:10 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
  • Fix tests.
Thu, Jun 16, 2:09 PM · Restricted Project, Restricted Project
rahmanl updated the summary of D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Thu, Jun 16, 11:22 AM · Restricted Project, Restricted Project
rahmanl updated the summary of D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..
Thu, Jun 16, 1:24 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Encode the version number as a field of each function's LLVM_BB_ADDR_MAP entry instead of section names.

Thu, Jun 16, 12:32 AM · Restricted Project, Restricted Project

Tue, Jun 14

rahmanl added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Thanks for the explanation. If we use -function-sections it also means that we'll generate a unique LLVM_BB_ADDR_MAP per function. In this case, I believe the version data will be repeated for every function. Correct? I think we can live with that for now. It's only one or two bytes per function.

Yes, that's what I'd expect. (It's worth noting that -function-sections imposes other overheads like the ELF section header, so a couple of bytes is comparatively small).

Tue, Jun 14, 2:18 AM · Restricted Project, Restricted Project
rahmanl added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

IIUC, your suggestion is to embed the version in the section data. The problem with this approach is that the linker must read and deduplicate the version data when linking the sections (unless if we store the version for each function separately).
Also, if we compile with different compiler versions, the linker must create multiple LLVM_BB_ADDR_MAP sections if multiple versions exist.
For these reasons I am a bit hesitant to add linker dependency to the feature, even though section-name-independence is great to have. I'd be happy to change course if we can avoid involving the linker. Any thoughts?

One thing to consider is how DWARF debug sections are designed. Most DWARF sections have a format that is something akin to the following:

header consisting of:
  unit length - 32 or 64-bit number indicating the size of this input section
  version - uint16_t for the section's version
  other metadata as appropriate for the section type
actual section payload

The linker concatenates these together into a single output section. Consumers iterate over a section by inspecting the first header, using that to parse the immediate next payload and then, if the unit length doesn't mean the end of section has been reached, parses the next header and so on. In your case, you could have a single "header" (which might just consist of a length and version), followed by many functions that conform to that header. Consumers would just have to know how to iterate over them and then, if there are multiple versions, handle the corresponding payload accordingly. The linker would just concatenate together.

Tue, Jun 14, 1:02 AM · Restricted Project, Restricted Project

Fri, Jun 10

rahmanl added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Has the spec for this been finalised anywhere? My main conceren is the use of section names to have semantic importance. ELF generally tries to avoid this, hence the use of section types, and it would be a shame to introduce this approach when there are other options. It would be far more preferable to include the version number in the section data somewhere, a bit like how most DWARF sections are encoded. I can think of one other possible way of doing this: change the section type value for version 1 and upwards, and rename the original value to something like SHT_LLVM_BB_ADDR_MAP_V0. Add the version field as the first N bytes (2 or 4 probably) of the new section type. Parsers understanding the old data structure only won't recognise the new section type as a recognised format. This is good because it doesn't mislead people by printing incorrect offsets (in addition to not needing to rely on the section name).

Fri, Jun 10, 2:37 PM · Restricted Project, Restricted Project

May 26 2022

rahmanl updated the summary of D126518: Reland "[Propeller] Promote functions with propeller profiles to .text.hot.".
May 26 2022, 7:54 PM · Restricted Project, Restricted Project
rahmanl committed rG08cc05851872: Reland "[Propeller] Promote functions with propeller profiles to .text.hot." (authored by rahmanl).
Reland "[Propeller] Promote functions with propeller profiles to .text.hot."
May 26 2022, 7:54 PM · Restricted Project, Restricted Project
rahmanl closed D126518: Reland "[Propeller] Promote functions with propeller profiles to .text.hot.".
May 26 2022, 7:53 PM · Restricted Project, Restricted Project
rahmanl updated subscribers of D126518: Reland "[Propeller] Promote functions with propeller profiles to .text.hot.".
May 26 2022, 7:52 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D126518: Reland "[Propeller] Promote functions with propeller profiles to .text.hot.".

nit.

May 26 2022, 7:50 PM · Restricted Project, Restricted Project
rahmanl requested review of D126518: Reland "[Propeller] Promote functions with propeller profiles to .text.hot.".
May 26 2022, 7:46 PM · Restricted Project, Restricted Project
rahmanl abandoned D126517: [Propeller] Promote functions with propeller profiles to .text.hot..
May 26 2022, 7:18 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
May 26 2022, 7:16 PM · Restricted Project, Restricted Project
rahmanl requested review of D126517: [Propeller] Promote functions with propeller profiles to .text.hot..
May 26 2022, 7:09 PM · Restricted Project, Restricted Project
rahmanl committed rG3aa249329f38: Revert "[Propeller] Promote functions with propeller profiles to .text.hot." (authored by rahmanl).
Revert "[Propeller] Promote functions with propeller profiles to .text.hot."
May 26 2022, 6:46 PM · Restricted Project, Restricted Project
rahmanl added a reverting change for rG4d8d2580c53e: [Propeller] Promote functions with propeller profiles to .text.hot.: rG3aa249329f38: Revert "[Propeller] Promote functions with propeller profiles to .text.hot.".
May 26 2022, 6:46 PM · Restricted Project, Restricted Project
rahmanl added a reverting change for D122930: [Propeller] Promote functions with propeller profiles to .text.hot.: rG3aa249329f38: Revert "[Propeller] Promote functions with propeller profiles to .text.hot.".
May 26 2022, 6:46 PM · Restricted Project, Restricted Project
rahmanl committed rG4d8d2580c53e: [Propeller] Promote functions with propeller profiles to .text.hot. (authored by rahmanl).
[Propeller] Promote functions with propeller profiles to .text.hot.
May 26 2022, 4:24 PM · Restricted Project, Restricted Project
rahmanl closed D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
May 26 2022, 4:23 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D122930: [Propeller] Promote functions with propeller profiles to .text.hot..

Added missing pipeline tests.

May 26 2022, 1:10 PM · Restricted Project, Restricted Project

May 24 2022

rahmanl updated the diff for D122930: [Propeller] Promote functions with propeller profiles to .text.hot..

Expand flag description.

May 24 2022, 11:24 AM · Restricted Project, Restricted Project

May 16 2022

rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Rebase again.

May 16 2022, 2:40 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Rebase.

May 16 2022, 12:50 PM · Restricted Project, Restricted Project
rahmanl added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Would you mind taking a look @jhenderson?

May 16 2022, 12:30 PM · Restricted Project, Restricted Project
rahmanl added inline comments to D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
May 16 2022, 12:09 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
  • Move Reader pass to CodeGen.
May 16 2022, 12:02 PM · Restricted Project, Restricted Project
rahmanl committed rG5f7ef6524537: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based… (authored by rahmanl).
[llvm-objdump] Let --symbolize-operands symbolize basic block addresses based…
May 16 2022, 10:12 AM · Restricted Project, Restricted Project
rahmanl closed D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
May 16 2022, 10:11 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

Fix llvm-objdump.rst.

May 16 2022, 9:53 AM · Restricted Project, Restricted Project

May 13 2022

rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

minor changes.

May 13 2022, 2:26 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

Merged the two tests into one.

May 13 2022, 2:23 PM · Restricted Project, Restricted Project
rahmanl updated the summary of D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
May 13 2022, 1:34 PM · Restricted Project, Restricted Project
rahmanl added a comment to D122930: [Propeller] Promote functions with propeller profiles to .text.hot..

This looks good to me. One question, do we have a rough idea, what is the percentage of functions that pgo and propeller disagree about their hotness?

Yes. For one example we have
31% of Propeller functions in .text.hot,
57% in .text
11% in .text.unlikely

Thanks.

One questions is whether the promotion should be hidden behind a flag or not.

My thought is that this is a prerequisite for propeller inter-proc layout optimization, so if inter-proc layout optimization is on by default when -fbasic-block-sections=list=<...> is present, then this could also be on by default. On the other hand if we guard inter-proc layout optimization with a flag, then that flag could also cover this.

May 13 2022, 1:33 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
  • Hide the feature behind the flag --bbsections-guided-section-prefix.
May 13 2022, 1:28 PM · Restricted Project, Restricted Project
rahmanl retitled D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section. from [llvm-objdump] Let `--symbolize-operands` symbolize basic block addresses based on the `SHT_LLVM_BB_ADDR_MAP` section. to [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
May 13 2022, 11:06 AM · Restricted Project, Restricted Project
rahmanl retitled D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section. from [llvm-objdump] Symbolize branch targets and basic block addresses based on the bb-address-map when present in the object file. to [llvm-objdump] Let `--symbolize-operands` symbolize basic block addresses based on the `SHT_LLVM_BB_ADDR_MAP` section..
May 13 2022, 11:05 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

Addressed comments.

May 13 2022, 11:05 AM · Restricted Project, Restricted Project

May 12 2022

rahmanl added reviewers for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section.: skan, int3.
May 12 2022, 11:31 AM · Restricted Project, Restricted Project
rahmanl added a reviewer for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section.: morehouse.
May 12 2022, 10:53 AM · Restricted Project, Restricted Project

May 10 2022

rahmanl added a reviewer for D122930: [Propeller] Promote functions with propeller profiles to .text.hot.: shenhan.
May 10 2022, 4:13 PM · Restricted Project, Restricted Project

May 9 2022

rahmanl added a comment to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

@MaskRay Is this patch good in terms of disassembly?

May 9 2022, 10:19 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
  • Last nit. Thanks for the review James.
May 9 2022, 10:18 AM · Restricted Project, Restricted Project

May 6 2022

rahmanl added inline comments to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
May 6 2022, 10:53 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
  • nits.
May 6 2022, 10:52 AM · Restricted Project, Restricted Project

May 5 2022

rahmanl removed a reviewer for D101341: Initialize optional members of ELFYAML types.: rahmanl.
May 5 2022, 2:40 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
  • Nicer BBAddrMap initialization in the unit test.
May 5 2022, 2:38 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
  • Update llvm-objdump.rst.
May 5 2022, 2:34 PM · Restricted Project, Restricted Project
rahmanl added inline comments to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
May 5 2022, 2:23 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
  • Added more cases in the unit test.
May 5 2022, 2:22 PM · Restricted Project, Restricted Project
rahmanl added a comment to D122930: [Propeller] Promote functions with propeller profiles to .text.hot..

This looks good to me. One question, do we have a rough idea, what is the percentage of functions that pgo and propeller disagree about their hotness?

May 5 2022, 11:47 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D122930: [Propeller] Promote functions with propeller profiles to .text.hot..

Add null checking.

May 5 2022, 11:46 AM · Restricted Project, Restricted Project
rahmanl committed rG733dc3e50b2d: [BOLT] Report per-section hotness in bolt-heatmap. (authored by rahmanl).
[BOLT] Report per-section hotness in bolt-heatmap.
May 5 2022, 11:38 AM · Restricted Project
rahmanl closed D124412: [BOLT] Report per-section hotness in bolt-heatmap..
May 5 2022, 11:38 AM · Restricted Project, Restricted Project

May 4 2022

rahmanl added inline comments to D124412: [BOLT] Report per-section hotness in bolt-heatmap..
May 4 2022, 11:55 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D124412: [BOLT] Report per-section hotness in bolt-heatmap..

Add entry for unmapped regions.

May 4 2022, 11:52 AM · Restricted Project, Restricted Project

May 3 2022

rahmanl added inline comments to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
May 3 2022, 4:07 PM · Restricted Project, Restricted Project
rahmanl updated the summary of D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
May 3 2022, 3:25 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
  • Handled the multi-section case.
  • Added unit tests for the ELFObjectFile::readBBAddrMap API.
May 3 2022, 3:23 PM · Restricted Project, Restricted Project

Apr 28 2022

rahmanl added a comment to D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..

Thanks for the reviews. Just realized this isn't working when multiple BB-address-map sections are present. Will fix soon.

Apr 28 2022, 3:40 PM · Restricted Project, Restricted Project
rahmanl added a comment to D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

I think that Extensions.rst should be updated as well, including a description of the versioning scheme, the fact that the section name is now a semantically significant property, and a description of both the v0 and v1 formats.

Apr 28 2022, 2:16 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Add unit-tests for checking invalid bb-address-map version suffixes.

Apr 28 2022, 2:14 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Remove empty lines.

Apr 28 2022, 11:56 AM · Restricted Project, Restricted Project
rahmanl updated the diff for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks..

Update Extensions.rst.

Apr 28 2022, 11:54 AM · Restricted Project, Restricted Project

Apr 27 2022

rahmanl updated the summary of D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
Apr 27 2022, 3:15 PM · Restricted Project, Restricted Project
rahmanl published D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section. for review.
Apr 27 2022, 3:08 PM · Restricted Project, Restricted Project

Apr 26 2022

rahmanl updated the diff for D122930: [Propeller] Promote functions with propeller profiles to .text.hot..

Remove unnecessary includes.

Apr 26 2022, 12:25 PM · Restricted Project, Restricted Project
rahmanl updated the summary of D122930: [Propeller] Promote functions with propeller profiles to .text.hot..
Apr 26 2022, 12:22 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D122930: [Propeller] Promote functions with propeller profiles to .text.hot..

Cleanup.

Apr 26 2022, 12:21 PM · Restricted Project, Restricted Project

Apr 25 2022

rahmanl updated the diff for D124412: [BOLT] Report per-section hotness in bolt-heatmap..

Cleanup.

Apr 25 2022, 4:04 PM · Restricted Project, Restricted Project
rahmanl updated the diff for D124412: [BOLT] Report per-section hotness in bolt-heatmap..

Refactoring.

Apr 25 2022, 4:02 PM · Restricted Project, Restricted Project
rahmanl published D124412: [BOLT] Report per-section hotness in bolt-heatmap. for review.
Apr 25 2022, 3:59 PM · Restricted Project, Restricted Project
rahmanl committed rGe59e580116b0: [BOLT] Refactor DataAggregator::printLBRHeatMap. (authored by rahmanl).
[BOLT] Refactor DataAggregator::printLBRHeatMap.
Apr 25 2022, 11:40 AM · Restricted Project
rahmanl closed D124281: [BOLT] Refactor DataAggregator::printLBRHeatMap..
Apr 25 2022, 11:40 AM · Restricted Project, Restricted Project
rahmanl published D122930: [Propeller] Promote functions with propeller profiles to .text.hot. for review.
Apr 25 2022, 10:41 AM · Restricted Project, Restricted Project

Apr 22 2022

rahmanl published D124281: [BOLT] Refactor DataAggregator::printLBRHeatMap. for review.
Apr 22 2022, 10:54 AM · Restricted Project, Restricted Project

Apr 11 2022

rahmanl edited reviewers for D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks., added: tmsriram; removed: shenhan, jhenderson.
Apr 11 2022, 4:00 PM · Restricted Project, Restricted Project
rahmanl committed rG0c13d97e2b50: Allow building heatmaps from basic sampled events with `-nl`. (authored by rahmanl).
Allow building heatmaps from basic sampled events with `-nl`.
Apr 11 2022, 3:05 PM · Restricted Project
rahmanl closed D123067: Allow building heatmaps from basic sampled events with `-nl`..
Apr 11 2022, 3:05 PM · Restricted Project, Restricted Project

Apr 5 2022

rahmanl updated the diff for D123067: Allow building heatmaps from basic sampled events with `-nl`..

change "simple events" to "basic events".

Apr 5 2022, 2:27 PM · Restricted Project, Restricted Project
rahmanl added a comment to D123067: Allow building heatmaps from basic sampled events with `-nl`..

Fixed the error.

Apr 5 2022, 2:23 PM · Restricted Project, Restricted Project