Page MenuHomePhabricator

rahmanl (Rahman Lavaee)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 30 2019, 2:02 PM (70 w, 1 d)

Recent Activity

Tue, Dec 1

rahmanl committed rGe0bf2349303f: Let .llvm_bb_addr_map section use the same unique id as its associated .text… (authored by rahmanl).
Let .llvm_bb_addr_map section use the same unique id as its associated .text…
Tue, Dec 1, 9:30 AM
rahmanl closed D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section..
Tue, Dec 1, 9:30 AM · Restricted Project
rahmanl updated the diff for D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section..

rebase.

Tue, Dec 1, 9:21 AM · Restricted Project

Mon, Nov 30

rahmanl added a comment to D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section..

Thank you for the comments @MaskRay . Are there any style guidelines for the test files? I wasn't able to find anything online.

Mon, Nov 30, 11:36 AM · Restricted Project
rahmanl updated the diff for D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section..
  • Add {{$}} to the checks.
Mon, Nov 30, 11:33 AM · Restricted Project
rahmanl updated the diff for D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section..
  • Add {{$}} to the checks.
Mon, Nov 30, 11:28 AM · Restricted Project

Wed, Nov 25

rahmanl published D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section. for review.
Wed, Nov 25, 10:23 AM · Restricted Project

Mon, Nov 9

rahmanl added inline comments to D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
Mon, Nov 9, 10:00 AM · Restricted Project

Fri, Nov 6

rahmanl committed rG82e7c4ce4547: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section. (authored by rahmanl).
[obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section.
Fri, Nov 6, 12:46 PM
rahmanl closed D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
Fri, Nov 6, 12:46 PM · Restricted Project
rahmanl added a comment to D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..

Thank you @grimar and @jhenderson for the thorough feedback. I will start on llvm-readobj support once I submit this patch.

Fri, Nov 6, 12:42 PM · Restricted Project
rahmanl updated the diff for D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
  • Typos/Style fix.
Fri, Nov 6, 12:38 PM · Restricted Project

Tue, Nov 3

rahmanl added inline comments to D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
Tue, Nov 3, 1:02 PM · Restricted Project
rahmanl added inline comments to D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
Tue, Nov 3, 1:00 PM · Restricted Project
rahmanl updated the diff for D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
  • Refine tests.
Tue, Nov 3, 1:00 PM · Restricted Project

Nov 2 2020

rahmanl accepted D83655: [AsmPrinter] Split up .gcc_except_table.

@rahmanl: @dblaikie and @jrtc27 prefer having a suffix to be consistent with .text.foo and .rodata.foo . On a second thought I think this indeed makes more sense. People who want to save .strtab space can use -fno-unique-section-names. Are you fine with the resolution?

Nov 2 2020, 2:31 PM · Restricted Project
rahmanl added inline comments to D83655: [AsmPrinter] Split up .gcc_except_table.
Nov 2 2020, 9:50 AM · Restricted Project

Nov 1 2020

rahmanl added inline comments to D83655: [AsmPrinter] Split up .gcc_except_table.
Nov 1 2020, 11:18 AM · Restricted Project

Oct 31 2020

rahmanl added a comment to D83655: [AsmPrinter] Split up .gcc_except_table.

I wonder if it'd be nicer to push this logic into getLSDASection by passing an (optional?) Function given that's where the normal LSDASection gets created? Having the check for ELF here seems to indicate that the logic isn't quite in the right place and belongs in the MCOFI subclass.

I agree with @jrtc27 here. How about we implement this like MCObjectFileInfo::getStackSizeSection(const MCSection&) or MCObjectFileInfo::getBBAddrMapSection(const MCSection&). The intended logic seems quite similar.

It would be inconvenient.

  1. getStackSizeSection and getBBAddrMapSection do not use different section names. They will need to know the suffix
  2. MCObjectFileInfo does not know whether function sections is enabled

MCObjectFileInfo is a good place for getStackSizeSection and getBBAddrMapSection because they need just information from MCObjectFileInfo. However, it is different for .gcc_except_table

Oct 31 2020, 12:41 AM · Restricted Project

Oct 30 2020

rahmanl added a comment to D83655: [AsmPrinter] Split up .gcc_except_table.

I wonder if it'd be nicer to push this logic into getLSDASection by passing an (optional?) Function given that's where the normal LSDASection gets created? Having the check for ELF here seems to indicate that the logic isn't quite in the right place and belongs in the MCOFI subclass.

Oct 30 2020, 10:13 PM · Restricted Project
rahmanl added a comment to D83655: [AsmPrinter] Split up .gcc_except_table.

+1,
Maybe worth mentioning in the description that the issue with -fbasic-block-sections is the revocations associated with @LPStart (Relocations are needed both in PIC and non-PIC mode). The no-basic-block-sections case is not affected since LPStart is omitted.

Oct 30 2020, 5:12 PM · Restricted Project

Oct 26 2020

rahmanl committed rG0b2f4cdf2bd4: Explicitly check for entry basic block, rather than relying on… (authored by rahmanl).
Explicitly check for entry basic block, rather than relying on…
Oct 26 2020, 4:16 PM
rahmanl closed D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
Oct 26 2020, 4:16 PM · Restricted Project
rahmanl added inline comments to D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
Oct 26 2020, 4:14 PM · Restricted Project
rahmanl updated the diff for D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
  • Remove function comment for AsmPrinter::shouldEmitLabelForBasicBlock.
Oct 26 2020, 4:12 PM · Restricted Project
rahmanl updated the diff for D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
  • Remove excessive empty line.
Oct 26 2020, 3:55 PM · Restricted Project
rahmanl added a comment to D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..

Thanks for your helpful comments @grimar.

Oct 26 2020, 3:53 PM · Restricted Project
rahmanl updated the diff for D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
  • Remove NumBlocks from the YAML key.
  • Add yaml2obj test.
Oct 26 2020, 3:51 PM · Restricted Project

Oct 19 2020

rahmanl added a comment to D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..

Thanks again for the comments @tmsriram

Oct 19 2020, 2:57 PM · Restricted Project
rahmanl updated the diff for D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
  • Better comments.
Oct 19 2020, 2:54 PM · Restricted Project

Oct 15 2020

rahmanl added inline comments to D89500: Fix the error message with -fbasic-block-sections=list=<filename>.
Oct 15 2020, 9:17 PM · Restricted Project
rahmanl added inline comments to D89500: Fix the error message with -fbasic-block-sections=list=<filename>.
Oct 15 2020, 5:48 PM · Restricted Project
rahmanl added a comment to D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..

Thank you for your helpful comments @tmsriram and @snehasish

Oct 15 2020, 2:24 PM · Restricted Project
rahmanl updated the diff for D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
  • Add a private member function shouldEmitLabelForBasicBlock and call it to decide if basic blocks require symbols.
Oct 15 2020, 2:12 PM · Restricted Project

Oct 14 2020

rahmanl added a comment to D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..

Thanks for the comments @tmsriram.

Oct 14 2020, 10:11 PM · Restricted Project
rahmanl updated the diff for D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
  • Remove redundant CHECK check-prefix.
Oct 14 2020, 10:10 PM · Restricted Project
rahmanl updated the diff for D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
  • Fix the condition for emitting basic block label.
Oct 14 2020, 10:05 PM · Restricted Project
rahmanl updated subscribers of D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
Oct 14 2020, 3:11 PM · Restricted Project
rahmanl retitled D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section. from Add yaml support for llvm_bb_addr_map section. to [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section..
Oct 14 2020, 3:10 PM · Restricted Project
rahmanl published D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section. for review.
Oct 14 2020, 3:07 PM · Restricted Project
rahmanl updated the summary of D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
Oct 14 2020, 1:28 PM · Restricted Project
rahmanl requested review of D89423: Explicitly check for entry basic block, rather than relying on MachineBasicBlock::pred_empty..
Oct 14 2020, 1:28 PM · Restricted Project

Oct 8 2020

rahmanl committed rG2b0c5d76a604: Introduce and use a new section type for the bb_addr_map section. (authored by rahmanl).
Introduce and use a new section type for the bb_addr_map section.
Oct 8 2020, 11:14 AM
rahmanl closed D88199: Introduce and use a new section type for the bb_addr_map section..
Oct 8 2020, 11:13 AM · Restricted Project
rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

Thanks everyone for the review. I'll go ahead and commit this and start working on D88717.

Oct 8 2020, 11:11 AM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..
  • Remove extra '#'s from Extensions.rst.
Oct 8 2020, 11:08 AM · Restricted Project

Oct 7 2020

rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..
  • Format Extensions.rst.
Oct 7 2020, 6:00 PM · Restricted Project
rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

Thanks @grimar.
I added the entry in the Extensions doc. I am not sure if my formatting is correct. I appreciate if you could please take a look.

Oct 7 2020, 5:58 PM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..
  • Add entry in docs/Extensions.rst.
  • Address @grimar's comments.
Oct 7 2020, 5:55 PM · Restricted Project
rahmanl committed rG34cd06a9b3bd: [BasicBlockSections] Make sure that the labels for address-taken blocks are… (authored by rahmanl).
[BasicBlockSections] Make sure that the labels for address-taken blocks are…
Oct 7 2020, 1:23 PM
rahmanl closed D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton..
Oct 7 2020, 1:22 PM · Restricted Project
rahmanl added inline comments to D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton..
Oct 7 2020, 1:19 PM · Restricted Project
rahmanl updated the diff for D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton..
  • Rename test, and fix indentation.
Oct 7 2020, 1:18 PM · Restricted Project

Oct 6 2020

rahmanl added a comment to D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton..

ping.

Oct 6 2020, 9:56 AM · Restricted Project

Oct 5 2020

rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

I noticed that there are other LLVM sections which use __llvm_* as a prefix for their section name, instead of .llvm_* or .llvm.* (see e.g. __llvm_prf_cnts). What do you think about using that style for the name? It's not necessary, and it looks like we have a bit of inconsistency going on here, but it's something worth considering.

I am not sure it will be a good idea. The start/stop symbols of __llvm_prf_cnts is __start___llvm_prf_cnts and __stop___llvm_prf_cnts. The 3 _ look strange.

Right. We won't be using the __start and __stop symbols.

If the optimization eventually will be ported to Mach-O: strlen("__llvm_prf_cnts") <= 16 so the section name can be encoded in Mach-O. __llvm_bb_addr_map is not.

Good point. Actually this shows the importance of using the section type as opposed to the section name. If necessary, we can always change the section name since we make sure we never rely on the actual name.

Oct 5 2020, 11:43 PM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..

Revert back to using ".llvm_bb_addr_map" for the section name.

Oct 5 2020, 11:38 PM · Restricted Project
rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

@MaskRay Do you think this is fine now?

Oct 5 2020, 11:47 AM · Restricted Project

Oct 1 2020

rahmanl added a comment to D73739: Exception support for basic block sections.

Glad to see this landing! I'm testing locally with my change to enable this purely for landing blocks.

Me too. Thanks.

As is, MachineFunctionSplitter can utilize this without basic-block-sections which means the "nop" handling doesn't get invoked and the runtime fails to find the landing pads. This would certainly be a separate change and I'd be happy to drive that.

That is expected. Thanks for signing up.

Oct 1 2020, 10:39 PM · Restricted Project
rahmanl removed reviewers for D88199: Introduce and use a new section type for the bb_addr_map section.: espindola, andreadb, alexshap, jdoerfert, mravishankar, antiagainst, nicolasvasilache, herhut, rriddle, aartbik, ftynse, silvas, JDevlieghere, Restricted Project, Restricted Project.
Oct 1 2020, 1:44 PM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..

Diff reupload.

Oct 1 2020, 1:40 PM · Restricted Project
rahmanl updated the summary of D88199: Introduce and use a new section type for the bb_addr_map section..
Oct 1 2020, 1:39 PM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..
  • Rename section to __llvm_bb_addr_map.
Oct 1 2020, 1:39 PM · Restricted Project

Sep 30 2020

rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

I noticed that there are other LLVM sections which use __llvm_* as a prefix for their section name, instead of .llvm_* or .llvm.* (see e.g. __llvm_prf_cnts). What do you think about using that style for the name? It's not necessary, and it looks like we have a bit of inconsistency going on here, but it's something worth considering.

Sep 30 2020, 2:01 PM · Restricted Project
rahmanl published D88517: [BasicBlockSections] Make sure that the labels for address-taken blocks are emitted after switching the seciton. for review.
Sep 30 2020, 11:51 AM · Restricted Project
rahmanl committed rG8955950c121c: Exception support for basic block sections (authored by rahmanl).
Exception support for basic block sections
Sep 30 2020, 11:06 AM
rahmanl closed D73739: Exception support for basic block sections.
Sep 30 2020, 11:06 AM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.
  • Use 'action_table_base' instead of 'cst_end' with more than one call-site range.
  • Rebase.
Sep 30 2020, 12:34 AM · Restricted Project

Sep 29 2020

rahmanl updated the summary of D73739: Exception support for basic block sections.
Sep 29 2020, 12:03 PM · Restricted Project
rahmanl added a comment to D73739: Exception support for basic block sections.

Let's take gcc_except_table_bb_sections.ll as the example:

Call site sizes are incorrect

.uleb128 .Lcst_end0-.Lcst_begin0  # Call Site Size

.uleb128 .Lcst_end0-.Lcst_begin1  # Call Site Size

.uleb128 .Lcst_end0-.Lcst_begin2  # Call Site Size

I think the Call Site Sizes are incorrect. A pair of .Lcst_end0 and .Lcst_begin0 should exactly delimiter the call sites table, but the current implements uses .Lcst_end0 for all 3 basic block sections and places .Lcst_end0 after the last Call Site Table.

Sep 29 2020, 11:14 AM · Restricted Project

Sep 28 2020

rahmanl removed a reviewer for D73739: Exception support for basic block sections: skan.
Sep 28 2020, 4:27 PM · Restricted Project
rahmanl added a comment to D73739: Exception support for basic block sections.

There is a compilation error:

llvm/lib/Target/ARM/ARMAsmPrinter.cpp:906:13: error: use of undeclared identifier 'getCurExceptionSym'
    MCSym = getCurExceptionSym();
Sep 28 2020, 4:26 PM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.
  • Fix ARM AsmPrinter code.
  • Use DenseMap for MBBSectionExceptionSyms.
Sep 28 2020, 4:24 PM · Restricted Project
rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

Mostly looks okay. I think there is no testing for the assembly parser being able to parse the new section type?

I'm also keen to hear what others think (e.g. @MaskRay).

This patch lets the bb_addr_map (renamed to llvm_bb_addr_map) section use a special section type (SHT_LLVM_BB_ADDR_MAP) instead of SHT_PROGBITS. This would help linker and other tools to use the sh_type ELF field to identify this section rather than relying on string comparison on the section name.

This description implies that some special processing is needed in the linker. (As you can see, when llvm_call_graph_profile and llvm_dependent_libraries were proposed, they had clear patches on the linker side.)

Maybe pivot the statement to say "dumpers and other tools"? Dumpers will need to know the section type for simpler processing of the code, even if the linker has no special handling currently.

xray_instr_map and xray_fn_idx are also an LLVM specific section types but they do not get their own section types. They use a dedicated dumper (llvm-xray), instead of llvm-readobj.

If the eventual behavior is to let LLD interpret .bb_addr_map differently (like .deplibs and .llvm_sympart*) differently (not "Rules for Linking Unrecognized Sections" on http://www.sco.com/developers/gabi/latest/ch4.sheader.html), having a dedicated section type seems fine. Though, I'd really like to know whether auto-defined __start_bb_addr_map and __stop_bb_addr_map are needed. If yes, the section name should not start with a period. And I'd like to know how the section is differently interpreted. xray_instr_map and xray_fn_idx only use generic ELF features.

Sep 28 2020, 1:46 PM · Restricted Project
rahmanl updated the summary of D88199: Introduce and use a new section type for the bb_addr_map section..
Sep 28 2020, 12:01 PM · Restricted Project
rahmanl added inline comments to D73739: Exception support for basic block sections.
Sep 28 2020, 11:44 AM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.
  • Rebase.
  • Add test comment about LSDA and personality encodings.
  • Make avoidZeroOffsetLandingPad static.
Sep 28 2020, 11:43 AM · Restricted Project
rahmanl added a reviewer for D88199: Introduce and use a new section type for the bb_addr_map section.: MaskRay.
Sep 28 2020, 11:14 AM · Restricted Project
rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

Thanks @MaskRay and @jhenderson.
Changed the description and the test according to your comments.

Sep 28 2020, 11:13 AM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..
  • Rename test to llvm_section_types.
Sep 28 2020, 11:13 AM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..
  • Remove non-llvm section types from the test.
  • Rebase.
Sep 28 2020, 11:08 AM · Restricted Project
rahmanl updated the summary of D88199: Introduce and use a new section type for the bb_addr_map section..
Sep 28 2020, 11:00 AM · Restricted Project

Sep 25 2020

rahmanl added a comment to D88199: Introduce and use a new section type for the bb_addr_map section..

Thanks @jhenderson, turned out I did need a one-line change for asmparser to work.

Sep 25 2020, 11:21 AM · Restricted Project
rahmanl updated the diff for D88199: Introduce and use a new section type for the bb_addr_map section..
  • Add new test for MCParser.
  • Clang-format.
Sep 25 2020, 11:19 AM · Restricted Project

Sep 24 2020

rahmanl updated the diff for D73739: Exception support for basic block sections.
  • clang-format.
Sep 24 2020, 2:59 PM · Restricted Project
rahmanl added a comment to D73739: Exception support for basic block sections.

Thanks for the comments @MaskRay

Sep 24 2020, 2:42 PM · Restricted Project
rahmanl updated the diff for D73739: Exception support for basic block sections.
  • Rebase.
  • Unify access to exception symbols for basic-block-sections and no basic-block-sections.
  • other nits.
Sep 24 2020, 2:40 PM · Restricted Project
rahmanl updated the summary of D88199: Introduce and use a new section type for the bb_addr_map section..
Sep 24 2020, 12:45 AM · Restricted Project
rahmanl published D88199: Introduce and use a new section type for the bb_addr_map section. for review.
Sep 24 2020, 12:44 AM · Restricted Project

Sep 22 2020

rahmanl accepted D87999: [EHStreamer] Ensure CallSiteEntry::{BeginLabel,EndLabel} are non-null. NFC.
Sep 22 2020, 1:31 PM · Restricted Project

Sep 21 2020

rahmanl added a comment to D87999: [EHStreamer] Ensure CallSiteEntry::{BeginLabel,EndLabel} are non-null. NFC.

LGTM.
Please just keep in mind that call-site-table is not rigorously tested in LLVM.

Sep 21 2020, 11:08 AM · Restricted Project
rahmanl added inline comments to D87999: [EHStreamer] Ensure CallSiteEntry::{BeginLabel,EndLabel} are non-null. NFC.
Sep 21 2020, 9:32 AM · Restricted Project

Sep 18 2020

rahmanl edited reviewers for D73739: Exception support for basic block sections, added: MaskRay; removed: wenlei.
Sep 18 2020, 12:55 PM · Restricted Project
rahmanl accepted D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager.
Sep 18 2020, 12:24 PM · Restricted Project

Sep 16 2020

rahmanl added a comment to D73739: Exception support for basic block sections.

@rahmanl Have you had a chance to run your added test on ARM64 as another itanium C++ ABI target to make sure it works properly? Having testing there is fine as a follow-up but wanted to make sure we're in agreement here. Otherwise changes LGTM, please let @MaskRay have a chance to provide any additional feedback.

Sep 16 2020, 11:25 PM · Restricted Project
rahmanl committed rGb1cb9d627126: [obj2yaml] - Match ".stack_size" with the original section name, and not the… (authored by rahmanl).
[obj2yaml] - Match ".stack_size" with the original section name, and not the…
Sep 16 2020, 2:25 PM
rahmanl closed D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Sep 16 2020, 2:24 PM · Restricted Project
rahmanl added a comment to D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

@MaskRay ping.

Sep 16 2020, 1:09 PM · Restricted Project
rahmanl added a comment to D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

Sorry about the headache @MaskRay I should've built after rebasing.

Sep 16 2020, 12:14 PM · Restricted Project
rahmanl abandoned D87784: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
Sep 16 2020, 12:12 PM · Restricted Project
rahmanl updated the diff for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..
  • Change the getSectionName call to pass pointer.
Sep 16 2020, 12:11 PM · Restricted Project