Page MenuHomePhabricator

spupyrev (Sergey Pupyrev)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 29 2021, 3:03 PM (72 w, 1 d)

Recent Activity

Jul 15 2022

spupyrev updated the diff for D129895: [BOLT] Unifying implementations of ext-tsp.

fixing build!

Jul 15 2022, 3:01 PM · Restricted Project, Restricted Project
spupyrev updated the diff for D129895: [BOLT] Unifying implementations of ext-tsp.

fixing build?

Jul 15 2022, 1:58 PM · Restricted Project, Restricted Project
spupyrev updated the diff for D129895: [BOLT] Unifying implementations of ext-tsp.

getting rid of unneeded logs

Jul 15 2022, 12:55 PM · Restricted Project, Restricted Project
spupyrev retitled D129895: [BOLT] Unifying implementations of ext-tsp from unifying implementations of ext-tsp to [BOLT] Unifying implementations of ext-tsp.
Jul 15 2022, 12:44 PM · Restricted Project, Restricted Project
spupyrev updated the summary of D129893: extending code layout alg.
Jul 15 2022, 12:41 PM · Restricted Project, Restricted Project
spupyrev updated the summary of D129895: [BOLT] Unifying implementations of ext-tsp.
Jul 15 2022, 12:30 PM · Restricted Project, Restricted Project
spupyrev requested review of D129895: [BOLT] Unifying implementations of ext-tsp.
Jul 15 2022, 12:27 PM · Restricted Project, Restricted Project
spupyrev requested review of D129893: extending code layout alg.
Jul 15 2022, 12:23 PM · Restricted Project, Restricted Project

Jul 11 2022

spupyrev added a comment to rG76029cc53e83: Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from section….

Hello, this patch is important for golang support and was submitted without a review :( We need to decide how to fix the problem (if any, since I didn't see one) and fix it, but not revert the patch..

Jul 11 2022, 10:01 AM · Restricted Project
spupyrev committed rG228970f612c9: Revert "Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from… (authored by spupyrev).
Revert "Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from…
Jul 11 2022, 9:52 AM · Restricted Project
spupyrev added a reverting change for rG76029cc53e83: Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from section…: rG228970f612c9: Revert "Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from….
Jul 11 2022, 9:52 AM · Restricted Project
spupyrev added a reverting change for rG6d0528636ae5: Rebase: [Facebook] [MC] Introduce NeverAlign fragment type: rGeecd41aa0935: Revert "Rebase: [Facebook] [MC] Introduce NeverAlign fragment type".
Jul 11 2022, 9:52 AM · Restricted Project, Restricted Project
spupyrev committed rGeecd41aa0935: Revert "Rebase: [Facebook] [MC] Introduce NeverAlign fragment type" (authored by spupyrev).
Revert "Rebase: [Facebook] [MC] Introduce NeverAlign fragment type"
Jul 11 2022, 9:52 AM · Restricted Project, Restricted Project
spupyrev added a reverting change for rGf921985a29fc: Rebase: [Facebook] Add clang driver options to test debug info and BOLT: rGb444358126aa: Revert "Rebase: [Facebook] Add clang driver options to test debug info and BOLT".
Jul 11 2022, 9:52 AM · Restricted Project, Restricted Project, Restricted Project
spupyrev committed rGb444358126aa: Revert "Rebase: [Facebook] Add clang driver options to test debug info and BOLT" (authored by spupyrev).
Revert "Rebase: [Facebook] Add clang driver options to test debug info and BOLT"
Jul 11 2022, 9:52 AM · Restricted Project, Restricted Project, Restricted Project
spupyrev committed rG722837105474: [BOLT] Do not merge cold and hot chains of basic blocks (authored by spupyrev).
[BOLT] Do not merge cold and hot chains of basic blocks
Jul 11 2022, 9:33 AM · Restricted Project
spupyrev committed rG6d0528636ae5: Rebase: [Facebook] [MC] Introduce NeverAlign fragment type (authored by rafauler).
Rebase: [Facebook] [MC] Introduce NeverAlign fragment type
Jul 11 2022, 9:33 AM · Restricted Project, Restricted Project
spupyrev added a reverting change for rG729d29e167a5: [BOLT] Update dynamic relocations from section relocations: rG76029cc53e83: Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from section….
Jul 11 2022, 9:33 AM
spupyrev committed rG76029cc53e83: Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from section… (authored by maksfb).
Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from section…
Jul 11 2022, 9:33 AM · Restricted Project
spupyrev committed rGf921985a29fc: Rebase: [Facebook] Add clang driver options to test debug info and BOLT (authored by Amir).
Rebase: [Facebook] Add clang driver options to test debug info and BOLT
Jul 11 2022, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
spupyrev closed D129397: [BOLT] Do not merge cold and hot chains of basic blocks.
Jul 11 2022, 9:33 AM · Restricted Project, Restricted Project
spupyrev added a reverting change for D117612: [BOLT] Update dynamic relocations from section relocations: rG76029cc53e83: Rebase: [Facebook] Revert "[BOLT] Update dynamic relocations from section….
Jul 11 2022, 9:33 AM · Restricted Project
spupyrev updated the diff for D129397: [BOLT] Do not merge cold and hot chains of basic blocks.

rebase

Jul 11 2022, 6:55 AM · Restricted Project, Restricted Project

Jul 8 2022

spupyrev retitled D129397: [BOLT] Do not merge cold and hot chains of basic blocks from Do not merge cold with hot chains to [BOLT] Do not merge cold and hot chains of basic blocks.
Jul 8 2022, 1:46 PM · Restricted Project, Restricted Project
spupyrev requested review of D129397: [BOLT] Do not merge cold and hot chains of basic blocks.
Jul 8 2022, 1:34 PM · Restricted Project, Restricted Project

Jun 3 2022

spupyrev committed rG5904836b8a71: [BOLT] Cache-Aware Tail Duplication (authored by spupyrev).
[BOLT] Cache-Aware Tail Duplication
Jun 3 2022, 9:11 AM · Restricted Project
spupyrev closed D123050: [BOLT] Cache-Aware Tail Duplication.
Jun 3 2022, 9:11 AM · Restricted Project, Restricted Project
spupyrev updated the diff for D123050: [BOLT] Cache-Aware Tail Duplication.

updated comments per review

Jun 3 2022, 8:34 AM · Restricted Project, Restricted Project

Jun 2 2022

spupyrev accepted D124490: [InstrProf] Minimal Block Coverage.

We reviewed the code internally prior sending upstream, and it is still looks good to me.

Jun 2 2022, 4:48 PM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

spupyrev added inline comments to D123050: [BOLT] Cache-Aware Tail Duplication.
May 31 2022, 3:27 PM · Restricted Project, Restricted Project

Apr 27 2022

spupyrev updated the diff for D123050: [BOLT] Cache-Aware Tail Duplication.

rebase + a small adjustment of the default optimization flags

Apr 27 2022, 12:03 PM · Restricted Project, Restricted Project

Apr 15 2022

spupyrev added a comment to D123050: [BOLT] Cache-Aware Tail Duplication.

There was a *very* brief discussion about system models on llvm-dev. Did you consider using something similar in bolt resp. llvm?
https://lists.llvm.org/pipermail/llvm-dev/2018-October/127319.html

Apr 15 2022, 12:54 PM · Restricted Project, Restricted Project

Apr 4 2022

spupyrev updated the summary of D123050: [BOLT] Cache-Aware Tail Duplication.
Apr 4 2022, 10:40 AM · Restricted Project, Restricted Project
spupyrev requested review of D123050: [BOLT] Cache-Aware Tail Duplication.
Apr 4 2022, 10:28 AM · Restricted Project, Restricted Project

Mar 22 2022

spupyrev committed rG4609f60ebc57: [BOLT] Avoid pointless loop rotation (authored by spupyrev).
[BOLT] Avoid pointless loop rotation
Mar 22 2022, 12:43 PM · Restricted Project
spupyrev closed D121921: [BOLT] Avoid pointless loop rotation.
Mar 22 2022, 12:42 PM · Restricted Project, Restricted Project
spupyrev updated the diff for D121921: [BOLT] Avoid pointless loop rotation.

rebase

Mar 22 2022, 12:30 PM · Restricted Project, Restricted Project

Mar 21 2022

spupyrev updated the diff for D121921: [BOLT] Avoid pointless loop rotation.

reformat

Mar 21 2022, 8:24 AM · Restricted Project, Restricted Project
spupyrev added a comment to D121921: [BOLT] Avoid pointless loop rotation.

@spupyrev I don't see strict rules about the else/eslse if statement indeed. This is clearly personal preference, I hust don't like the idea of extra nesting where you can go without it. As for my personal experience LLVM tries to eliminate extra nesting where it is possible. But speaking of the new variant - I think you need to add braces for "else if " statement, since in coding style https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements there are some words about the if/else statement to be uniform e.g.

// Use braces for the `if` block to keep it uniform with the else block.
if (isa<FunctionDecl>(D)) {
  handleFunctionDecl(D);
} else {
  // In this else case, it is necessary that we explain the situation with this
  // surprisingly long comment, so it would be unclear without the braces whether
  // the following statement is in the scope of the `if`.
  handleOtherDecl(D);
}
Mar 21 2022, 8:20 AM · Restricted Project, Restricted Project
spupyrev updated the diff for D121921: [BOLT] Avoid pointless loop rotation.

@yota9 please let me know if I got your suggestion right.
Also would be great to understand the motivation for the suggested change; I actually
like the earlier version more, as it shows the two conditions symmetrically (but that
might be just a personal preference)

Mar 21 2022, 7:46 AM · Restricted Project, Restricted Project
spupyrev retitled D121921: [BOLT] Avoid pointless loop rotation from [LoopInversionPass] Avoid pointless loop rotation to [BOLT] Avoid pointless loop rotation.
Mar 21 2022, 7:38 AM · Restricted Project, Restricted Project

Mar 17 2022

spupyrev added inline comments to D121921: [BOLT] Avoid pointless loop rotation.
Mar 17 2022, 11:22 AM · Restricted Project, Restricted Project
spupyrev updated the diff for D121921: [BOLT] Avoid pointless loop rotation.

adding a test

Mar 17 2022, 11:06 AM · Restricted Project, Restricted Project
spupyrev updated the summary of D121921: [BOLT] Avoid pointless loop rotation.
Mar 17 2022, 9:56 AM · Restricted Project, Restricted Project
spupyrev requested review of D121921: [BOLT] Avoid pointless loop rotation.
Mar 17 2022, 9:53 AM · Restricted Project, Restricted Project

Mar 9 2022

spupyrev accepted D121293: Fix linking error, undefined class static constants..
Mar 9 2022, 7:41 AM · Restricted Project, Restricted Project

Mar 8 2022

spupyrev committed rG81aedab7dd2a: introducing some profi flags (authored by spupyrev).
introducing some profi flags
Mar 8 2022, 12:35 PM · Restricted Project
spupyrev closed D120508: introducing profi flags.
Mar 8 2022, 12:35 PM · Restricted Project, Restricted Project
spupyrev added inline comments to D120508: introducing profi flags.
Mar 8 2022, 12:16 PM · Restricted Project, Restricted Project
spupyrev updated the diff for D120508: introducing profi flags.

added back the option for overwriting entry count (ON by default)

Mar 8 2022, 7:26 AM · Restricted Project, Restricted Project

Mar 4 2022

spupyrev retitled D120508: introducing profi flags from introducing some profi flags to introducing profi flags.
Mar 4 2022, 10:27 AM · Restricted Project, Restricted Project
spupyrev updated the diff for D120508: introducing profi flags.

modifying island connectors + removed one (controversial) option

Mar 4 2022, 10:24 AM · Restricted Project, Restricted Project

Mar 2 2022

spupyrev committed rGf2ade65fb2a6: [CSSPGO] Even flow distribution (authored by spupyrev).
[CSSPGO] Even flow distribution
Mar 2 2022, 1:12 PM · Restricted Project
spupyrev closed D118640: [CSSPGO] Even count distribution.
Mar 2 2022, 1:12 PM · Restricted Project, Restricted Project
spupyrev updated the diff for D118640: [CSSPGO] Even count distribution.

update broken test

Mar 2 2022, 11:32 AM · Restricted Project, Restricted Project
spupyrev updated the diff for D118640: [CSSPGO] Even count distribution.

rebase

Mar 2 2022, 7:37 AM · Restricted Project, Restricted Project
spupyrev committed rGbcdc0477319a: speeding up ext-tsp for huge instances (authored by spupyrev).
speeding up ext-tsp for huge instances
Mar 2 2022, 7:23 AM · Restricted Project
spupyrev closed D120780: speeding up ext-tsp for huge instances.
Mar 2 2022, 7:23 AM · Restricted Project, Restricted Project

Mar 1 2022

spupyrev added a comment to D120780: speeding up ext-tsp for huge instances.

sorry misspelled increase/decrease

Mar 1 2022, 4:21 PM · Restricted Project, Restricted Project
spupyrev updated the diff for D120780: speeding up ext-tsp for huge instances.

rename

Mar 1 2022, 3:19 PM · Restricted Project, Restricted Project
spupyrev updated the diff for D120780: speeding up ext-tsp for huge instances.

minor

Mar 1 2022, 3:16 PM · Restricted Project, Restricted Project
spupyrev updated the summary of D120780: speeding up ext-tsp for huge instances.
Mar 1 2022, 3:16 PM · Restricted Project, Restricted Project
spupyrev requested review of D120780: speeding up ext-tsp for huge instances.
Mar 1 2022, 3:07 PM · Restricted Project, Restricted Project

Feb 24 2022

spupyrev updated the summary of D120508: introducing profi flags.
Feb 24 2022, 11:42 AM · Restricted Project, Restricted Project
spupyrev requested review of D120508: introducing profi flags.
Feb 24 2022, 11:37 AM · Restricted Project, Restricted Project

Feb 22 2022

spupyrev updated the diff for D118640: [CSSPGO] Even count distribution.

faster convergence

Feb 22 2022, 8:26 AM · Restricted Project, Restricted Project

Feb 16 2022

spupyrev added inline comments to D118640: [CSSPGO] Even count distribution.
Feb 16 2022, 9:21 AM · Restricted Project, Restricted Project
spupyrev updated the diff for D118640: [CSSPGO] Even count distribution.

review comments

Feb 16 2022, 9:21 AM · Restricted Project, Restricted Project

Feb 1 2022

spupyrev added a comment to D118640: [CSSPGO] Even count distribution.

Detailed perf measurements on clang, release_10 (speedups over the previous version of inference):
with CSSPGO+LTO:

benchmark1: 1.52% (stat sig)
benchmark2: 0.84% (stat sig)

with AutoFDO+LTO:

benchmark1: 1.72% (stat sig)
benchmark2: 0.61% (stat sig)
Feb 1 2022, 7:33 AM · Restricted Project, Restricted Project

Jan 31 2022

spupyrev updated the summary of D118640: [CSSPGO] Even count distribution.
Jan 31 2022, 12:10 PM · Restricted Project, Restricted Project
spupyrev retitled D118640: [CSSPGO] Even count distribution from [CSSPGO] Even flow distribution to [CSSPGO] Even count distribution.
Jan 31 2022, 12:07 PM · Restricted Project, Restricted Project
spupyrev requested review of D118640: [CSSPGO] Even count distribution.
Jan 31 2022, 11:47 AM · Restricted Project, Restricted Project

Jan 18 2022

spupyrev closed D116970: a better profi rebalancer.
Jan 18 2022, 2:59 PM · Restricted Project
spupyrev committed rG13d1364a3443: A better profi rebalancer (authored by spupyrev).
A better profi rebalancer
Jan 18 2022, 12:21 PM
spupyrev updated the diff for D116970: a better profi rebalancer.

rebase

Jan 18 2022, 11:11 AM · Restricted Project
spupyrev updated the diff for D116970: a better profi rebalancer.

rebase

Jan 18 2022, 7:37 AM · Restricted Project

Jan 14 2022

spupyrev added inline comments to D116970: a better profi rebalancer.
Jan 14 2022, 8:30 AM · Restricted Project
spupyrev updated the diff for D116970: a better profi rebalancer.

addressing hoy's comments

Jan 14 2022, 8:29 AM · Restricted Project

Jan 12 2022

spupyrev added inline comments to D116970: a better profi rebalancer.
Jan 12 2022, 2:59 PM · Restricted Project
spupyrev added a comment to D116970: a better profi rebalancer.

I see up to 0.5% perf on some (large) binaries, e.g., clang-10 and gcc-8.

Great results! And the change also makes sense. Was this with AutoFDO or CSSPGO or InstrPGO? How does overall count quality look with this change?

We can also give it a try on server workloads.

Jan 12 2022, 2:49 PM · Restricted Project

Jan 11 2022

spupyrev updated the diff for D116970: a better profi rebalancer.

another clang-format

Jan 11 2022, 12:18 PM · Restricted Project
spupyrev updated the diff for D116970: a better profi rebalancer.

git-clang-format HEAD^

Jan 11 2022, 7:45 AM · Restricted Project

Jan 10 2022

spupyrev updated the diff for D116970: a better profi rebalancer.

rebase

Jan 10 2022, 3:23 PM · Restricted Project
spupyrev added a reviewer for D116970: a better profi rebalancer: wlei.
Jan 10 2022, 1:41 PM · Restricted Project
spupyrev updated the summary of D116970: a better profi rebalancer.
Jan 10 2022, 1:41 PM · Restricted Project
spupyrev requested review of D116970: a better profi rebalancer.
Jan 10 2022, 1:35 PM · Restricted Project

Dec 7 2021

spupyrev committed rGdc973495059e: fixing a broken ext-tsp test (authored by spupyrev).
fixing a broken ext-tsp test
Dec 7 2021, 8:38 AM
spupyrev closed D115255: fixing a broken ext-tsp test.
Dec 7 2021, 8:38 AM · Restricted Project
spupyrev updated the summary of D115255: fixing a broken ext-tsp test.
Dec 7 2021, 8:26 AM · Restricted Project
spupyrev requested review of D115255: fixing a broken ext-tsp test.
Dec 7 2021, 8:24 AM · Restricted Project
spupyrev committed rGf573f6866e18: ext-tsp basic block layout (authored by spupyrev).
ext-tsp basic block layout
Dec 7 2021, 7:31 AM
spupyrev closed D113424: ext-tsp basic block layout.
Dec 7 2021, 7:31 AM · Restricted Project

Dec 6 2021

spupyrev updated the diff for D113424: ext-tsp basic block layout.

making the tests deterministic

Dec 6 2021, 4:37 PM · Restricted Project
spupyrev reopened D113424: ext-tsp basic block layout.
Dec 6 2021, 4:27 PM · Restricted Project
spupyrev updated the summary of D115171: code size reduction using ext-tsp block placement.
Dec 6 2021, 11:24 AM · Restricted Project
spupyrev requested review of D115171: code size reduction using ext-tsp block placement.
Dec 6 2021, 11:19 AM · Restricted Project
spupyrev committed rGc68f71eb37c2: ext-tsp basic block layout (authored by spupyrev).
ext-tsp basic block layout
Dec 6 2021, 8:59 AM
spupyrev closed D113424: ext-tsp basic block layout.
Dec 6 2021, 8:58 AM · Restricted Project

Dec 3 2021

spupyrev added inline comments to D113424: ext-tsp basic block layout.
Dec 3 2021, 2:56 PM · Restricted Project
spupyrev updated the diff for D113424: ext-tsp basic block layout.

changed type of Chain.Id to uint64

Dec 3 2021, 2:56 PM · Restricted Project