This is an archive of the discontinued LLVM Phabricator instance.

Differential D159175

[JITLink][PowerPC][RFC] Make JITLink default in LLJIT for ppc64 elfv2abi
ClosedPublic

Authored by lkail on Aug 30 2023, 1:01 AM.

Details

Reviewers
lhames
v.g.vassilev
dim
brad
Group Reviewers
Restricted Project
Commits
rG7d9039e11d3f: [JITLink][PowerPC][RFC] Make JITLink default in LLJIT for ppc64 elfv2abi
Summary

JITLink for ppc64 has implemented all relocations implemented in rtdyld for ppc64 and has passed all existed lit tests and unittests in llvm/clang/compiler-rt. I propose making JITLink for ppc64 default in LLJIT.

Diff Detail

Event Timeline

lkail created this revision.Aug 30 2023, 1:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2023, 1:01 AM
Herald added subscribers: shchenz, hiraditya, nemanjai. · View Herald Transcript
lkail requested review of this revision.Aug 30 2023, 1:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2023, 1:01 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
lkail added a parent revision: D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests.Aug 30 2023, 1:01 AM
lkail edited the summary of this revision. (Show Details)Aug 30 2023, 1:06 AM
lkail added reviewers: Restricted Project, lhames, v.g.vassilev.
lkail updated this revision to Diff 554621.Aug 30 2023, 1:12 AM
lkail retitled this revision from [JITLink][PowerPC][RFC] Make JITLink default in LLJIT for ppc64 to [JITLink][PowerPC][RFC] Make JITLink default in LLJIT for ppc64 elfv2abi.
lkail added reviewers: dim, brad.Aug 30 2023, 1:58 AM

Added FreeBSD developers.

Harbormaster completed remote builds in B255725: Diff 554621.Aug 30 2023, 4:08 AM
lkail edited parent revisions, added: D158708: [JITLink][PowerPC] Fix incorrect assertion of addend for R_PPC64_REL24; removed: D159167: [clang-repl][Orc] Export executable symbols in ClangReplInterpreterExceptionTests.Sep 12 2023, 10:09 PM
lhames accepted this revision.Sep 13 2023, 9:36 AM

LGTM -- Thanks @lkail!

This revision is now accepted and ready to land.Sep 13 2023, 9:36 AM
lkail removed a parent revision: D158708: [JITLink][PowerPC] Fix incorrect assertion of addend for R_PPC64_REL24.Sep 13 2023, 8:21 PM
Closed by commit rG7d9039e11d3f: [JITLink][PowerPC][RFC] Make JITLink default in LLJIT for ppc64 elfv2abi (authored by lkail). · Explain WhySep 17 2023, 7:19 PM
This revision was automatically updated to reflect the committed changes.
lkail added a commit: rG7d9039e11d3f: [JITLink][PowerPC][RFC] Make JITLink default in LLJIT for ppc64 elfv2abi.

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
Orc/
6 lines

Diff 556922

llvm/lib/ExecutionEngine/Orc/LLJIT.cpp

Show First 20 Lines • Show All 746 Lines • ▼ Show 20 Lines case Triple::loongarch64:
UseJITLink = true; UseJITLink = true;
break; break;
case Triple::aarch64: case Triple::aarch64:
UseJITLink = !TT.isOSBinFormatCOFF(); UseJITLink = !TT.isOSBinFormatCOFF();
break; break;
case Triple::x86_64: case Triple::x86_64:
UseJITLink = !TT.isOSBinFormatCOFF(); UseJITLink = !TT.isOSBinFormatCOFF();
break; break;
case Triple::ppc64:
UseJITLink = TT.isPPC64ELFv2ABI();
break;
case Triple::ppc64le:
UseJITLink = TT.isOSBinFormatELF();
break;
default: default:
break; break;
} }
if (UseJITLink) { if (UseJITLink) {
JTMB->setRelocationModel(Reloc::PIC_); JTMB->setRelocationModel(Reloc::PIC_);
JTMB->setCodeModel(CodeModel::Small); JTMB->setCodeModel(CodeModel::Small);
CreateObjectLinkingLayer = CreateObjectLinkingLayer =
[](ExecutionSession &ES, [](ExecutionSession &ES,
▲ Show 20 Lines • Show All 539 Lines • Show Last 20 Lines