[lldb][NFC] Put disassembler test classes and methods in anonymous namespace

[DavidSpickett]

And this is being done for what reason?

I seem to remember something about static and anonymous namespace in the developer guide, please cite that if so.

[RamNalamothu]

In D158971#4624001, @DavidSpickett wrote:

And this is being done for what reason?

This is a follow-up on https://reviews.llvm.org/D156086#inline-1518306 comment.
I see that most of the lldb unit tests follow this style.

I seem to remember something about static and anonymous namespace in the developer guide, please cite that if so.

Are you referring to https://llvm.org/docs/CodingStandards.html#anonymous-namespaces?

[DavidSpickett]

Are you referring to https://llvm.org/docs/CodingStandards.html#anonymous-namespaces?

That's the one, please include that in the commit message. Other than that this LGTM.

[RamNalamothu]

Update commit message to refer to anonymous namespace guideline.

[RamNalamothu]

In D158971#4633434, @RamNalamothu wrote:

Update commit message to refer to anonymous namespace guideline.

Ah, seems like I have messed up with an arcanist option and the commit message update didn't get picked here/in the actual commit. Apologies for that.

lldb/unittests/Disassembler/ARM/TestArm64Disassembly.cpp

 #include "lldb/Target/ExecutionContext.h"
 
 #include "Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h"
 #include "llvm/Support/TargetSelect.h"
 
 using namespace lldb;
 using namespace lldb_private;
 
+namespace {
 class TestArm64Disassembly : public testing::Test {
 public:
   static void SetUpTestCase();
   static void TearDownTestCase();
 
   //  virtual void SetUp() override { }
   //  virtual void TearDown() override { }
 
 protected:
 };
 
 void TestArm64Disassembly::SetUpTestCase() {
   llvm::InitializeAllTargets();
   llvm::InitializeAllAsmPrinters();
   llvm::InitializeAllTargetMCs();
   llvm::InitializeAllDisassemblers();
   DisassemblerLLVMC::Initialize();
 }
 
 void TestArm64Disassembly::TearDownTestCase() {
   DisassemblerLLVMC::Terminate();
 }
+} // namespace
 
 TEST_F(TestArm64Disassembly, TestArmv81Instruction) {
   ArchSpec arch("arm64-apple-ios");
 
   const unsigned num_of_instructions = 2;
   uint8_t data[] = {
       0xff, 0x43, 0x00, 0xd1, // 0xd10043ff :  sub    sp, sp, #0x10
       0x62, 0x7c, 0xa1, 0xc8, // 0xc8a17c62 :  cas    x1, x2, [x3] (cas defined in ARM v8.1 & newer)

lldb/unittests/Disassembler/ARM/TestArmv7Disassembly.cpp

 #include "lldb/Target/ExecutionContext.h"
 
 #include "Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h"
 #include "llvm/Support/TargetSelect.h"
 
 using namespace lldb;
 using namespace lldb_private;
 
+namespace {
 class TestArmv7Disassembly : public testing::Test {
 public:
   static void SetUpTestCase();
   static void TearDownTestCase();
 
   //  virtual void SetUp() override { }
   //  virtual void TearDown() override { }
 
 protected:
 };
 
 void TestArmv7Disassembly::SetUpTestCase() {
   llvm::InitializeAllTargets();
   llvm::InitializeAllAsmPrinters();
   llvm::InitializeAllTargetMCs();
   llvm::InitializeAllDisassemblers();
   DisassemblerLLVMC::Initialize();
 }
 
 void TestArmv7Disassembly::TearDownTestCase() {
   DisassemblerLLVMC::Terminate();
 }
+} // namespace
 
 TEST_F(TestArmv7Disassembly, TestCortexFPDisass) {
   ArchSpec arch("armv7em--");
 
   const unsigned num_of_instructions = 3;
   uint8_t data[] = {
       0x00, 0xee, 0x10, 0x2a, // 0xee002a10 :  vmov   s0, r2
       0xb8, 0xee, 0xc0, 0x0b, // 0xeeb80bc0 :  vcvt.f64.s32 d0, s0

lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp

 #include "lldb/Target/ExecutionContext.h"
 #include "lldb/Utility/ArchSpec.h"
 
 #include "Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h"
 
 using namespace lldb;
 using namespace lldb_private;
 
+namespace {
 class TestMCDisasmInstanceRISCV : public testing::Test {
 public:
   static void SetUpTestCase();
   static void TearDownTestCase();
 
 protected:
 };
 
 void TestMCDisasmInstanceRISCV::SetUpTestCase() {
   llvm::InitializeAllTargets();
   llvm::InitializeAllAsmPrinters();
   llvm::InitializeAllTargetMCs();
   llvm::InitializeAllDisassemblers();
   DisassemblerLLVMC::Initialize();
 }
 
 void TestMCDisasmInstanceRISCV::TearDownTestCase() {
   DisassemblerLLVMC::Terminate();
 }
+} // namespace
 
 TEST_F(TestMCDisasmInstanceRISCV, TestRISCV32Instruction) {
   ArchSpec arch("riscv32-*-linux");
 
   const unsigned num_of_instructions = 5;
   uint8_t data[] = {
       0xef, 0x00, 0x00, 0x00, // call -- jal x1, 0
       0xe7, 0x00, 0x00, 0x00, // call -- jalr x1, x0, 0

lldb/unittests/Disassembler/x86/TestGetControlFlowKindx86.cpp

 #include "lldb/Target/ExecutionContext.h"
 #include "lldb/Utility/ArchSpec.h"
 
 #include "Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h"
 
 using namespace lldb;
 using namespace lldb_private;
 
+namespace {
 class TestGetControlFlowKindx86 : public testing::Test {
 public:
   static void SetUpTestCase();
   static void TearDownTestCase();
 
 protected:
 };
 
 void TestGetControlFlowKindx86::SetUpTestCase() {
   llvm::InitializeAllTargets();
   llvm::InitializeAllAsmPrinters();
   llvm::InitializeAllTargetMCs();
   llvm::InitializeAllDisassemblers();
   DisassemblerLLVMC::Initialize();
 }
 
 void TestGetControlFlowKindx86::TearDownTestCase() {
   DisassemblerLLVMC::Terminate();
 }
+} // namespace
 
 TEST_F(TestGetControlFlowKindx86, TestX86_64Instruction) {
   ArchSpec arch("x86_64-*-linux");
 
   const unsigned num_of_instructions = 29;
   uint8_t data[] = {
       0x55,                               // other -- pushq %rbp
       0x48, 0x89, 0xe5,                   // other -- movq %rsp, %rbp