[mlir][Linalg] Move test

[awarzynski]

Summary

To avoid confusion with vectorization-masked.mlir, move

test/Dialect/Linalg/masked_vectorization.mlir

to:

test/Dialect/Linalg/transform-op-tile-and-vectorize.mlir

Also, the updated name better reflects what's being tested.

[dcaballe]

Not sure I follow. Why do we have to vectorize lit tests? Which tests should go to which file?

[awarzynski]

In D158427#4605593, @dcaballe wrote:

Not sure I follow. Why do we have to vectorize lit tests?

The new LIT test file that I am moving (masked_vectorization.mlir) was introduced in: https://reviews.llvm.org/D157047. As a result, right now we have two files with (almost) identical name:

• mlir/test/Dialect/Linalg/masked_vectorization.mlir (new file)
• mlir/test/Dialect/Linalg/vectorization-masked.mlir (old file that predates D157047)

Which tests should go to which file?

Yes, that's confusing and that's what I'm trying to improve :)

Looking at the contents of masked_vectorization.mlir, I presume that the intent was to test transformations rather than specifically the vectoriser. Hence I am proposing to rename:

• masked_vectorization.mlir

as

• transform-op-tile-and-vectorize.mlir.

Apologies, I should've been clearer in my summary.

[nicolasvasilache]

ah yes, sorry for the unfortunate naming ..

Can we call the new file transform-compose-masked-vectorize-and-cleanups ?

It was not trivial to find the right things to apply after masked vectorization to get good IR.

[nicolasvasilache]

updated the comment

[awarzynski]

In D158427#4646517, @nicolasvasilache wrote:

ah yes, sorry for the unfortunate naming ..

Can we call the new file transform-compose-masked-vectorize-and-cleanups ?

It was not trivial to find the right things to apply after masked vectorization to get good IR.

Done :)

[nicolasvasilache]

I realize I had mistyped this but I did mean transform-xxx., not transpose- :)

[awarzynski]

In D158427#4646651, @nicolasvasilache wrote:

I realize I had mistyped this but I did mean transform-xxx., not transpose- :)

Yes, but then you fixed that and I missed your subsequent note:

updated the comment

So, my bad, sorry :) All sorted upstream - I pushed an nfc to fix the name 👍🏻