Remove dangerousSetOptions and call promoteOperands with the correct arguments directly.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp | ||
---|---|---|
984–990 | I'm not sure if this is the correct behavior. But it was already like that before this revision. |
mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp | ||
---|---|---|
984–990 | It indeed feels wrong, especially given the name of the parameter. Maybe it should be called 'alwaysUseBarePtrCallConv' to make this clearer, as it is an override. @ftynse do you have context in this? But this is not a problem for this change. |
I'm not sure if this is the correct behavior. But it was already like that before this revision.