Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[Clang][CodeGen] Add __builtin_bcopy
Needs ReviewPublic

Authored by cseo on Aug 16 2023, 5:34 PM.

Details

Reviewers
arsenm
Group Reviewers
Restricted Project
Summary

Add __builtin_bcopy to the list of GNU builtins. This was causing a series of
test failures in glibc.

Adjust the tests to reflect the changes in codegen.

Fixes #51409.
Fixes #63065.

Diff Detail

Event Timeline

cseo created this revision.Aug 16 2023, 5:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2023, 5:34 PM
cseo requested review of this revision.Aug 16 2023, 5:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2023, 5:34 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
cseo updated this revision to Diff 551187.Aug 17 2023, 10:38 AM

Fix ppc bcopy test

cseo retitled this revision from [Clang] Add __builtin_bcopy to [Clang][CodeGen] Add __builtin_bcopy.Aug 17 2023, 10:49 AM
cseo edited the summary of this revision. (Show Details)
cseo added a reviewer: Restricted Project.
cseo updated this revision to Diff 552370.Aug 22 2023, 8:05 AM

Fix builtin definition and tests

shafik added a subscriber: shafik.Aug 24 2023, 4:15 PM
shafik added inline comments.
clang/lib/CodeGen/CGBuiltin.cpp
3624

Maybe it is better to do these in order to be consistent with the rest of the code to avoid easy confusion.

3630
cseo updated this revision to Diff 553467.Aug 25 2023, 7:26 AM

Address issues from the last revision.

cseo marked 2 inline comments as done.Aug 25 2023, 7:26 AM
cseo added a comment.Aug 28 2023, 6:33 AM

FWIW, the pre-merge checks failed due to a problem with git-clang-format, not the tests themselves (they are all green).

cseo added a comment.Aug 31 2023, 11:56 AM

Ping. Any other comments/concerns?

cseo added a reviewer: arsenm.Sep 12 2023, 2:38 PM