We were defaulting to VL=0 when we didn't otherwise have a vsetv nearby. Instead, let's use VL=1. VL=0 is very much a cornercase in hardware, and let's avoid if we can.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Paths
| Differential D158015
[RISCVInsertVSETVLI] Default to VL=1 for scalar extracts ClosedPublic Authored by reames on Aug 15 2023, 12:38 PM.
Details Summary We were defaulting to VL=0 when we didn't otherwise have a vsetv nearby. Instead, let's use VL=1. VL=0 is very much a cornercase in hardware, and let's avoid if we can.
Diff Detail
Event Timelinereames added a child revision: D157991: [RISCVInsertVSETVLI] Handle scalar extract (vmv.x.s, and vmx.f.s).Aug 15 2023, 1:19 PM This revision is now accepted and ready to land.Aug 15 2023, 6:26 PM This revision was landed with ongoing or failed builds.Aug 16 2023, 7:43 AM Closed by commit rGb06e52c32f4d: [RISCVInsertVSETVLI] Default to VL=1 for scalar extracts (authored by reames). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 550751 llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp
llvm/test/CodeGen/RISCV/double_reduct.ll
llvm/test/CodeGen/RISCV/rvv/extractelt-fp.ll
llvm/test/CodeGen/RISCV/rvv/extractelt-int-rv32.ll
llvm/test/CodeGen/RISCV/rvv/extractelt-int-rv64.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-bitcast.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-extract-i1.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-fp-bitcast.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-masked-gather.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-masked-scatter.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-reduction-fp.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-reduction-int.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-unaligned.ll
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vfptoi-constrained-sdnode.ll
llvm/test/CodeGen/RISCV/rvv/fpclamptosat_vec.ll
llvm/test/CodeGen/RISCV/rvv/vfmv.f.s.ll
llvm/test/CodeGen/RISCV/rvv/vmv.x.s-rv32.ll
llvm/test/CodeGen/RISCV/rvv/vmv.x.s-rv64.ll
llvm/test/CodeGen/RISCV/rvv/vreductions-fp-sdnode.ll
llvm/test/CodeGen/RISCV/rvv/vreductions-int-vp.ll
llvm/test/CodeGen/RISCV/rvv/vreductions-int.ll
llvm/test/CodeGen/RISCV/rvv/vsetvli-insert.mir
llvm/test/CodeGen/RISCV/rvv/vsetvli-regression.ll
llvm/test/CodeGen/RISCV/spill-fpr-scalar.ll
|