This is an archive of the discontinued LLVM Phabricator instance.

[clang] Support function pointer types with attributes when extracting parameter names for signature help
ClosedPublic

Authored by nridge on Aug 14 2023, 11:50 PM.

Diff Detail

Event Timeline

nridge created this revision.Aug 14 2023, 11:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 11:50 PM
Herald added a subscriber: arphaman. · View Herald Transcript
nridge requested review of this revision.Aug 14 2023, 11:50 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 14 2023, 11:50 PM
sammccall accepted this revision.Aug 15 2023, 1:16 AM
sammccall added a subscriber: sammccall.
sammccall added inline comments.
clang/lib/Sema/SemaCodeComplete.cpp
6073

By unwrapping these in a fixed order, we'll successfully unwrap a pointer to an attributed function type, but not an attributed pointer to function type.

Maybe extract a recursive function so we can unwrap arbitrary sequences of sugar?

This revision is now accepted and ready to land.Aug 15 2023, 1:16 AM
nridge updated this revision to Diff 551374.Aug 17 2023, 9:24 PM

Address review comment

This revision was landed with ongoing or failed builds.Aug 17 2023, 9:27 PM
This revision was automatically updated to reflect the committed changes.
nridge marked an inline comment as done.Aug 17 2023, 9:28 PM