This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][GISel] Legalize G_PHI and G_BRCOND.
ClosedPublic

Authored by craig.topper on Aug 13 2023, 11:08 AM.

Diff Detail

Event Timeline

craig.topper created this revision.Aug 13 2023, 11:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2023, 11:08 AM
craig.topper requested review of this revision.Aug 13 2023, 11:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2023, 11:08 AM
craig.topper retitled this revision from [RISCV] Legalize G_PHI and G_BRCOND. to [RISCV][GISel] Legalize G_PHI and G_BRCOND..Aug 13 2023, 11:11 AM
reames accepted this revision.Aug 14 2023, 9:25 AM
reames added a subscriber: reames.

LGTM w/minor comment

llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
909

Can you convert the I->isPreISelOpcode() check to an early return w/comment here? (Since all of the cases following are guarded by this condition.)

This revision is now accepted and ready to land.Aug 14 2023, 9:25 AM
This revision was landed with ongoing or failed builds.Aug 14 2023, 10:22 AM
This revision was automatically updated to reflect the committed changes.