This is an archive of the discontinued LLVM Phabricator instance.

[SPARC][IAS] Add v9 encoding of %fq
ClosedPublic

Authored by koakuma on Aug 6 2023, 7:12 AM.

Details

Summary

While both SPARCv7/v8 and v9 has a register named %fq, they encode it differently, so we need to differentiate between them.

Depends on D157231

Diff Detail

Event Timeline

koakuma created this revision.Aug 6 2023, 7:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 7:12 AM
koakuma requested review of this revision.Aug 6 2023, 7:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 7:12 AM

There should be a disassembler test.

llvm/lib/Target/Sparc/SparcInstrInfo.td
1774
koakuma updated this revision to Diff 548212.Aug 8 2023, 7:25 AM
koakuma marked an inline comment as done.

Apply suggestions & add disassembly tests.

This revision is now accepted and ready to land.Aug 8 2023, 10:04 AM
koakuma updated this revision to Diff 555552.Sep 1 2023, 7:52 PM

Improve tests; account for different interpretation of V8/V9 encoding for %fq.

barannikov88 accepted this revision.Sep 5 2023, 1:20 AM

Still LGTM

This revision was landed with ongoing or failed builds.Sep 5 2023, 1:51 AM
Closed by commit rG2f3a362cc06e: [SPARC][IAS] Add v9 encoding of %fq (authored by koakuma, committed by brad). · Explain Why
This revision was automatically updated to reflect the committed changes.