This is an archive of the discontinued LLVM Phabricator instance.

Fix typos in comments of ExecutionEngine/
ClosedPublic

Authored by Eymay on Aug 6 2023, 4:47 AM.

Diff Detail

Unit TestsFailed

Event Timeline

Eymay created this revision.Aug 6 2023, 4:47 AM
Herald added a project: Restricted Project. · View Herald Transcript
Eymay requested review of this revision.Aug 6 2023, 4:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2023, 4:47 AM
sgraenitz added a subscriber: sgraenitz.

Wow, that's a lot of typo fixes! Thanks!

Let's drop all the an <--> a changes, I think these are fine.

Everything else LGTM.

Eymay added a comment.Aug 7 2023, 5:57 AM

Let's drop all the an <--> a changes, I think these are fine.

Though it's a very minor thing, I wanted to remove all of the "a ELF " usage in the whole project including lldb https://reviews.llvm.org/D157214. I can revert them with no problem.

Eymay updated this revision to Diff 549351.Aug 11 2023, 5:30 AM

Reverted a -> an changes for acronyms in comments

sgraenitz accepted this revision.Aug 11 2023, 6:35 AM

LGTM, thanks! Should I land it on your behalf?

llvm/lib/ExecutionEngine/Orc/DebugUtils.cpp
79

I think we could keep this as well. Was it by accident?

This revision is now accepted and ready to land.Aug 11 2023, 6:35 AM
Eymay added a comment.EditedAug 11 2023, 7:28 AM

LGTM, thanks! Should I land it on your behalf?

Yes please. You can use:
"Eymen Ünay <eymenunay@outlook.com>"

llvm/lib/ExecutionEngine/Orc/DebugUtils.cpp
79

It is the only non-acronym pattern so I left it out.

This revision was automatically updated to reflect the committed changes.
lhames added a subscriber: lhames.Aug 14 2023, 8:12 AM

Oh cool -- thanks very much for this @Eymay!