Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
| Time | Test | |
|---|---|---|
| 60,050 ms | x64 debian > MLIR.Examples/standalone::test.toy |
Event Timeline
Comment Actions
Wow, that's a lot of typo fixes! Thanks!
Let's drop all the an <--> a changes, I think these are fine.
Everything else LGTM.
Comment Actions
Though it's a very minor thing, I wanted to remove all of the "a ELF " usage in the whole project including lldb https://reviews.llvm.org/D157214. I can revert them with no problem.
Comment Actions
LGTM, thanks! Should I land it on your behalf?
| llvm/lib/ExecutionEngine/Orc/DebugUtils.cpp | ||
|---|---|---|
| 79 | I think we could keep this as well. Was it by accident? | |
Comment Actions
Yes please. You can use:
"Eymen Ünay <eymenunay@outlook.com>"
| llvm/lib/ExecutionEngine/Orc/DebugUtils.cpp | ||
|---|---|---|
| 79 | It is the only non-acronym pattern so I left it out. | |
I think we could keep this as well. Was it by accident?