This is an archive of the discontinued LLVM Phabricator instance.

[X86] Update features for sierraforest, grandridge
ClosedPublic

Authored by FreddyYe on Jul 19 2023, 11:41 PM.

Diff Detail

Event Timeline

FreddyYe created this revision.Jul 19 2023, 11:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 11:41 PM
FreddyYe requested review of this revision.Jul 19 2023, 11:41 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 19 2023, 11:41 PM
pengfei added inline comments.Jul 20 2023, 5:36 AM
clang/test/Preprocessor/predefined-arch-macros.c
2496

This is easy to be confused. How about add a not check? e.g.,

... -check-prefix=CHECK_SRF_GRR_M32,CHECK_SRF_M32
... -check-prefixes=CHECK_SRF_GRR_M32,CHECK_GRR_M32
...
// CHECK_SRF_GRR_M32: #define __PTWRITE__ 1
// CHECK_SRF_M32-NOT: __RAOINT__
// CHECK_GRR_M32: #define __RAOINT__ 1
2569

ditto.

FreddyYe updated this revision to Diff 542476.Jul 20 2023, 6:05 AM
FreddyYe marked an inline comment as done.

address comment.

pengfei accepted this revision.Jul 20 2023, 6:48 AM
This revision is now accepted and ready to land.Jul 20 2023, 6:48 AM
FreddyYe marked an inline comment as done.Jul 20 2023, 10:25 PM
Matt added a subscriber: Matt.Jul 24 2023, 11:21 AM
This revision was landed with ongoing or failed builds.Jul 24 2023, 8:01 PM
This revision was automatically updated to reflect the committed changes.