This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump] Default to --mcpu=future for PPC32
ClosedPublic

Authored by MaskRay on Jul 12 2023, 1:30 PM.

Details

Summary

Extend D127824 to the 32-bit Power architecture.
AFAICT GNU objdump -d dumps all instructions for 32-bit as well.

Diff Detail

Event Timeline

MaskRay created this revision.Jul 12 2023, 1:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2023, 1:30 PM
MaskRay requested review of this revision.Jul 12 2023, 1:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2023, 1:30 PM
nemanjai accepted this revision.Jul 12 2023, 1:36 PM

Thanks for adding this. Nice to common-up the behaviour. LGTM.

llvm/docs/CommandGuide/llvm-objdump.rst
31

Maybe PowerPC instead of Power.

This revision is now accepted and ready to land.Jul 12 2023, 1:36 PM
MaskRay added inline comments.Jul 12 2023, 1:41 PM
llvm/docs/CommandGuide/llvm-objdump.rst
31

Thanks for the super quick review. I was thinking of https://en.wikipedia.org/wiki/Power_ISA Power is canonical while PowerPC is the old name.
In software projects, it's true that "PowerPC" and "powerpc" are still much more common ...

MaskRay updated this revision to Diff 539810.Jul 12 2023, 6:21 PM

change "Power" to "PowerPC". PowerPC occurs in another place in the doc.

This revision was landed with ongoing or failed builds.Jul 12 2023, 6:24 PM
This revision was automatically updated to reflect the committed changes.