This is an archive of the discontinued LLVM Phabricator instance.

Add support for missing v_pk_fmac_f16_dpp
Needs ReviewPublic

Authored by aakanksha555 on Jul 11 2023, 6:27 PM.

Details

Diff Detail

Event Timeline

aakanksha555 created this revision.Jul 11 2023, 6:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 6:27 PM
aakanksha555 requested review of this revision.Jul 11 2023, 6:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 6:27 PM
foad added a comment.Jul 12 2023, 4:52 AM

Does this need asm/dis tests for gfx908, gfx90a, gfx90c, gfx940?

Does this need asm/dis tests for gfx908, gfx90a, gfx90c, gfx940?

The bug mentions gfx908 and gfx90a; I'll add tests for those.
Unsure about gfx90c and gfx940. Let me look into it more.

Should also get codegen tests to produce it?

Does this need asm/dis tests for gfx908, gfx90a, gfx90c, gfx940?

Right, it is supported on gfx908, gfx90a, gfx940 (not gfx90c though).

aakanksha555 updated this revision to Diff 542279.EditedJul 19 2023, 7:43 PM

Added gfx908, gfx90a and gfx940

Needs gfx90a and gfx940 MC tests. Also needs codegen test in a spirit of dpp_combine.mir/dpp_combine.ll but with different targets.

llvm/test/MC/AMDGPU/gfx10_asm_vop2.s
13189

This is not VOP2, this is DPP16.