This is an archive of the discontinued LLVM Phabricator instance.

[FPEnv][TableGen] Add strictfp attribute to constrained intrinsics by default.
ClosedPublic

Authored by kpn on Jul 11 2023, 10:58 AM.

Details

Summary

In D146869 @arsenm pointed out that the constrained intrinsics aren't getting the strictfp attribute by default. They should be, since they are required to have it anyway.

TableGen did not know about this attribute until now. This patch adds strictfp to TableGen, and it uses it on all of the constrained intrinsics.

Diff Detail

Event Timeline

kpn created this revision.Jul 11 2023, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 10:58 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
kpn requested review of this revision.Jul 11 2023, 10:58 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 11 2023, 10:58 AM
arsenm added inline comments.Jul 11 2023, 11:05 AM
llvm/test/Feature/fp-intrinsics-attr.ll
1 ↗(On Diff #539193)

Should move to test/Assembler and round trip through llvm-as and llvm-dis like other similar tests

kpn updated this revision to Diff 539204.Jul 11 2023, 11:15 AM

Move test and change to round-tripping as requested.

arsenm accepted this revision.Jul 11 2023, 11:24 AM
arsenm added inline comments.
llvm/include/llvm/IR/Intrinsics.td
1102

Eventually I think it would be better if we had some sort of fpenv access property, such that we'll know which set of target intrinsics need handling and which aspects of the fpenv

This revision is now accepted and ready to land.Jul 11 2023, 11:24 AM
This revision was landed with ongoing or failed builds.Jul 12 2023, 6:56 AM
This revision was automatically updated to reflect the committed changes.