This is an archive of the discontinued LLVM Phabricator instance.

[libc++][doc] Updates the release notes.
ClosedPublic

Authored by Mordante on Jul 10 2023, 12:07 PM.

Details

Summary

This is a preparation for the upcoming LLVM 17 release.

Diff Detail

Event Timeline

Mordante created this revision.Jul 10 2023, 12:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2023, 12:07 PM
Mordante published this revision for review.Jul 10 2023, 12:10 PM
Mordante added inline comments.
libcxx/docs/ReleaseNotes.rst
68

@var-const I noticed you did quite some work on ranges::to, will that be ready before LLVM 17, if not should we mention it.

68

@crtrott I read you expected to get <mdspan> done before LLVM 17, so I leave adding that to the release notes for you.

Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2023, 12:10 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jul 10 2023, 12:38 PM

Nice, thanks!

This revision is now accepted and ready to land.Jul 10 2023, 12:38 PM
philnik added inline comments.Jul 10 2023, 12:42 PM
libcxx/docs/ReleaseNotes.rst
73

We also applied a similar optimization to find (D144394).

95
97

FreeBSD was officially supported before. We just have a CI runner now.

154

We've added the interface __asan_annotate_container_with_allocator . See https://libcxx.llvm.org/UsingLibcxx.html#turning-off-asan-annotation-in-containers. Not sure though whether we want to advertise that.

libcxx/docs/Status/PSTL.rst
1

What does this change do? We don't have an underscore in most status pages. zip, spaceship, ranges, pstl, parallelism TS, format. That's actually all the non cxxab status papers.

H-G-Hristov accepted this revision.Jul 11 2023, 4:12 AM

Thanks for all the feedback! I wait a few more days before landing this. (We still have more than a week before branching.)

libcxx/docs/Status/PSTL.rst
1

This means most status pages can't be linked to. I added a link to this page from the release notes. I really like the progress made on the PSTL, so I think it is great to show the status page.

var-const added inline comments.Jul 14 2023, 8:51 PM
libcxx/docs/ReleaseNotes.rst
68

@Mordante Thanks a lot for updating the release notes and for checking re. ranges::to! I'm actively working on the last remaining two patches for ranges::to and hoping to get them in before the release. If that happens, I'll update the release notes accordingly.

jloser accepted this revision.Jul 15 2023, 8:44 PM

Looks good - just left a comment on a minor typo. Thanks!

libcxx/docs/ReleaseNotes.rst
95

Quibble: typo. s/containters/containers

pfusik added inline comments.Jul 16 2023, 9:41 AM
libcxx/docs/ReleaseNotes.rst
68
Mordante marked 8 inline comments as done.Jul 17 2023, 9:39 AM

Thanks for all reviews. I'll land it now. When there are more remarks I can address them post-commit.

libcxx/docs/ReleaseNotes.rst
154

It can be useful, so let's document it.

This revision was landed with ongoing or failed builds.Jul 17 2023, 9:41 AM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.
var-const added inline comments.Jul 21 2023, 5:29 PM
libcxx/docs/ReleaseNotes.rst
68

Just in case, I have merged ranges::to (https://reviews.llvm.org/D142335) and the release notes should be updated.

Mordante added inline comments.Jul 22 2023, 9:29 AM
libcxx/docs/ReleaseNotes.rst
68

Just in case, I have merged ranges::to (https://reviews.llvm.org/D142335) and the release notes should be updated.

Thanks! Nice to see it done before LLVM 17.