Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

H-G-Hristov (Hristo Hristov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2022, 4:57 AM (75 w, 5 d)

Recent Activity

Thu, Sep 14

H-G-Hristov added a comment to D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Finished going through the tests -- some more feedback!

Thu, Sep 14, 8:30 AM · Restricted Project, Restricted Project

Wed, Sep 13

H-G-Hristov added a comment to D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.

gentle ping....

Wed, Sep 13, 12:23 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 11

H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Addressed a couple of comments

Mon, Sep 11, 9:44 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Added operator== test

Mon, Sep 11, 12:40 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Addressed more review comments

Mon, Sep 11, 10:25 AM · Restricted Project, Restricted Project
H-G-Hristov added inline comments to D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.
Mon, Sep 11, 8:31 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Addressed more review comments + added a missing test

Mon, Sep 11, 8:27 AM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Thank you for the patch! All in all it looks pretty good already. I have only started going through tests but wanted to share the feedback I already have.

Mon, Sep 11, 5:32 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Addressed some comments

Mon, Sep 11, 5:29 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.

Re-run CI

Mon, Sep 11, 3:33 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 6

H-G-Hristov updated the diff for D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.

Rebased

Wed, Sep 6, 10:55 PM · Restricted Project, Restricted Project, Restricted Project
H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Rebased

Wed, Sep 6, 10:44 PM · Restricted Project, Restricted Project

Mon, Sep 4

H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Try to fix CI

Mon, Sep 4, 8:22 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Addressed more comments

Mon, Sep 4, 12:24 AM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Thank you for the comments!

Mon, Sep 4, 12:19 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`.

Addressed some comments

Mon, Sep 4, 12:13 AM · Restricted Project, Restricted Project

Aug 21 2023

H-G-Hristov published D157193: [libc++][ranges] P2116R9: Implements `views::enumerate` for review.
Aug 21 2023, 6:02 AM · Restricted Project, Restricted Project

Aug 11 2023

H-G-Hristov added a comment to D157421: [libc++] Temporarily allow AIX builders to fail.

I'll ship this to make the CI green again.

Aug 11 2023, 9:47 PM · Restricted Project, Restricted Project

Aug 9 2023

H-G-Hristov added a comment to D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`..

@H-G-Hristov Thank you for all the contributions -- your code was immensely helpful. I think that I am making some progress! If you have any thoughts on the way that things are going with the implementation, please let me know! Thanks again!

Aug 9 2023, 2:52 PM · Restricted Project, Restricted Project

Aug 5 2023

H-G-Hristov added a comment to D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`..

@hawkinsw You can look at my WIP for stuff you can easily copy: https://reviews.llvm.org/D157192

Aug 5 2023, 7:35 AM · Restricted Project, Restricted Project

Aug 3 2023

H-G-Hristov added a comment to D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`..

@Mordante @hawkinsw My patch is about the same state like this one. I am still working on enumerate_view I need to add more tests before I submit it. I didn't have much time to work during the last month but I'd like to get it in Clang 18. Maybe its about time to submit a draft.

@hawkinsw You can continue working on it if you like or maybe you can pick some of the other view which are more useful and interesting but I think also more difficult (join_with and join).
You can update the status here: https://libcxx.llvm.org/Status/Ranges.html

Hello @H-G-Hristov !! As a warmup to working on others, I will continue to hammer on this (my next goal is to write tests!) I don't want to waste your time (obviously!) but it's been fun to work on this and a great learning experience. The next goal I have is to write tests (I will start on that tonight!)

Does that sound okay?

Aug 3 2023, 2:04 PM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`..

@Mordante @hawkinsw My patch is about the same state like this one. I am still working on enumerate_view I need to add more tests before I submit it. I didn't have much time to work during the last month but I'd like to get it in Clang 18. Maybe its about time to submit a draft.

Aug 3 2023, 12:48 PM · Restricted Project, Restricted Project

Jul 11 2023

H-G-Hristov accepted D154874: [libc++][doc] Updates the release notes..
Jul 11 2023, 4:12 AM · Restricted Project, Restricted Project

Jun 29 2023

H-G-Hristov added a comment to rG632dd6a4ca00: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1.

@ychen Asking out of curiosity. There is no status page update? Is the feature incomplete?

Jun 29 2023, 10:06 PM · Restricted Project, Restricted Project

Jun 28 2023

H-G-Hristov added inline comments to D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.
Jun 28 2023, 10:36 PM · Restricted Project, Restricted Project, Restricted Project
H-G-Hristov added a comment to D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.

@philnik I resolved most of the comments. I think the patch is ready for another round of reviews.

Jun 28 2023, 10:35 PM · Restricted Project, Restricted Project, Restricted Project
H-G-Hristov updated the diff for D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.

Addressed comments

Jun 28 2023, 12:22 PM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2023

H-G-Hristov planned changes to D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.
Jun 27 2023, 8:55 AM · Restricted Project, Restricted Project, Restricted Project
H-G-Hristov updated the diff for D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.

WIP: Test CI

Jun 27 2023, 8:54 AM · Restricted Project, Restricted Project, Restricted Project
H-G-Hristov updated the diff for D150525: [libc++][memory] P1132R8: out_ptr - a scalable output pointer abstraction.

Addressed some comments

Jun 27 2023, 8:44 AM · Restricted Project, Restricted Project, Restricted Project

Jun 23 2023

H-G-Hristov added inline comments to D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel.
Jun 23 2023, 12:51 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel.

Addressed comments

Jun 23 2023, 9:53 AM · Restricted Project, Restricted Project

Jun 22 2023

H-G-Hristov updated the diff for D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel.

Updated sinopsises + Rebased

Jun 22 2023, 2:11 PM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel.

@Mordante Thank you for the review!

Jun 22 2023, 2:05 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel.

Tweaks

Jun 22 2023, 1:27 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel.

Addressed comments

Jun 22 2023, 1:19 AM · Restricted Project, Restricted Project

Jun 21 2023

H-G-Hristov published D153299: [libc++][ranges] Addresses: LWG3719 - Directory iterators should be usable with default sentinel for review.
Jun 21 2023, 3:16 AM · Restricted Project, Restricted Project

Jun 18 2023

H-G-Hristov added a comment to D153222: [libc++][regex] Removes operator!=..

It looks like these operator== are not implemented but I cannot find when they were added to the standard:
bool operator==(default_sentinel_t) const { return *this == regex_iterator(); }
bool operator==(default_sentinel_t) const { return *this == regex_token_iterator(); }

Jun 18 2023, 2:16 PM · Restricted Project, Restricted Project
H-G-Hristov accepted D153222: [libc++][regex] Removes operator!=..

LGTM (for the record)
Thank you!

Jun 18 2023, 2:09 PM · Restricted Project, Restricted Project

Jun 14 2023

H-G-Hristov added a comment to D152775: [libc++][spaceship][NFC] P1614R2: Status page - mark header synopsis sections as "Complete".

@Mordante
There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".

Nothing to do, means there is no (hypothetical) change needed in the library. For example when I implement the TZDB parts of the library I will directly use the operators as defined in P1614, not what's in the TZDB paper. Had we implemented the TZDB change first we would have needed make changes, like we did for the calendar changes. So then it's not Nothing to do.

Some papers update the wording of the Standard to a new style, without changing the meaning for the wording. These changes are nothing to do. I hope that makes it clearer for you.

For these changes in the status table I probably wouldn't have listed the synopsis at all. This page is temporary and used for the libc++ developers to track the status. It will be removed in the future. So I don't feel to strong about Complete/Nothing to do here; I feel Complete is slightly better.

LGTM!

Jun 14 2023, 2:57 PM · Restricted Project, Restricted Project

Jun 13 2023

H-G-Hristov published D152721: [libc++][spaceship][NFC] P1612R2: Mark remove `operator!=` from "Ranges Library" items as "Complete" for review.
Jun 13 2023, 6:02 AM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D152753: [libc++] Refactor __debug_three_way_comp.

@ldionne Thank. you! LGTM

Jun 13 2023, 5:27 AM · Restricted Project, Restricted Project
H-G-Hristov added a reviewer for D152775: [libc++][spaceship][NFC] P1614R2: Status page - mark header synopsis sections as "Complete": Mordante.
Jun 13 2023, 12:18 AM · Restricted Project, Restricted Project
H-G-Hristov published D152775: [libc++][spaceship][NFC] P1614R2: Status page - mark header synopsis sections as "Complete" for review.

@Mordante
There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".

Jun 13 2023, 12:18 AM · Restricted Project, Restricted Project

Jun 12 2023

H-G-Hristov updated the diff for D152656: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete".

Addressed review comment

Jun 12 2023, 10:15 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152654: [libc++][spaceship] P1612R2: Removed `operator!=` from `locale`.

Rebased

Jun 12 2023, 10:01 AM · Restricted Project, Restricted Project
H-G-Hristov published D152704: [libc++][spaceship] P1614R2: Removed `operator!=` from `functional` for review.

The CI error seems unrelated. I'll rebase and try again later.

Jun 12 2023, 9:19 AM · Restricted Project, Restricted Project
H-G-Hristov published D152699: [libc++][spaceship] P1614R2: Removed `operator!=` from `weekday`s for review.
Jun 12 2023, 7:57 AM · Restricted Project, Restricted Project
H-G-Hristov added a reviewer for D152656: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete": Mordante.
Jun 12 2023, 4:49 AM · Restricted Project, Restricted Project
H-G-Hristov added a reviewer for D152678: [libc++][spaceship] P1614R2: Removed `operator!=` from `scoped_allocator_adaptor`: Mordante.
Jun 12 2023, 4:48 AM · Restricted Project, Restricted Project
H-G-Hristov published D152678: [libc++][spaceship] P1614R2: Removed `operator!=` from `scoped_allocator_adaptor` for review.
Jun 12 2023, 4:18 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152656: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete".

Mark more items as complete

Jun 12 2023, 12:38 AM · Restricted Project, Restricted Project
H-G-Hristov updated the summary of D152656: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete".
Jun 12 2023, 12:34 AM · Restricted Project, Restricted Project
H-G-Hristov retitled D152656: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete" from [libc++][spaceship][NFC] P1612R2: Mark remove `operator!=` from `istream_iterator`, `istreambuf_iterator` as "Complete" to [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete".
Jun 12 2023, 12:32 AM · Restricted Project, Restricted Project
H-G-Hristov published D152656: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete" for review.
Jun 12 2023, 12:16 AM · Restricted Project, Restricted Project

Jun 11 2023

H-G-Hristov added a reviewer for D152654: [libc++][spaceship] P1612R2: Removed `operator!=` from `locale`: Mordante.
Jun 11 2023, 10:59 PM · Restricted Project, Restricted Project
H-G-Hristov added a reviewer for D152647: [libc++][spaceship] P1614R2: Added `operator==` to `file_status`: Mordante.
Jun 11 2023, 10:59 PM · Restricted Project, Restricted Project
H-G-Hristov published D152647: [libc++][spaceship] P1614R2: Added `operator==` to `file_status` for review.
Jun 11 2023, 10:58 PM · Restricted Project, Restricted Project
H-G-Hristov published D152654: [libc++][spaceship] P1612R2: Removed `operator!=` from `locale` for review.
Jun 11 2023, 10:57 PM · Restricted Project, Restricted Project
H-G-Hristov retitled D152642: [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`, `unordered_multimap`, `__hash_map_iterator` from [libc++][spaceship] P1614R2: Removed ops from `unordered_map`, `unordered_multimap`, `__hash_map_iterator` to [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`, `unordered_multimap`, `__hash_map_iterator`.
Jun 11 2023, 12:08 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152642: [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`, `unordered_multimap`, `__hash_map_iterator`.

Rebased

Jun 11 2023, 11:55 AM · Restricted Project, Restricted Project
H-G-Hristov retitled D152642: [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`, `unordered_multimap`, `__hash_map_iterator` from [libc++][spaceship] P1614R2: Removed ops from `unordered_map`, `unordered_multimap` to [libc++][spaceship] P1614R2: Removed ops from `unordered_map`, `unordered_multimap`, `__hash_map_iterator`.
Jun 11 2023, 11:26 AM · Restricted Project, Restricted Project
H-G-Hristov updated the summary of D152642: [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`, `unordered_multimap`, `__hash_map_iterator`.
Jun 11 2023, 11:23 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152612: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`.

Removed macro

Jun 11 2023, 11:20 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152611: [libc++][spaceship] P1612R2: Removed `operator!=` from `bitset`.

Removed macro

Jun 11 2023, 11:14 AM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D152629: [libc++][spaceship] P1614R2: Removed ops from `memory_resource`, `polymorphic_allocator`.

LGTM, thanks to the set of operator!= removal patches. I'm really happy this paper is moving to its conclusion!

Jun 11 2023, 9:44 AM · Restricted Project, Restricted Project
H-G-Hristov published D152642: [libc++][spaceship] P1614R2: Removed `operator!=` from `unordered_map`, `unordered_multimap`, `__hash_map_iterator` for review.
Jun 11 2023, 9:41 AM · Restricted Project, Restricted Project
H-G-Hristov published D152643: [libc++][spaceship] P1614R2: Removed ops from `unordered_multiset`, `unordered_set` for review.
Jun 11 2023, 9:40 AM · Restricted Project, Restricted Project

Jun 10 2023

H-G-Hristov updated the diff for D152629: [libc++][spaceship] P1614R2: Removed ops from `memory_resource`, `polymorphic_allocator`.

Rebased

Jun 10 2023, 2:28 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152629: [libc++][spaceship] P1614R2: Removed ops from `memory_resource`, `polymorphic_allocator`.

Rebased

Jun 10 2023, 1:38 PM · Restricted Project, Restricted Project
H-G-Hristov requested review of D152629: [libc++][spaceship] P1614R2: Removed ops from `memory_resource`, `polymorphic_allocator`.
Jun 10 2023, 1:33 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152617: [libc++][spaceship] P1614R2: Added `operator==` to `slice`.

Addressed comments

Jun 10 2023, 1:02 PM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D152611: [libc++][spaceship] P1612R2: Removed `operator!=` from `bitset`.

In general LGTM, but I would like to land D152297 first and directly update the status page.

Jun 10 2023, 12:58 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152611: [libc++][spaceship] P1612R2: Removed `operator!=` from `bitset`.

Addressed comments

Jun 10 2023, 12:58 PM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D152612: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`.

In general LGTM, but I would like to land D152297 first and directly update the status page.

Jun 10 2023, 12:52 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152612: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`.

Addressed comments

Jun 10 2023, 12:51 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152615: [libc++][spaceship] P1614R2: Removed ops from `complex`.

Addressed comments

Jun 10 2023, 12:44 PM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D151629: [libc++][ranges] Implement P2494R2 (Relaxing range adaptors to allow for move only types).

Normally the "Build Status" looks like this:

Buildable 237942
Build 368504: pre-merge checks
Build 368503: arc lint + arc unit

And here it is missing the last line. Is this some sort of CI issue?

Build Status
Buildable 237526
Build 367796: pre-merge checks

Jun 10 2023, 10:57 AM · Restricted Project, Restricted Project, Restricted Project
H-G-Hristov planned changes to D152617: [libc++][spaceship] P1614R2: Added `operator==` to `slice`.
Jun 10 2023, 8:01 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

Fixed: duplicated entries in table

Jun 10 2023, 7:56 AM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

@Mordante Thank you for the review. I addressed the comments.

Jun 10 2023, 7:35 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

Removed wrong entry; month_day_last

Jun 10 2023, 7:34 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

Addressed comments

Jun 10 2023, 7:25 AM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D152615: [libc++][spaceship] P1614R2: Removed ops from `complex`.

@Mordante Thank you for the review. I'll update the patches and do more of them after we land D152297.

Jun 10 2023, 6:38 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152617: [libc++][spaceship] P1614R2: Added `operator==` to `slice`.

Try to fix CI

Jun 10 2023, 6:32 AM · Restricted Project, Restricted Project
H-G-Hristov updated the summary of D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.
Jun 10 2023, 4:19 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

Marked slice as "In Progress"

Jun 10 2023, 4:14 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152617: [libc++][spaceship] P1614R2: Added `operator==` to `slice`.

Added synopsis

Jun 10 2023, 4:03 AM · Restricted Project, Restricted Project
H-G-Hristov requested review of D152617: [libc++][spaceship] P1614R2: Added `operator==` to `slice`.
Jun 10 2023, 3:59 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

Marked more items as "In Progress"

Jun 10 2023, 2:52 AM · Restricted Project, Restricted Project
H-G-Hristov requested review of D152615: [libc++][spaceship] P1614R2: Removed ops from `complex`.
Jun 10 2023, 2:45 AM · Restricted Project, Restricted Project
H-G-Hristov updated the summary of D152612: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`.
Jun 10 2023, 2:19 AM · Restricted Project, Restricted Project
H-G-Hristov retitled D152612: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator` from [libc++][spaceship] P1614R2: Removed global `operator!=` for `allocator` to [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`.
Jun 10 2023, 2:19 AM · Restricted Project, Restricted Project
H-G-Hristov added a comment to D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

@Mordante Do we need to update the "Release Notes" also?

Jun 10 2023, 2:18 AM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

Marked items as "In Progress" and "Complete"

Jun 10 2023, 2:12 AM · Restricted Project, Restricted Project
H-G-Hristov requested review of D152612: [libc++][spaceship] P1614R2: Removed global `operator!=` from `allocator`.
Jun 10 2023, 12:52 AM · Restricted Project, Restricted Project
H-G-Hristov requested review of D152611: [libc++][spaceship] P1612R2: Removed `operator!=` from `bitset`.
Jun 10 2023, 12:31 AM · Restricted Project, Restricted Project

Jun 9 2023

H-G-Hristov added a comment to D150188: [libc++][spaceship] Fixed `__debug_three_way_comp`'s `operator()` for `vector<bool>'s `operator<=>`.

@philnik Thank you for the review!

Jun 9 2023, 9:45 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D152297: [libc++][spaceship][NFC] Updates `SpaceshipProjects.csv` with full details from `P1614R2`.

Rebased

Jun 9 2023, 9:43 PM · Restricted Project, Restricted Project
H-G-Hristov updated the diff for D150188: [libc++][spaceship] Fixed `__debug_three_way_comp`'s `operator()` for `vector<bool>'s `operator<=>`.
  • Addressed comments
Jun 9 2023, 10:05 AM · Restricted Project, Restricted Project