In D157193#4644531, @var-const wrote:

Finished going through the tests -- some more feedback!

gentle ping....

Addressed a couple of comments

Added operator== test

Addressed more review comments

Addressed more review comments + added a missing test

In D157193#4642507, @var-const wrote:

Thank you for the patch! All in all it looks pretty good already. I have only started going through tests but wanted to share the feedback I already have.

Addressed some comments

Re-run CI

Rebased

Rebased

Try to fix CI

Addressed more comments

Thank you for the comments!

Addressed some comments

In D157421#4570229, @ldionne wrote:

I'll ship this to make the CI green again.

In D156924#4573070, @hawkinsw wrote:

@H-G-Hristov Thank you for all the contributions -- your code was immensely helpful. I think that I am making some progress! If you have any thoughts on the way that things are going with the implementation, please let me know! Thanks again!

@hawkinsw You can look at my WIP for stuff you can easily copy: https://reviews.llvm.org/D157192

In D156924#4558648, @hawkinsw wrote:

In D156924#4558613, @H-G-Hristov wrote:

@Mordante @hawkinsw My patch is about the same state like this one. I am still working on enumerate_view I need to add more tests before I submit it. I didn't have much time to work during the last month but I'd like to get it in Clang 18. Maybe its about time to submit a draft.

@hawkinsw You can continue working on it if you like or maybe you can pick some of the other view which are more useful and interesting but I think also more difficult (join_with and join).
You can update the status here: https://libcxx.llvm.org/Status/Ranges.html

Hello @H-G-Hristov !! As a warmup to working on others, I will continue to hammer on this (my next goal is to write tests!) I don't want to waste your time (obviously!) but it's been fun to work on this and a great learning experience. The next goal I have is to write tests (I will start on that tonight!)

Does that sound okay?

@Mordante @hawkinsw My patch is about the same state like this one. I am still working on enumerate_view I need to add more tests before I submit it. I didn't have much time to work during the last month but I'd like to get it in Clang 18. Maybe its about time to submit a draft.

@ychen Asking out of curiosity. There is no status page update? Is the feature incomplete?

@philnik I resolved most of the comments. I think the patch is ready for another round of reviews.

Addressed comments

WIP: Test CI

Addressed some comments

Addressed comments

Updated sinopsises + Rebased

@Mordante Thank you for the review!

Tweaks

Addressed comments

It looks like these operator== are not implemented but I cannot find when they were added to the standard:
bool operator==(default_sentinel_t) const { return *this == regex_iterator(); }
bool operator==(default_sentinel_t) const { return *this == regex_token_iterator(); }

LGTM (for the record)
Thank you!

In D152775#4421411, @Mordante wrote:

In D152775#4416463, @H-G-Hristov wrote:

@Mordante
There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".

Nothing to do, means there is no (hypothetical) change needed in the library. For example when I implement the TZDB parts of the library I will directly use the operators as defined in P1614, not what's in the TZDB paper. Had we implemented the TZDB change first we would have needed make changes, like we did for the calendar changes. So then it's not Nothing to do.

Some papers update the wording of the Standard to a new style, without changing the meaning for the wording. These changes are nothing to do. I hope that makes it clearer for you.

For these changes in the status table I probably wouldn't have listed the synopsis at all. This page is temporary and used for the libc++ developers to track the status. It will be removed in the future. So I don't feel to strong about Complete/Nothing to do here; I feel Complete is slightly better.

LGTM!

@ldionne Thank. you! LGTM

@Mordante
There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".

Addressed review comment

Rebased

The CI error seems unrelated. I'll rebase and try again later.

Mark more items as complete

Rebased

Removed macro

Removed macro

In D152629#4411982, @Mordante wrote:

LGTM, thanks to the set of operator!= removal patches. I'm really happy this paper is moving to its conclusion!

Rebased

Rebased

Addressed comments

In D152611#4411167, @Mordante wrote:

In general LGTM, but I would like to land D152297 first and directly update the status page.

Addressed comments

In D152612#4411173, @Mordante wrote:

In general LGTM, but I would like to land D152297 first and directly update the status page.

Addressed comments

Addressed comments

Normally the "Build Status" looks like this:

Buildable 237942
Build 368504: pre-merge checks
Build 368503: arc lint + arc unit

And here it is missing the last line. Is this some sort of CI issue?

Build Status
Buildable 237526
Build 367796: pre-merge checks

Fixed: duplicated entries in table

@Mordante Thank you for the review. I addressed the comments.

Removed wrong entry; month_day_last

Addressed comments

@Mordante Thank you for the review. I'll update the patches and do more of them after we land D152297.

Try to fix CI

Marked slice as "In Progress"

Added synopsis

Marked more items as "In Progress"

@Mordante Do we need to update the "Release Notes" also?

Marked items as "In Progress" and "Complete"

@philnik Thank you for the review!

Rebased

• Addressed comments