User Details
- User Since
- Apr 18 2022, 4:57 AM (75 w, 5 d)
Thu, Sep 14
Wed, Sep 13
gentle ping....
Mon, Sep 11
Addressed a couple of comments
Added operator== test
Addressed more review comments
Addressed more review comments + added a missing test
Addressed some comments
Re-run CI
Wed, Sep 6
Rebased
Rebased
Mon, Sep 4
Try to fix CI
Addressed more comments
Thank you for the comments!
Addressed some comments
Aug 21 2023
Aug 11 2023
Aug 9 2023
Aug 5 2023
@hawkinsw You can look at my WIP for stuff you can easily copy: https://reviews.llvm.org/D157192
Aug 3 2023
Jul 11 2023
Jun 29 2023
@ychen Asking out of curiosity. There is no status page update? Is the feature incomplete?
Jun 28 2023
@philnik I resolved most of the comments. I think the patch is ready for another round of reviews.
Addressed comments
Jun 27 2023
WIP: Test CI
Addressed some comments
Jun 23 2023
Addressed comments
Jun 22 2023
Updated sinopsises + Rebased
@Mordante Thank you for the review!
Tweaks
Addressed comments
Jun 21 2023
Jun 18 2023
It looks like these operator== are not implemented but I cannot find when they were added to the standard:
bool operator==(default_sentinel_t) const { return *this == regex_iterator(); }
bool operator==(default_sentinel_t) const { return *this == regex_token_iterator(); }
LGTM (for the record)
Thank you!
Jun 14 2023
Jun 13 2023
@ldionne Thank. you! LGTM
@Mordante
There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".
Jun 12 2023
Addressed review comment
Rebased
The CI error seems unrelated. I'll rebase and try again later.
Mark more items as complete
Jun 11 2023
Rebased
Removed macro
Removed macro
Jun 10 2023
Rebased
Rebased
Addressed comments
Addressed comments
Addressed comments
Addressed comments
Normally the "Build Status" looks like this:
Buildable 237942
Build 368504: pre-merge checks
Build 368503: arc lint + arc unit
And here it is missing the last line. Is this some sort of CI issue?
Build Status
Buildable 237526
Build 367796: pre-merge checks
Fixed: duplicated entries in table
@Mordante Thank you for the review. I addressed the comments.
Removed wrong entry; month_day_last
Addressed comments
Try to fix CI
Marked slice as "In Progress"
Added synopsis
Marked more items as "In Progress"
@Mordante Do we need to update the "Release Notes" also?
Marked items as "In Progress" and "Complete"
Jun 9 2023
@philnik Thank you for the review!
Rebased
- Addressed comments