This is an archive of the discontinued LLVM Phabricator instance.

Differential D154669

[BOLT][DWARF] Don't check string offsets
ClosedPublic

Authored by ayermolo on Jul 6 2023, 5:26 PM.

Details

Reviewers
rafauler
Amir
maksfb
Commits
rGf9d6f48c8bf5: [BOLT][DWARF] Don't check string offsets
Summary

With different linker, the offset of strings can change.

Diff Detail

Event Timeline

ayermolo created this revision.Jul 6 2023, 5:26 PM
Herald added a reviewer: rafauler. · View Herald TranscriptJul 6 2023, 5:26 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.Jul 6 2023, 5:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 5:26 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
ayermolo edited the summary of this revision. (Show Details)Jul 6 2023, 5:32 PM
maksfb accepted this revision.Jul 6 2023, 5:32 PM
This revision is now accepted and ready to land.Jul 6 2023, 5:32 PM
Harbormaster completed remote builds in B243626: Diff 537938.Jul 6 2023, 5:33 PM
Closed by commit rGf9d6f48c8bf5: [BOLT][DWARF] Don't check string offsets (authored by ayermolo). · Explain WhyJul 6 2023, 5:38 PM
This revision was automatically updated to reflect the committed changes.
ayermolo added a commit: rGf9d6f48c8bf5: [BOLT][DWARF] Don't check string offsets.
thakis added a reverting change: rGde7781ea4285: Revert "[DWARF][BOLT] Implement new mechanism for DWARFRewriter".Jul 7 2023, 5:07 AM

Revision Contents

Diff 537939

bolt/test/X86/dwarf4-types-dwarf5-types.test

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
# POSTCHECKTU: DW_TAG_type_unit # POSTCHECKTU: DW_TAG_type_unit
# POSTCHECKTU: DW_TAG_member # POSTCHECKTU: DW_TAG_member
# POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x004c => {0x{{[0-9a-f]+}}} "char *") # POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x004c => {0x{{[0-9a-f]+}}} "char *")
# POSTCHECKTU: DW_TAG_member # POSTCHECKTU: DW_TAG_member
# POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x004c => {0x{{[0-9a-f]+}}} "char *") # POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x004c => {0x{{[0-9a-f]+}}} "char *")
# POSTCHECKTU: DW_TAG_pointer_type # POSTCHECKTU: DW_TAG_pointer_type
# POSTCHECKTU-NEXT: DW_AT_type [DW_FORM_ref4] (cu + 0x0051 => {0x{{[0-9a-f]+}}} "char") # POSTCHECKTU-NEXT: DW_AT_type [DW_FORM_ref4] (cu + 0x0051 => {0x{{[0-9a-f]+}}} "char")
# POSTCHECKTU: DW_TAG_base_type # POSTCHECKTU: DW_TAG_base_type
# POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x0000000e] = "char") # POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "char")
# POSTCHECKTU: version = 0x0004 # POSTCHECKTU: version = 0x0004
# POSTCHECKTU-SAME: type_signature = 0x49dc260088be7e56 # POSTCHECKTU-SAME: type_signature = 0x49dc260088be7e56
# POSTCHECKTU-SAME: type_offset = 0x001e # POSTCHECKTU-SAME: type_offset = 0x001e
# POSTCHECKTU: DW_TAG_type_unit # POSTCHECKTU: DW_TAG_type_unit
# POSTCHECKTU: DW_TAG_structure_type # POSTCHECKTU: DW_TAG_structure_type
# POSTCHECKTU: DW_TAG_member # POSTCHECKTU: DW_TAG_member
# POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x0040 => {0x{{[0-9a-f]+}}} "char *") # POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x0040 => {0x{{[0-9a-f]+}}} "char *")
# POSTCHECKTU: DW_TAG_member # POSTCHECKTU: DW_TAG_member
# POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x0040 => {0x{{[0-9a-f]+}}} "char *") # POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x0040 => {0x{{[0-9a-f]+}}} "char *")
# POSTCHECKTU: DW_TAG_pointer_type # POSTCHECKTU: DW_TAG_pointer_type
# POSTCHECKTU-NEXT: DW_AT_type [DW_FORM_ref4] (cu + 0x0045 => {0x{{[0-9a-f]+}}} "char") # POSTCHECKTU-NEXT: DW_AT_type [DW_FORM_ref4] (cu + 0x0045 => {0x{{[0-9a-f]+}}} "char")
# POSTCHECKTU: DW_TAG_base_type # POSTCHECKTU: DW_TAG_base_type
# POSTCHECKTU-NEXT: DW_AT_name [DW_FORM_strp] ( .debug_str[0x0000000e] = "char") # POSTCHECKTU-NEXT: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "char")

bolt/test/X86/dwarf4-types.test

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
# POSTCHECKTU: DW_TAG_type_unit [1] # POSTCHECKTU: DW_TAG_type_unit [1]
# POSTCHECKTU: DW_TAG_member [3] # POSTCHECKTU: DW_TAG_member [3]
# POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x004c => {0x0000004c} "char *") # POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x004c => {0x0000004c} "char *")
# POSTCHECKTU: DW_TAG_member [3] # POSTCHECKTU: DW_TAG_member [3]
# POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x004c => {0x0000004c} "char *") # POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x004c => {0x0000004c} "char *")
# POSTCHECKTU: DW_TAG_pointer_type [4] # POSTCHECKTU: DW_TAG_pointer_type [4]
# POSTCHECKTU-NEXT: DW_AT_type [DW_FORM_ref4] (cu + 0x0051 => {0x00000051} "char") # POSTCHECKTU-NEXT: DW_AT_type [DW_FORM_ref4] (cu + 0x0051 => {0x00000051} "char")
# POSTCHECKTU: DW_TAG_base_type [5] # POSTCHECKTU: DW_TAG_base_type [5]
# POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x0000000e] = "char") # POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "char")
# POSTCHECKTU: version = 0x0004 # POSTCHECKTU: version = 0x0004
# POSTCHECKTU-SAME: type_signature = 0x49dc260088be7e56 # POSTCHECKTU-SAME: type_signature = 0x49dc260088be7e56
# POSTCHECKTU-SAME: type_offset = 0x001e # POSTCHECKTU-SAME: type_offset = 0x001e
# POSTCHECKTU: DW_TAG_type_unit [1] # POSTCHECKTU: DW_TAG_type_unit [1]
# POSTCHECKTU: DW_TAG_structure_type [2] # POSTCHECKTU: DW_TAG_structure_type [2]
# POSTCHECKTU: DW_TAG_member [3] # POSTCHECKTU: DW_TAG_member [3]
# POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x0040 => {0x00000099} "char *") # POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x0040 => {0x00000099} "char *")
# POSTCHECKTU: DW_TAG_member [3] # POSTCHECKTU: DW_TAG_member [3]
# POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x0040 => {0x00000099} "char *") # POSTCHECKTU: DW_AT_type [DW_FORM_ref4] (cu + 0x0040 => {0x00000099} "char *")
# POSTCHECKTU: DW_TAG_pointer_type [4] # POSTCHECKTU: DW_TAG_pointer_type [4]
# POSTCHECKTU-NEXT: DW_AT_type [DW_FORM_ref4] (cu + 0x0045 => {0x0000009e} "char") # POSTCHECKTU-NEXT: DW_AT_type [DW_FORM_ref4] (cu + 0x0045 => {0x0000009e} "char")
# POSTCHECKTU: DW_TAG_base_type [5] # POSTCHECKTU: DW_TAG_base_type [5]
# POSTCHECKTU-NEXT: DW_AT_name [DW_FORM_strp] ( .debug_str[0x0000000e] = "char") # POSTCHECKTU-NEXT: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "char")

bolt/test/X86/dwarf5-dwarf4-types-backward-forward-cross-reference.test

Show All 26 Lines
# POSTCHECK: version = 0x0004 # POSTCHECK: version = 0x0004
# POSTCHECK: DW_TAG_compile_unit # POSTCHECK: DW_TAG_compile_unit
# POSTCHECK: DW_TAG_variable [20] # POSTCHECK: DW_TAG_variable [20]
# POSTCHECK: DW_AT_type [DW_FORM_ref_addr] (0x0000000000000276 "Foo3a") # POSTCHECK: DW_AT_type [DW_FORM_ref_addr] (0x0000000000000276 "Foo3a")
# POSTCHECKTU: version = 0x0004 # POSTCHECKTU: version = 0x0004
# POSTCHECKTU: DW_TAG_type_unit # POSTCHECKTU: DW_TAG_type_unit
# POSTCHECKTU: DW_TAG_structure_type # POSTCHECKTU: DW_TAG_structure_type
# POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x00000020] = "Foo3a") # POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "Foo3a")
# POSTCHECKTU: version = 0x0004 # POSTCHECKTU: version = 0x0004
# POSTCHECKTU: DW_TAG_type_unit # POSTCHECKTU: DW_TAG_type_unit
# POSTCHECKTU: DW_TAG_structure_type # POSTCHECKTU: DW_TAG_structure_type
# POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x00000035] = "Foo4") # POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "Foo4")
# POSTCHECKTU: version = 0x0004 # POSTCHECKTU: version = 0x0004
# POSTCHECKTU: DW_TAG_type_unit # POSTCHECKTU: DW_TAG_type_unit
# POSTCHECKTU: DW_TAG_structure_type # POSTCHECKTU: DW_TAG_structure_type
# POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x0000004f] = "Foo4a") # POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "Foo4a")
# POSTCHECKTU: version = 0x0004 # POSTCHECKTU: version = 0x0004
# POSTCHECKTU: DW_TAG_type_unit # POSTCHECKTU: DW_TAG_type_unit
# POSTCHECKTU: DW_TAG_structure_type # POSTCHECKTU: DW_TAG_structure_type
# POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x0000000e] = "Foo5") # POSTCHECKTU: DW_AT_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-f]+}}] = "Foo5")