This is an archive of the discontinued LLVM Phabricator instance.

Differential D154667

[BOLT][DWARF] Fix references in tests
ClosedPublic

Authored by ayermolo on Jul 6 2023, 4:35 PM.

Details

Reviewers
rafauler
Amir
maksfb
Commits
rG8ea586b82e49: [BOLT][DWARF] Fix references in tests
Summary

Fixed invalid assembly, where references were not correct.

Diff Detail

Event Timeline

ayermolo created this revision.Jul 6 2023, 4:35 PM
Herald added a reviewer: rafauler. · View Herald TranscriptJul 6 2023, 4:35 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.Jul 6 2023, 4:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 4:35 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
ayermolo edited the summary of this revision. (Show Details)Jul 6 2023, 4:37 PM
rafauler accepted this revision.Jul 6 2023, 4:40 PM
This revision is now accepted and ready to land.Jul 6 2023, 4:40 PM
Harbormaster completed remote builds in B243615: Diff 537926.Jul 6 2023, 4:43 PM
Closed by commit rG8ea586b82e49: [BOLT][DWARF] Fix references in tests (authored by ayermolo). · Explain WhyJul 6 2023, 4:47 PM
This revision was automatically updated to reflect the committed changes.
ayermolo added a commit: rG8ea586b82e49: [BOLT][DWARF] Fix references in tests.

Revision Contents

Diff 537930

bolt/test/X86/Inputs/dwarf5-cu-no-debug-addr-helper.s

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Lines.Ldebug_info_start0:
.short 33 # DW_AT_language .short 33 # DW_AT_language
.byte 1 # DW_AT_name .byte 1 # DW_AT_name
.long .Lstr_offsets_base0 # DW_AT_str_offsets_base .long .Lstr_offsets_base0 # DW_AT_str_offsets_base
.long .Lline_table_start0 # DW_AT_stmt_list .long .Lline_table_start0 # DW_AT_stmt_list
.byte 2 # DW_AT_comp_dir .byte 2 # DW_AT_comp_dir
#.long .Laddr_table_base0 # DW_AT_addr_base mannually removed #.long .Laddr_table_base0 # DW_AT_addr_base mannually removed
.byte 2 # Abbrev [2] 0x1e:0xc DW_TAG_variable .byte 2 # Abbrev [2] 0x1e:0xc DW_TAG_variable
.byte 3 # DW_AT_name .byte 3 # DW_AT_name
.long 42 # DW_AT_type .long 35 # DW_AT_type
.byte 0 # DW_AT_decl_file .byte 0 # DW_AT_decl_file
.byte 4 # DW_AT_decl_line .byte 4 # DW_AT_decl_line
#.byte 2 # DW_AT_location manually removed #.byte 2 # DW_AT_location manually removed
#.byte 161 #.byte 161
#.byte 0 #.byte 0
.byte 6 # DW_AT_linkage_name .byte 6 # DW_AT_linkage_name
.byte 3 # Abbrev [3] 0x2a:0xf DW_TAG_structure_type .byte 3 # Abbrev [3] 0x2a:0xf DW_TAG_structure_type
.byte 5 # DW_AT_calling_convention .byte 5 # DW_AT_calling_convention
.byte 4 # DW_AT_byte_size .byte 4 # DW_AT_byte_size
.byte 0 # DW_AT_decl_file .byte 0 # DW_AT_decl_file
.byte 2 # DW_AT_decl_line .byte 2 # DW_AT_decl_line
.byte 4 # Abbrev [4] 0x2f:0x9 DW_TAG_member .byte 4 # Abbrev [4] 0x2f:0x9 DW_TAG_member
.byte 4 # DW_AT_name .byte 4 # DW_AT_name
.long 57 # DW_AT_type .long 50 # DW_AT_type
.byte 0 # DW_AT_decl_file .byte 0 # DW_AT_decl_file
.byte 3 # DW_AT_decl_line .byte 3 # DW_AT_decl_line
.byte 0 # DW_AT_data_member_location .byte 0 # DW_AT_data_member_location
.byte 0 # End Of Children Mark .byte 0 # End Of Children Mark
.byte 5 # Abbrev [5] 0x39:0x4 DW_TAG_base_type .byte 5 # Abbrev [5] 0x39:0x4 DW_TAG_base_type
.byte 5 # DW_AT_name .byte 5 # DW_AT_name
.byte 5 # DW_AT_encoding .byte 5 # DW_AT_encoding
.byte 4 # DW_AT_byte_size .byte 4 # DW_AT_byte_size
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines

bolt/test/X86/Inputs/dwarf5-loc-base-no-loc-accesshelper.s

Show First 20 Lines • Show All 296 Lines • ▼ Show 20 Lines.Ldebug_info_start0:
.byte 4 # Abbrev [4] 0x36:0x14 DW_TAG_subprogram .byte 4 # Abbrev [4] 0x36:0x14 DW_TAG_subprogram
.byte 1 # DW_AT_low_pc .byte 1 # DW_AT_low_pc
.long .Lfunc_end0-.Lfunc_begin0 # DW_AT_high_pc .long .Lfunc_end0-.Lfunc_begin0 # DW_AT_high_pc
.byte 1 # DW_AT_frame_base .byte 1 # DW_AT_frame_base
.byte 87 .byte 87
# DW_AT_call_all_calls # DW_AT_call_all_calls
.long 74 # DW_AT_abstract_origin .long 74 # DW_AT_abstract_origin
.byte 5 # Abbrev [5] 0x42:0x7 DW_TAG_formal_parameter .byte 5 # Abbrev [5] 0x42:0x7 DW_TAG_formal_parameter
.long 79 # DW_AT_abstract_origin .long 74 # DW_AT_abstract_origin
.byte 0 # End Of Children Mark .byte 0 # End Of Children Mark
.byte 6 # Abbrev [6] 0x4a:0xe DW_TAG_subprogram .byte 6 # Abbrev [6] 0x4a:0xe DW_TAG_subprogram
.byte 5 # DW_AT_linkage_name .byte 5 # DW_AT_linkage_name
.byte 6 # DW_AT_name .byte 6 # DW_AT_name
.byte 0 # DW_AT_decl_file .byte 0 # DW_AT_decl_file
.byte 2 # DW_AT_decl_line .byte 2 # DW_AT_decl_line
# DW_AT_external # DW_AT_external
# DW_AT_inline # DW_AT_inline
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines

bolt/test/X86/Inputs/dwarf5-return-pc-form-addr-main.s

Show First 20 Lines • Show All 423 Lines • ▼ Show 20 Lines.Ldebug_info_start0:
.byte 0 # DW_AT_decl_file .byte 0 # DW_AT_decl_file
.byte 7 # DW_AT_decl_line .byte 7 # DW_AT_decl_line
.long 50 # DW_AT_type .long 50 # DW_AT_type
.byte 7 # Abbrev [7] 0x5f:0x9 DW_TAG_formal_parameter .byte 7 # Abbrev [7] 0x5f:0x9 DW_TAG_formal_parameter
.byte 1 # DW_AT_location .byte 1 # DW_AT_location
.byte 11 # DW_AT_name .byte 11 # DW_AT_name
.byte 0 # DW_AT_decl_file .byte 0 # DW_AT_decl_file
.byte 7 # DW_AT_decl_line .byte 7 # DW_AT_decl_line
.long 161 # DW_AT_type .long 162 # DW_AT_type
.byte 8 # Abbrev [8] 0x68:0x1d DW_TAG_lexical_block .byte 8 # Abbrev [8] 0x68:0x1d DW_TAG_lexical_block
.byte 3 # DW_AT_low_pc .byte 3 # DW_AT_low_pc
.long .Ltmp8-.Ltmp4 # DW_AT_high_pc .long .Ltmp8-.Ltmp4 # DW_AT_high_pc
.byte 9 # Abbrev [9] 0x6e:0x9 DW_TAG_variable .byte 9 # Abbrev [9] 0x6e:0x9 DW_TAG_variable
.byte 2 # DW_AT_location .byte 2 # DW_AT_location
.byte 13 # DW_AT_name .byte 13 # DW_AT_name
.byte 0 # DW_AT_decl_file .byte 0 # DW_AT_decl_file
.byte 9 # DW_AT_decl_line .byte 9 # DW_AT_decl_line
Show All 23 Lines.Ldebug_info_start0:
.byte 6 # DW_AT_decl_line .byte 6 # DW_AT_decl_line
.long 50 # DW_AT_type .long 50 # DW_AT_type
# DW_AT_declaration # DW_AT_declaration
# DW_AT_external # DW_AT_external
.byte 14 # Abbrev [14] 0x9b:0x5 DW_TAG_formal_parameter .byte 14 # Abbrev [14] 0x9b:0x5 DW_TAG_formal_parameter
.long 50 # DW_AT_type .long 50 # DW_AT_type
.byte 0 # End Of Children Mark .byte 0 # End Of Children Mark
.byte 15 # Abbrev [15] 0xa1:0x5 DW_TAG_pointer_type .byte 15 # Abbrev [15] 0xa1:0x5 DW_TAG_pointer_type
.long 166 # DW_AT_type .long 162 # DW_AT_type
.byte 15 # Abbrev [15] 0xa6:0x5 DW_TAG_pointer_type .byte 15 # Abbrev [15] 0xa6:0x5 DW_TAG_pointer_type
.long 171 # DW_AT_type .long 168 # DW_AT_type
.byte 3 # Abbrev [3] 0xab:0x4 DW_TAG_base_type .byte 3 # Abbrev [3] 0xab:0x4 DW_TAG_base_type
.byte 12 # DW_AT_name .byte 12 # DW_AT_name
.byte 6 # DW_AT_encoding .byte 6 # DW_AT_encoding
.byte 1 # DW_AT_byte_size .byte 1 # DW_AT_byte_size
.byte 0 # End Of Children Mark .byte 0 # End Of Children Mark
.Ldebug_info_end0: .Ldebug_info_end0:
.section .debug_str_offsets,"",@progbits .section .debug_str_offsets,"",@progbits
.long 60 # Length of String Offsets Set .long 60 # Length of String Offsets Set
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines

bolt/test/X86/dwarf5-return-pc-form-addr.test

Show All 14 Lines
# PRECHECK: DW_TAG_call_site [11] # PRECHECK: DW_TAG_call_site [11]
# PRECHECK-NEXT: DW_AT_call_origin [DW_FORM_ref4] # PRECHECK-NEXT: DW_AT_call_origin [DW_FORM_ref4]
# PRECHECK-NEXT: DW_AT_call_return_pc [DW_FORM_addr] # PRECHECK-NEXT: DW_AT_call_return_pc [DW_FORM_addr]
# PRECHECK-SAME: 0x[[#%x,ADDR:]]) # PRECHECK-SAME: 0x[[#%x,ADDR:]])
# PRECHECK: callq # PRECHECK: callq
# PRECHECK-NEXT: [[#ADDR]]: # PRECHECK-NEXT: [[#ADDR]]:
# POSTCHECK: DW_TAG_call_site [12] # POSTCHECK: DW_TAG_call_site [11]
# POSTCHECK-NEXT: DW_AT_call_origin [DW_FORM_ref4] # POSTCHECK-NEXT: DW_AT_call_origin [DW_FORM_ref4]
# POSTCHECK-NEXT: DW_AT_call_return_pc [DW_FORM_addr] # POSTCHECK-NEXT: DW_AT_call_return_pc [DW_FORM_addr]
# POSTCHECK-SAME: 0x[[#%x,ADDR:]]) # POSTCHECK-SAME: 0x[[#%x,ADDR:]])
# POSTCHECK: <main>: # POSTCHECK: <main>:
# POSTCHECK: callq # POSTCHECK: callq
# POSTCHECK-NEXT: [[#ADDR]]: # POSTCHECK-NEXT: [[#ADDR]]: