This is an archive of the discontinued LLVM Phabricator instance.

[flang][hlfir] intrinsic dynamically optional arguments
ClosedPublic

Authored by tblah on Jun 30 2023, 10:11 AM.

Details

Summary

This adds support for dynamically optional arguments for intrinsics
which do not have their own hlfir operations.

The functions for processing these arguments are mostly the same as the
equivalent functions in ConvertExpr.cpp. I chose not to share
implementations so that HLFIR helpers can be used here. Presumably
ConvertExpr.cpp will go away one day.

Depends on D154236

Diff Detail

Event Timeline

tblah created this revision.Jun 30 2023, 10:11 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 30 2023, 10:11 AM
tblah requested review of this revision.Jun 30 2023, 10:11 AM
vzakhari accepted this revision.Jun 30 2023, 3:06 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jun 30 2023, 3:06 PM
jeanPerier accepted this revision.Jul 4 2023, 12:11 AM

Looks great, thanks!

This revision was automatically updated to reflect the committed changes.