- SVE pseudos don't pick up the right latency information during MI scheduling as the regex do not match with instruction name.
- Move UNDEF, PSEUDO, and ZERO to the end of actual SVE instruction
- Some CPUs *td files will be fixed in the next commit
Differential Revision: https://reviews.llvm.org/D154232
Details
Details
- Reviewers
dmgreen paulwalker-arm
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Remember to upload with context, it makes the patch easier to read in phabricator.
I think to make this an NFC the Neoverse-N2 changes would need to be included in this patch too.
llvm/lib/Target/AArch64/AArch64SchedNeoverseV2.td | ||
---|---|---|
2144–2146 | This is one example, of many, that makes this patch not NFC because you're changing the scheduling information RSHR_ZPZI_*, which is presumably missing before this point. What I'd like to see is a simple NFC patch where the pseudo instructions have been renamed (as in a literal renaming of the instructions and their uses). Then following patch or patches that update the scheduling modes to increase their coverage of pseudo instructions. |
llvm/lib/Target/AArch64/AArch64SchedNeoverseV2.td | ||
---|---|---|
2144–2146 | ok will change it |
This is one example, of many, that makes this patch not NFC because you're changing the scheduling information RSHR_ZPZI_*, which is presumably missing before this point. What I'd like to see is a simple NFC patch where the pseudo instructions have been renamed (as in a literal renaming of the instructions and their uses). Then following patch or patches that update the scheduling modes to increase their coverage of pseudo instructions.