Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People harviniriawan

harviniriawan (harvin iriawan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2023, 3:42 AM (15 w, 2 d)

Recent Activity
View All

Thu, Sep 7

harviniriawan added a comment to D159451: [BasicAA] BasicAA update for scalable quantity.

Hi Nikita,

Thu, Sep 7, 3:57 AM · Restricted Project, Restricted Project

Wed, Sep 6

harviniriawan added reviewers for D159451: [BasicAA] BasicAA update for scalable quantity: nikic, sdesmalen.
Wed, Sep 6, 12:45 AM · Restricted Project, Restricted Project

Tue, Sep 5

harviniriawan updated the diff for D159451: [BasicAA] BasicAA update for scalable quantity.
Tue, Sep 5, 9:39 AM · Restricted Project, Restricted Project
harviniriawan added a comment to D159451: [BasicAA] BasicAA update for scalable quantity.

I see cases where when we do Loop unrolling for SVE, that we move Load/Stores across iterations although they definitely not aliasing. This patch is trying to improve on that. In theory we should allow alias analysis when done between 2 GEPs that have the same scalable type, and memory location size.

Tue, Sep 5, 9:35 AM · Restricted Project, Restricted Project
harviniriawan requested review of D159451: [BasicAA] BasicAA update for scalable quantity.
Tue, Sep 5, 9:27 AM · Restricted Project, Restricted Project

Aug 21 2023

harviniriawan closed D158432: [AArch64][NFC] Fix stack-guard-sysreg.ll.
Aug 21 2023, 9:31 AM · Restricted Project, Restricted Project
harviniriawan requested review of D158432: [AArch64][NFC] Fix stack-guard-sysreg.ll.
Aug 21 2023, 9:02 AM · Restricted Project, Restricted Project
harviniriawan closed D158410: [AArch64] Test update for a510 generic sched. NFC.
Aug 21 2023, 5:04 AM · Restricted Project, Restricted Project
harviniriawan requested review of D158410: [AArch64] Test update for a510 generic sched. NFC.
Aug 21 2023, 4:45 AM · Restricted Project, Restricted Project
harviniriawan closed D156799: Update generic scheduling to use A510 scheduling model.
Aug 21 2023, 4:28 AM · Restricted Project, Restricted Project, Restricted Project
harviniriawan updated the diff for D156799: Update generic scheduling to use A510 scheduling model.
Aug 21 2023, 4:27 AM · Restricted Project, Restricted Project, Restricted Project
harviniriawan updated the diff for D156799: Update generic scheduling to use A510 scheduling model.
Aug 21 2023, 3:16 AM · Restricted Project, Restricted Project, Restricted Project
harviniriawan updated the diff for D156799: Update generic scheduling to use A510 scheduling model.
Aug 21 2023, 3:08 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2023

harviniriawan added inline comments to D156799: Update generic scheduling to use A510 scheduling model.
Aug 3 2023, 8:16 AM · Restricted Project, Restricted Project, Restricted Project
harviniriawan updated the diff for D156799: Update generic scheduling to use A510 scheduling model.
Aug 3 2023, 8:16 AM · Restricted Project, Restricted Project, Restricted Project
harviniriawan updated the diff for D156799: Update generic scheduling to use A510 scheduling model.
Aug 3 2023, 1:22 AM · Restricted Project, Restricted Project, Restricted Project

Aug 2 2023

harviniriawan updated the diff for D156799: Update generic scheduling to use A510 scheduling model.
Aug 2 2023, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
harviniriawan updated the diff for D156799: Update generic scheduling to use A510 scheduling model.
Aug 2 2023, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
harviniriawan added inline comments to D156799: Update generic scheduling to use A510 scheduling model.
Aug 2 2023, 9:09 AM · Restricted Project, Restricted Project, Restricted Project
harviniriawan updated the diff for D156799: Update generic scheduling to use A510 scheduling model.
Aug 2 2023, 9:09 AM · Restricted Project, Restricted Project, Restricted Project

Aug 1 2023

harviniriawan requested review of D156799: Update generic scheduling to use A510 scheduling model.
Aug 1 2023, 7:47 AM · Restricted Project, Restricted Project, Restricted Project

Jul 24 2023

harviniriawan added a comment to D156094: [AArch64] Ignore instructions not supported by CPU in AArch64SVESchedPseudoTest.

thank you :)

Jul 24 2023, 4:35 AM · Restricted Project, Restricted Project

Jul 21 2023

harviniriawan updated the diff for D155470: [AArch64] LSLFast to fold onto base address by default.
Jul 21 2023, 1:52 AM · Restricted Project, Restricted Project

Jul 20 2023

harviniriawan updated the diff for D155470: [AArch64] LSLFast to fold onto base address by default.
Jul 20 2023, 9:00 AM · Restricted Project, Restricted Project

Jul 17 2023

harviniriawan requested review of D155470: [AArch64] LSLFast to fold onto base address by default.
Jul 17 2023, 8:14 AM · Restricted Project, Restricted Project

Jul 4 2023

harviniriawan closed D154084: [AArch64] Modify SVE Pseudo appends.
Jul 4 2023, 2:44 AM · Restricted Project, Restricted Project
harviniriawan closed D154232: [AArch64] NFC : Change the way SVE pseudos are appended.
Jul 4 2023, 2:44 AM · Restricted Project, Restricted Project

Jul 3 2023

harviniriawan updated the summary of D154232: [AArch64] NFC : Change the way SVE pseudos are appended.
Jul 3 2023, 7:41 AM · Restricted Project, Restricted Project
harviniriawan updated the diff for D154084: [AArch64] Modify SVE Pseudo appends.
Jul 3 2023, 7:40 AM · Restricted Project, Restricted Project
harviniriawan updated the diff for D154232: [AArch64] NFC : Change the way SVE pseudos are appended.
Jul 3 2023, 7:38 AM · Restricted Project, Restricted Project
harviniriawan added inline comments to D154232: [AArch64] NFC : Change the way SVE pseudos are appended.
Jul 3 2023, 6:35 AM · Restricted Project, Restricted Project
harviniriawan updated the diff for D154232: [AArch64] NFC : Change the way SVE pseudos are appended.
Jul 3 2023, 6:34 AM · Restricted Project, Restricted Project
harviniriawan updated the diff for D154232: [AArch64] NFC : Change the way SVE pseudos are appended.
Jul 3 2023, 4:29 AM · Restricted Project, Restricted Project

Jun 30 2023

harviniriawan updated the diff for D154084: [AArch64] Modify SVE Pseudo appends.
Jun 30 2023, 9:56 AM · Restricted Project, Restricted Project
harviniriawan requested review of D154232: [AArch64] NFC : Change the way SVE pseudos are appended.
Jun 30 2023, 9:39 AM · Restricted Project, Restricted Project
harviniriawan added a comment to D154084: [AArch64] Modify SVE Pseudo appends.
In D154084#4463203, @paulwalker-arm wrote:
In D154084#4460011, @harviniriawan wrote:
In D154084#4459841, @paulwalker-arm wrote:

Can the UNDEF_D -> D_UNDEF renaming be pulled into a separate NFC patch?

I don't think it's possible. I can add tests on Neoverse-N2 CPU as well in here, then

Are you sure? To be clear I'm talking about the changes to llvm/lib/Target/AArch64/SVEInstrFormats.td which looks like a mechanical name change to me that should not affect any behaviour. If it does then that's likely a bug.

Jun 30 2023, 3:47 AM · Restricted Project, Restricted Project

Jun 29 2023

harviniriawan added a comment to D154084: [AArch64] Modify SVE Pseudo appends.
In D154084#4459841, @paulwalker-arm wrote:

Can the UNDEF_D -> D_UNDEF renaming be pulled into a separate NFC patch?

Jun 29 2023, 8:19 AM · Restricted Project, Restricted Project
harviniriawan requested review of D154084: [AArch64] Modify SVE Pseudo appends.
Jun 29 2023, 6:59 AM · Restricted Project, Restricted Project

Jun 20 2023

harviniriawan updated the summary of D152688: [Aarch64] Add Cortex-A510 specific scheduling.
Jun 20 2023, 2:38 AM · Restricted Project, Restricted Project

Jun 19 2023

harviniriawan updated the diff for D152688: [Aarch64] Add Cortex-A510 specific scheduling.
Jun 19 2023, 4:13 AM · Restricted Project, Restricted Project

Jun 14 2023

harviniriawan added inline comments to D152688: [Aarch64] Add Cortex-A510 specific scheduling.
Jun 14 2023, 9:55 AM · Restricted Project, Restricted Project
harviniriawan added a comment to D152688: [Aarch64] Add Cortex-A510 specific scheduling.
In D152688#4415494, @evandro wrote:

Can you please share some performance numbers showing that this scheduling model is beneficial most of the time?

Jun 14 2023, 4:33 AM · Restricted Project, Restricted Project
harviniriawan updated the diff for D152688: [Aarch64] Add Cortex-A510 specific scheduling.

Addressed several comments

Jun 14 2023, 4:31 AM · Restricted Project, Restricted Project

Jun 12 2023

harviniriawan added inline comments to D152688: [Aarch64] Add Cortex-A510 specific scheduling.
Jun 12 2023, 1:36 PM · Restricted Project, Restricted Project
harviniriawan updated the diff for D152688: [Aarch64] Add Cortex-A510 specific scheduling.

Address comments from David

Jun 12 2023, 1:33 PM · Restricted Project, Restricted Project
harviniriawan added a reviewer for D152688: [Aarch64] Add Cortex-A510 specific scheduling: dmgreen.
Jun 12 2023, 2:00 AM · Restricted Project, Restricted Project
harviniriawan requested review of D152688: [Aarch64] Add Cortex-A510 specific scheduling.
Jun 12 2023, 1:59 AM · Restricted Project, Restricted Project