[NFC] Initialize class member pointers to nullptr.

[erichkeane]

Test failure is clang-format on ASTConsumers.cpp. Fix that please (whatever it wants?) otherwise, LGTM.

[schittir]

Hope clang-format likes this patch!

[tahonermann]

clang/lib/Frontend/ASTConsumers.cpp

188–192

Indentation is still inconsistent here.

I suggest following the indentation used for StackAddrEscapeChecker in clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp; Don't indent the ASTViewer class definition within the unnamed namespace and do indent the class members.

[schittir]

Fix format per comments - indent class members and avoid indenting the class definition line.

[tahonermann]

Thanks, Sindhu! This looks good to me!

clang/lib/ARCMigrate/TransProperties.cpp

 using namespace arcmt;
 using namespace trans;
 
 namespace {
 
 class PropertiesRewriter {
   MigrationContext &MigrateCtx;
   MigrationPass &Pass;
-  ObjCImplementationDecl *CurImplD;
+  ObjCImplementationDecl *CurImplD = nullptr;
 
   enum PropActionKind {
     PropAction_None,
     PropAction_RetainReplacedWithStrong,
     PropAction_AssignRemoved,
     PropAction_AssignRewritten,
     PropAction_MaybeAddWeakOrUnsafe
   };

clang/lib/AST/ExprConstant.cpp

public:
     // on the overall stack usage of deeply-recursing constexpr evaluations.
     // (We should cache this map rather than recomputing it repeatedly.)
     // But let's try this and see how it goes; we can look into caching the map
     // as a later change.
 
     /// LambdaCaptureFields - Mapping from captured variables/this to
     /// corresponding data members in the closure class.
     llvm::DenseMap<const ValueDecl *, FieldDecl *> LambdaCaptureFields;
-    FieldDecl *LambdaThisCaptureField;
+    FieldDecl *LambdaThisCaptureField = nullptr;
 
     CallStackFrame(EvalInfo &Info, SourceLocation CallLoc,
                    const FunctionDecl *Callee, const LValue *This,
                    const Expr *CallExpr, CallRef Arguments);
     ~CallStackFrame();
 
     // Return the temporary for Key whose version number is Version.
     APValue *getTemporary(const void *Key, unsigned Version) {

clang/lib/Frontend/ASTConsumers.cpp

 std::unique_ptr<ASTConsumer> clang::CreateASTDeclNodeLister() {
   return std::make_unique<ASTDeclNodeLister>(nullptr);
 }
 
 //===----------------------------------------------------------------------===//
 /// ASTViewer - AST Visualization
 
 namespace {
-  class ASTViewer : public ASTConsumer {
-    ASTContext *Context;
-  public:
-    void Initialize(ASTContext &Context) override {
-      this->Context = &Context;
-    }
+  ASTContext *Context = nullptr;
+
+  void Initialize(ASTContext &Context) override { this->Context = &Context; }
 
-    bool HandleTopLevelDecl(DeclGroupRef D) override {
-      for (DeclGroupRef::iterator I = D.begin(), E = D.end(); I != E; ++I)
-        HandleTopLevelSingleDecl(*I);
-      return true;
-    }
 
-    void HandleTopLevelSingleDecl(Decl *D);
-  };
 }
 
 void ASTViewer::HandleTopLevelSingleDecl(Decl *D) {
   if (isa<FunctionDecl>(D) || isa<ObjCMethodDecl>(D)) {
     D->print(llvm::errs());
 
     if (Stmt *Body = D->getBody()) {
       llvm::errs() << '\n';

clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp

 #include "llvm/Support/raw_ostream.h"
 using namespace clang;
 using namespace ento;
 
 namespace {
 class StackAddrEscapeChecker
     : public Checker<check::PreCall, check::PreStmt<ReturnStmt>,
                      check::EndFunction> {
-  mutable IdentifierInfo *dispatch_semaphore_tII;
+  mutable IdentifierInfo *dispatch_semaphore_tII = nullptr;
   mutable std::unique_ptr<BuiltinBug> BT_stackleak;
   mutable std::unique_ptr<BuiltinBug> BT_returnstack;
   mutable std::unique_ptr<BuiltinBug> BT_capturedstackasync;
   mutable std::unique_ptr<BuiltinBug> BT_capturedstackret;
 
 public:
   enum CheckKind {
     CK_StackAddrEscapeChecker,