[clang] Fix checking the equality comparator of base classes in __is_trivially_equality_comparable

[philnik]

Summary

Fixes #63192

[cor3ntin]

Oh wow, nice catch!

clang/lib/AST/Type.cpp

if (llvm::none_of(Decl->methods(), IsDefaultedOperatorEqualEqual) &&
         }
         return false;
       }))
     return false;
 
   return llvm::all_of(Decl->bases(),
                       [](const CXXBaseSpecifier &BS) {
                         if (const auto *RD = BS.getType()->getAsCXXRecordDecl())
-                          HasNonDeletedDefaultedEqualityComparison(RD);
+                          return HasNonDeletedDefaultedEqualityComparison(RD);
                         return true;
                       }) &&
          llvm::all_of(Decl->fields(), [](const FieldDecl *FD) {
            auto Type = FD->getType();
            if (Type->isReferenceType() || Type->isEnumeralType())
              return false;
            if (const auto *RD = Type->getAsCXXRecordDecl())
              return HasNonDeletedDefaultedEqualityComparison(RD);

clang/test/SemaCXX/type-traits.cpp

 
 struct NotTriviallyEqualityComparableHasReferenceMember {
   int& i;
 
   bool operator==(const NotTriviallyEqualityComparableHasReferenceMember&) const = default;
 };
 static_assert(!__is_trivially_equality_comparable(NotTriviallyEqualityComparableHasReferenceMember));
 
+struct NotTriviallyEqualityComparableNonTriviallyComparableBaseBase {
+  int i;
+
+  bool operator==(const NotTriviallyEqualityComparableNonTriviallyComparableBaseBase&) const {
+    return true;
+  }
+};
+
+struct NotTriviallyEqualityComparableNonTriviallyComparableBase : NotTriviallyEqualityComparableNonTriviallyComparableBaseBase {
+  int i;
+
+  bool operator==(const NotTriviallyEqualityComparableNonTriviallyComparableBase&) const = default;
+};
+static_assert(!__is_trivially_equality_comparable(NotTriviallyEqualityComparableNonTriviallyComparableBase));
+
 enum E {
   a,
   b
 };
 bool operator==(E, E) { return false; }
 static_assert(!__is_trivially_equality_comparable(E));
 
 struct NotTriviallyEqualityComparableHasEnum {