This is an archive of the discontinued LLVM Phabricator instance.

[mlir][math] Use math.h for M_PI_4 on WIN32
AbandonedPublic

Authored by sunshaoce on Jun 24 2023, 10:35 AM.

Details

Summary

Trying to fix build errors on WIN32 caused by D153656

Diff Detail

Event Timeline

sunshaoce created this revision.Jun 24 2023, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2023, 10:35 AM
sunshaoce requested review of this revision.Jun 24 2023, 10:35 AM
sunshaoce retitled this revision from [WIP][mlir][math] Use math.h for M_PI_4 on WIN32 to [mlir][math] Use math.h for M_PI_4 on WIN32.Jun 24 2023, 11:38 AM
jpienaar requested changes to this revision.Jun 24 2023, 5:05 PM

https://github.com/llvm/llvm-project/commit/75bd41f61d3247d4394ad0c46d23cc7c62261d63 should resolve the breakage (I saw that previous uses of these constants were also changed to follow that approach).

This revision now requires changes to proceed.Jun 24 2023, 5:05 PM

Can we add these constants into llvm/Support/MathExtras.h?

sunshaoce abandoned this revision.Jun 24 2023, 7:29 PM

https://github.com/llvm/llvm-project/commit/75bd41f61d3247d4394ad0c46d23cc7c62261d63 should resolve the breakage (I saw that previous uses of these constants were also changed to follow that approach).

Thanks!