This is an archive of the discontinued LLVM Phabricator instance.

Differential D153334

[DWARFLinker][DWARFv5] change emitSLEB128IntValue with emitULEB128IntValue for ranges.
ClosedPublic

Authored by avl on Jun 20 2023, 6:15 AM.

Details

Reviewers
JDevlieghere
aprantl
rastogishubham
fdeazeve
Commits
rG64df75fb26e5: [DWARFLinker][DWARFv5] change emitSLEB128IntValue with emitULEB128IntValue for…
Summary

This patch changes emitSLEB128IntValue with emitULEB128IntValue
for length part of address range of DW_RLE_start_length kind. DWARFv5
standard:

DW_RLE_start_length
This is a form of bounded range entry that has one target address operand
value and an unsigned LEB128 integer length operand value.

Diff Detail

Event Timeline

avl created this revision.Jun 20 2023, 6:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2023, 6:15 AM
Herald added subscribers: hiraditya, emaste. · View Herald Transcript
avl requested review of this revision.Jun 20 2023, 6:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 20 2023, 6:15 AM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B239981: Diff 532884.Jun 20 2023, 7:09 AM
JDevlieghere accepted this revision.Jun 20 2023, 9:12 AM

LGTM

This revision is now accepted and ready to land.Jun 20 2023, 9:12 AM
avl added a comment.Jun 21 2023, 3:18 AM

Thank you for the review.

Closed by commit rG64df75fb26e5: [DWARFLinker][DWARFv5] change emitSLEB128IntValue with emitULEB128IntValue for… (authored by avl). · Explain WhyJun 21 2023, 3:18 AM
This revision was automatically updated to reflect the committed changes.
avl added a commit: rG64df75fb26e5: [DWARFLinker][DWARFv5] change emitSLEB128IntValue with emitULEB128IntValue for….

Revision Contents

PathSize
llvm/
lib/
DWARFLinker/
2 lines
test/
tools/
llvm-dwarfutil/
ELF/
X86/
2 lines

Diff 532884

llvm/lib/DWARFLinker/DWARFStreamer.cpp

Show First 20 Lines • Show All 490 Lines • ▼ Show 20 Lines for (const AddressRange &Range : LinkedRanges) {
MS->emitInt8(dwarf::DW_RLE_start_length); MS->emitInt8(dwarf::DW_RLE_start_length);
RngListsSectionSize += 1; RngListsSectionSize += 1;
// Emit start address. // Emit start address.
MS->emitIntValue(Range.start(), AddressSize); MS->emitIntValue(Range.start(), AddressSize);
RngListsSectionSize += AddressSize; RngListsSectionSize += AddressSize;
// Emit length of the range. // Emit length of the range.
RngListsSectionSize += MS->emitSLEB128IntValue(Range.end() - Range.start()); RngListsSectionSize += MS->emitULEB128IntValue(Range.end() - Range.start());
} }
// Emit the terminator entry. // Emit the terminator entry.
MS->emitInt8(dwarf::DW_RLE_end_of_list); MS->emitInt8(dwarf::DW_RLE_end_of_list);
RngListsSectionSize += 1; RngListsSectionSize += 1;
} }
/// Emit debug locations(.debug_loc, .debug_loclists) header. /// Emit debug locations(.debug_loc, .debug_loclists) header.
▲ Show 20 Lines • Show All 799 Lines • Show Last 20 Lines

llvm/test/tools/llvm-dwarfutil/ELF/X86/dwarf5-rnglists.test

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
#DWARF-CHECK: DW_AT_ranges [DW_FORM_sec_offset] (0x[[F4RANGE_OFF:[0-9a-f]*]] #DWARF-CHECK: DW_AT_ranges [DW_FORM_sec_offset] (0x[[F4RANGE_OFF:[0-9a-f]*]]
#DWARF-CHECK: [0x0000000000001160, 0x0000000000001170)) #DWARF-CHECK: [0x0000000000001160, 0x0000000000001170))
#DWARF-CHECK-NOT: .debug_addr contents: #DWARF-CHECK-NOT: .debug_addr contents:
#DWARF-CHECK: .debug_aranges contents: #DWARF-CHECK: .debug_aranges contents:
#DWARF-CHECK: Address Range Header: length = 0x0000002c, format = DWARF32, version = 0x0002, cu_offset = 0x00000000, addr_size = 0x08, seg_size = 0x00 #DWARF-CHECK: Address Range Header: length = 0x0000002c, format = DWARF32, version = 0x0002, cu_offset = 0x00000000, addr_size = 0x08, seg_size = 0x00
#DWARF-CHECK: [0x0000000000001130, 0x0000000000001170) #DWARF-CHECK: [0x0000000000001130, 0x0000000000001170)
#DWARF-CHECK-NOT: .debug_addr contents: #DWARF-CHECK-NOT: .debug_addr contents:
#DWARF-CHECK: .debug_rnglists contents: #DWARF-CHECK: .debug_rnglists contents:
#DWARF-CHECK: 0x00000000: range list header: length = 0x00000040, format = DWARF32, version = 0x0005, addr_size = 0x08, seg_size = 0x00, offset_entry_count = 0x00000000 #DWARF-CHECK: 0x00000000: range list header: length = 0x0000003f, format = DWARF32, version = 0x0005, addr_size = 0x08, seg_size = 0x00, offset_entry_count = 0x00000000
#DWARF-CHECK: ranges: #DWARF-CHECK: ranges:
#DWARF-CHECK: 0x[[F1RANGE_OFF]]: [DW_RLE_start_length]: 0x0000000000001130, 0x0000000000000010 => [0x0000000000001130, 0x0000000000001140) #DWARF-CHECK: 0x[[F1RANGE_OFF]]: [DW_RLE_start_length]: 0x0000000000001130, 0x0000000000000010 => [0x0000000000001130, 0x0000000000001140)
#DWARF-CHECK: {{.*}} [DW_RLE_end_of_list ] #DWARF-CHECK: {{.*}} [DW_RLE_end_of_list ]
#DWARF-CHECK: 0x[[F2RANGE_OFF]]: [DW_RLE_start_length]: 0x0000000000001140, 0x0000000000000010 => [0x0000000000001140, 0x0000000000001150) #DWARF-CHECK: 0x[[F2RANGE_OFF]]: [DW_RLE_start_length]: 0x0000000000001140, 0x0000000000000010 => [0x0000000000001140, 0x0000000000001150)
#DWARF-CHECK: {{.*}} [DW_RLE_end_of_list ] #DWARF-CHECK: {{.*}} [DW_RLE_end_of_list ]
#DWARF-CHECK: 0x[[F3RANGE_OFF]]: [DW_RLE_start_length]: 0x0000000000001150, 0x0000000000000010 => [0x0000000000001150, 0x0000000000001160) #DWARF-CHECK: 0x[[F3RANGE_OFF]]: [DW_RLE_start_length]: 0x0000000000001150, 0x0000000000000010 => [0x0000000000001150, 0x0000000000001160)
#DWARF-CHECK: {{.*}} [DW_RLE_end_of_list ] #DWARF-CHECK: {{.*}} [DW_RLE_end_of_list ]
#DWARF-CHECK: 0x[[F4RANGE_OFF]]: [DW_RLE_start_length]: 0x0000000000001160, 0x0000000000000010 => [0x0000000000001160, 0x0000000000001170) #DWARF-CHECK: 0x[[F4RANGE_OFF]]: [DW_RLE_start_length]: 0x0000000000001160, 0x0000000000000010 => [0x0000000000001160, 0x0000000000001170)
▲ Show 20 Lines • Show All 196 Lines • Show Last 20 Lines