User Details
- User Since
- Sep 16 2021, 6:27 PM (41 w, 4 d)
Jun 3 2022
This seems to work just fine.
Jun 1 2022
Hi Xiang,
Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command:
Apr 28 2022
Hi Qiongsi,
Apr 21 2022
Hi Qiongsi
Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command:
Mar 15 2022
Made changes as pointed out by Adrian
Add newlines to the ends of DWARFRecordSectionSplitter.h/.cpp
Mar 11 2022
Feb 25 2022
I noticed that there is no test for this change. Can you please add one?
Feb 22 2022
Feb 21 2022
Feb 18 2022
LGTM! I will take care of adding a new section to the reflection-dump.test for dsymutil. You will need to cherry-pick this change into apple/llvm-project stable/20211026 branch for it to propagate to swift.
Feb 17 2022
Feb 11 2022
Ah I see, weird because I just locally reverted this change and those errors vanished though there are other errors that popped up in its place, which I suspected were due to some other change because greendragon has been red for a while. Thanks @abrachet
This change breaks the lldb greendragon bot
Add newline to Swift.def at the end of file
Feb 10 2022
Done :)
Closed with 957b24ca9f1e
Hi I think I know what to do and am trying to fix it myself. Thanks for trying!
Hi it seems like this patch caused an error in the lldb build machines:
Hi this commit broke the lldb greendragon bots.
Feb 9 2022
Hi it seems like this change might have been responsible for the lldb incremental bot to have broken
Feb 8 2022
I forgot to add the extra checks for the test to the diff
Feb 3 2022
Feb 1 2022
Changed name to binaryformat from swiftbinaryformat
Jan 28 2022
Jan 27 2022
Jan 26 2022
Jan 24 2022
In DwarfLinkerForBinary.cpp Line 475, we need to make sure that copySwiftReflectionMetadata is not called when the -no-output option is passed, this is because the DwarfStreamer object is not created, and copySwiftReflectionMetadata calls through to a member method of the DwarfStreamer Object. I also moved reflection-metadata.test to the X86 folder because some non X86 tests failed due to target triple issues
Jan 21 2022
Jan 20 2022
Added early return and change else { if .. to and else if
Jan 19 2022
Added the comments as Adrian suggested, and removed the check Adrian suggested as well
Jan 18 2022
Changed the logic for binaryHasSwiftReflectionSections to remove the NoError bool flag, made LinkOpts const, passed DebugMapObject and DwarfStreamer Objects as pointers to copySwiftReflectionMetadata, removed auto where it isn't obvious, removed braces from single line if, used llvm style if statement for dyn_cast
Jan 11 2022
Removed the argument Swift5ReflectionSectionName from initMachOMCObjectFileInfo function and get the name from the Ctx object present within the MCObjectFileInfo object instead
Jan 9 2022
This change broke the test in ModuleDebugInfo.cpp, I have fixed that issue, and this also will act as a test for this change
Jan 6 2022
Dec 20 2021
Put StringRef Swift5ReflectionSegmentName in MCContext, made the SwiftReflectionSections Array the size of enum::Last instead of harcoding.
Dec 14 2021
Removed StringRef pointer and replaced it with a default empty StringRef argument. Changed Unkown to -1 and removed distinct swift5 sections in MOFI to one std::array. Changed names from Swift5ReflectionSectionType to Swift5ReflectionSectionKind.
Fixed comments
Added a new file called Swift.def, it contains macros that define the various swift reflection section names and contents so we can use them throughout the code, and code changes that come with using the def file. Also added a change to have dwarflinker pass in the segment "__DWARF" to the streamer and the MC to create the reflection sections in the dwarf segment
Dec 10 2021
Reduced the testcase yaml files, made the Swift5ReflectionSection creation confirgurable, also moved the copying of the reflection section metadata to its own function called copySwiftReflectionMetadata
Dec 8 2021
Added the changes as mentioned by Adrian, based on my comments in response to him
Dec 2 2021
Nov 10 2021
Oct 7 2021
@probinson Hi Paul, is it possible for you to take another look? I have updated the test files to be more strict with the prologue_ends.
Oct 4 2021
Added a regex check for ensuring no prologue_end is there on no-non-zero-debug-loc-prologue.ll
Oct 1 2021
Updated the test files make sure there are check's for where prologue_end's should not be present. Added a better comment to explain the change made to findPrologueEndLoc as suggested
Sep 30 2021
Fixed the clang-tidy warnings
Sep 29 2021
As suggested by Adrian and Paul, I have reduced the original testcase to be smaller by using a small C sample and compiling only with -gline-tables-only. I have also added another test case where if the only .loc is a line 0 loc, we want to have a prologue_end there, and only move the prologue_end to a non-zero .loc if it exists.