Page MenuHomePhabricator

rastogishubham (Shubham Sandeep Rastogi)
User

Projects

User Details

User Since
Sep 16 2021, 6:27 PM (41 w, 4 d)

Recent Activity

Jun 3 2022

rastogishubham accepted D126892: [NFC] Fix issue on CMake Xcode build configuration..
Jun 3 2022, 11:02 AM · Restricted Project, Restricted Project
rastogishubham added a comment to D126892: [NFC] Fix issue on CMake Xcode build configuration..

This seems to work just fine.

Jun 3 2022, 11:00 AM · Restricted Project, Restricted Project

Jun 1 2022

rastogishubham updated subscribers of D125052: [HLSL] Enable vector types for hlsl..

Hi Xiang,

Jun 1 2022, 11:46 PM · Restricted Project, Restricted Project
rastogishubham added a comment to D125052: [HLSL] Enable vector types for hlsl..

Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command:

Jun 1 2022, 11:28 PM · Restricted Project, Restricted Project

Apr 28 2022

rastogishubham added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

Hi Qiongsi,

Apr 28 2022, 5:19 PM · Restricted Project, Restricted Project

Apr 21 2022

rastogishubham added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

Hi Qiongsi

Apr 21 2022, 11:08 AM · Restricted Project, Restricted Project
rastogishubham added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command:

Apr 21 2022, 10:16 AM · Restricted Project, Restricted Project

Mar 15 2022

rastogishubham committed rGd46409fc8ea4: Move DWARFRecordSectionSplitter code to its own file (authored by rastogishubham).
Move DWARFRecordSectionSplitter code to its own file
Mar 15 2022, 11:39 AM · Restricted Project
rastogishubham closed D121721: Move DWARFRecordSectionSplitter code to its own file.
Mar 15 2022, 11:39 AM · Restricted Project, Restricted Project
rastogishubham updated the diff for D121721: Move DWARFRecordSectionSplitter code to its own file.

Made changes as pointed out by Adrian

Mar 15 2022, 11:35 AM · Restricted Project, Restricted Project
rastogishubham added inline comments to D121721: Move DWARFRecordSectionSplitter code to its own file.
Mar 15 2022, 11:26 AM · Restricted Project, Restricted Project
rastogishubham added inline comments to D121721: Move DWARFRecordSectionSplitter code to its own file.
Mar 15 2022, 11:20 AM · Restricted Project, Restricted Project
rastogishubham updated the diff for D121721: Move DWARFRecordSectionSplitter code to its own file.

Add newlines to the ends of DWARFRecordSectionSplitter.h/.cpp

Mar 15 2022, 11:11 AM · Restricted Project, Restricted Project
rastogishubham requested review of D121721: Move DWARFRecordSectionSplitter code to its own file.
Mar 15 2022, 11:08 AM · Restricted Project, Restricted Project

Mar 11 2022

rastogishubham committed rG229d576b31f4: Rename EHFrameSplitter to DWARFRecordSectionSplitter (authored by rastogishubham).
Rename EHFrameSplitter to DWARFRecordSectionSplitter
Mar 11 2022, 4:03 PM · Restricted Project
rastogishubham closed D121486: Rename EHFrameSplitter to DWARFRecordSectionSplitter.
Mar 11 2022, 4:02 PM · Restricted Project, Restricted Project
rastogishubham requested review of D121486: Rename EHFrameSplitter to DWARFRecordSectionSplitter.
Mar 11 2022, 12:16 PM · Restricted Project, Restricted Project

Feb 25 2022

rastogishubham added a comment to D120574: [dsymutil] Apply relocations present in Swift reflection sections.

I noticed that there is no test for this change. Can you please add one?

Feb 25 2022, 11:08 AM · Restricted Project, Restricted Project

Feb 22 2022

rastogishubham committed rGc5256412b76c: Updated reflection-dump.test for mpenum section (authored by rastogishubham).
Updated reflection-dump.test for mpenum section
Feb 22 2022, 10:21 AM
rastogishubham closed D120291: Updated reflection-dump.test for mpenum section.
Feb 22 2022, 10:21 AM · Restricted Project

Feb 21 2022

rastogishubham requested review of D120291: Updated reflection-dump.test for mpenum section.
Feb 21 2022, 4:46 PM · Restricted Project

Feb 18 2022

rastogishubham committed rG1c1e2cce9a50: Add a new reflection section for multi-payload enum mask information (authored by rastogishubham).
Add a new reflection section for multi-payload enum mask information
Feb 18 2022, 1:05 PM
rastogishubham closed D120151: Add a new reflection section for multi-payload enum mask information.
Feb 18 2022, 1:05 PM · Restricted Project
rastogishubham accepted D120151: Add a new reflection section for multi-payload enum mask information.

LGTM! I will take care of adding a new section to the reflection-dump.test for dsymutil. You will need to cherry-pick this change into apple/llvm-project stable/20211026 branch for it to propagate to swift.

Feb 18 2022, 12:08 PM · Restricted Project

Feb 17 2022

rastogishubham committed rG822a1aad1728: Fix typo in Swift.def, it is swift5_protocol_conformances not… (authored by rastogishubham).
Fix typo in Swift.def, it is swift5_protocol_conformances not…
Feb 17 2022, 3:23 PM

Feb 11 2022

rastogishubham added a comment to D119598: [sanitizers] Fix missing header for mac builds.

Ah I see, weird because I just locally reverted this change and those errors vanished though there are other errors that popped up in its place, which I suspected were due to some other change because greendragon has been red for a while. Thanks @abrachet

Feb 11 2022, 4:20 PM · Restricted Project
rastogishubham added a comment to D119598: [sanitizers] Fix missing header for mac builds.

This change breaks the lldb greendragon bot

Feb 11 2022, 4:07 PM · Restricted Project
rastogishubham committed rGd76da6c7e445: Add support for the swift5 reflection section acfuncs (authored by rastogishubham).
Add support for the swift5 reflection section acfuncs
Feb 11 2022, 2:05 PM
rastogishubham closed D119569: Add support for the swift5 reflection section: accessible functions.
Feb 11 2022, 2:05 PM · Restricted Project
rastogishubham updated the diff for D119569: Add support for the swift5 reflection section: accessible functions.

Add newline to Swift.def at the end of file

Feb 11 2022, 11:26 AM · Restricted Project
rastogishubham requested review of D119569: Add support for the swift5 reflection section: accessible functions.
Feb 11 2022, 11:22 AM · Restricted Project

Feb 10 2022

rastogishubham added a comment to D119519: [NFC] Sort textual headers by alphabetical order.

Done :)

Feb 10 2022, 10:35 PM · Restricted Project
rastogishubham accepted D119519: [NFC] Sort textual headers by alphabetical order.
Feb 10 2022, 10:00 PM · Restricted Project
rastogishubham committed rGa18d06a0f8ff: Add support to dsymutil for dumping out new swift5 reflection sections (authored by rastogishubham).
Add support to dsymutil for dumping out new swift5 reflection sections
Feb 10 2022, 1:52 PM
rastogishubham closed D119310: Add support to dsymutil for dumping out new swift5 reflection sections.
Feb 10 2022, 1:51 PM · Restricted Project
rastogishubham added a comment to D115859: [LoongArch 2/6] Add ELF machine flag and relocs for upcoming LoongArch target.

Closed with 957b24ca9f1e

Feb 10 2022, 1:38 PM · Restricted Project
rastogishubham committed rG957b24ca9f1e: Fix the build errors when enabling -DLLVM_ENABLE_MODULES=On and change… (authored by rastogishubham).
Fix the build errors when enabling -DLLVM_ENABLE_MODULES=On and change…
Feb 10 2022, 1:37 PM
rastogishubham closed D119473: Fix the build errors when enabling -DLLVM_ENABLE_MODULES=On and change e53e6ec6ef74.
Feb 10 2022, 1:37 PM · Restricted Project
rastogishubham requested review of D119473: Fix the build errors when enabling -DLLVM_ENABLE_MODULES=On and change e53e6ec6ef74.
Feb 10 2022, 12:40 PM · Restricted Project
rastogishubham added a comment to D115859: [LoongArch 2/6] Add ELF machine flag and relocs for upcoming LoongArch target.

Hi I think I know what to do and am trying to fix it myself. Thanks for trying!

Feb 10 2022, 11:40 AM · Restricted Project
rastogishubham added a comment to D115859: [LoongArch 2/6] Add ELF machine flag and relocs for upcoming LoongArch target.

Hi it seems like this patch caused an error in the lldb build machines:

Feb 10 2022, 10:15 AM · Restricted Project
rastogishubham added a comment to D119036: [libc++] Fix modules and benchmarks CI builds when incomplete features are disabled.

Hi this commit broke the lldb greendragon bots.

Feb 10 2022, 2:34 AM · Restricted Project

Feb 9 2022

rastogishubham added a comment to D119244: Cleanup LLVMMC headers.

Hi it seems like this change might have been responsible for the lldb incremental bot to have broken

Feb 9 2022, 1:33 PM · Restricted Project
rastogishubham added inline comments to D119310: Add support to dsymutil for dumping out new swift5 reflection sections.
Feb 9 2022, 1:07 PM · Restricted Project

Feb 8 2022

rastogishubham updated the diff for D119310: Add support to dsymutil for dumping out new swift5 reflection sections.

I forgot to add the extra checks for the test to the diff

Feb 8 2022, 9:59 PM · Restricted Project
rastogishubham updated the summary of D119310: Add support to dsymutil for dumping out new swift5 reflection sections.
Feb 8 2022, 9:34 PM · Restricted Project
rastogishubham requested review of D119310: Add support to dsymutil for dumping out new swift5 reflection sections.
Feb 8 2022, 9:26 PM · Restricted Project

Feb 3 2022

rastogishubham closed D118716: Change namespace llvm::swift to namespace llvm::swiftbinaryformat because of clashes with the apple/llvm-project repository.

466329d047fc53ea4a1ba3843c27a5cfdacd17a5

Feb 3 2022, 10:46 AM · Restricted Project

Feb 1 2022

rastogishubham committed rG466329d047fc: Change namespace llvm::swift to namespace llvm::binaryformat because of clashes… (authored by rastogishubham).
Change namespace llvm::swift to namespace llvm::binaryformat because of clashes…
Feb 1 2022, 11:16 AM
rastogishubham updated the diff for D118716: Change namespace llvm::swift to namespace llvm::swiftbinaryformat because of clashes with the apple/llvm-project repository.

Changed name to binaryformat from swiftbinaryformat

Feb 1 2022, 10:52 AM · Restricted Project
rastogishubham added inline comments to D118716: Change namespace llvm::swift to namespace llvm::swiftbinaryformat because of clashes with the apple/llvm-project repository.
Feb 1 2022, 10:40 AM · Restricted Project
rastogishubham requested review of D118716: Change namespace llvm::swift to namespace llvm::swiftbinaryformat because of clashes with the apple/llvm-project repository.
Feb 1 2022, 10:33 AM · Restricted Project

Jan 28 2022

rastogishubham added inline comments to D117238: [C2x] Add BITINT_MAXWIDTH support.
Jan 28 2022, 3:08 PM · Restricted Project
rastogishubham committed rG4ce1f3d47c33: Emit swift5 reflection section data in dsym bundle generated by dsymutil in the… (authored by rastogishubham).
Emit swift5 reflection section data in dsym bundle generated by dsymutil in the…
Jan 28 2022, 10:13 AM

Jan 27 2022

rastogishubham committed rGcf93a085754e: Fixed typos in TestLldbGdbServer.py (authored by rastogishubham).
Fixed typos in TestLldbGdbServer.py
Jan 27 2022, 2:13 PM
rastogishubham committed rG867fdec1945d: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14 (authored by rastogishubham).
Disable TestLldbGdbServer on Dwarf2 and clang versions below 14
Jan 27 2022, 2:03 PM
rastogishubham added a reverting change for rGcd317637708d: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14: rGee54868a76e3: Revert "Disable TestLldbGdbServer on Dwarf2 and clang versions below 14".
Jan 27 2022, 1:37 PM
rastogishubham committed rGee54868a76e3: Revert "Disable TestLldbGdbServer on Dwarf2 and clang versions below 14" (authored by rastogishubham).
Revert "Disable TestLldbGdbServer on Dwarf2 and clang versions below 14"
Jan 27 2022, 1:36 PM
rastogishubham added a reverting change for D118395: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14: rGee54868a76e3: Revert "Disable TestLldbGdbServer on Dwarf2 and clang versions below 14".
Jan 27 2022, 1:36 PM · Restricted Project
rastogishubham committed rGcd317637708d: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14 (authored by rastogishubham).
Disable TestLldbGdbServer on Dwarf2 and clang versions below 14
Jan 27 2022, 1:30 PM
rastogishubham closed D118395: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14.
Jan 27 2022, 1:30 PM · Restricted Project
rastogishubham requested review of D118395: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14.
Jan 27 2022, 9:49 AM · Restricted Project

Jan 26 2022

rastogishubham added a reverting change for rG50f50f258299: Emit swift5 reflection section data in dsym bundle generated by dsymutil in the…: rG0303eb3cf26d: Revert "Emit swift5 reflection section data in dsym bundle generated by….
Jan 26 2022, 4:59 PM
rastogishubham committed rG0303eb3cf26d: Revert "Emit swift5 reflection section data in dsym bundle generated by… (authored by rastogishubham).
Revert "Emit swift5 reflection section data in dsym bundle generated by…
Jan 26 2022, 4:59 PM
rastogishubham added a reverting change for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil: rG0303eb3cf26d: Revert "Emit swift5 reflection section data in dsym bundle generated by….
Jan 26 2022, 4:59 PM · Restricted Project, debug-info
rastogishubham committed rG50f50f258299: Emit swift5 reflection section data in dsym bundle generated by dsymutil in the… (authored by rastogishubham).
Emit swift5 reflection section data in dsym bundle generated by dsymutil in the…
Jan 26 2022, 2:15 PM
rastogishubham closed D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.
Jan 26 2022, 2:14 PM · Restricted Project, debug-info

Jan 24 2022

rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

In DwarfLinkerForBinary.cpp Line 475, we need to make sure that copySwiftReflectionMetadata is not called when the -no-output option is passed, this is because the DwarfStreamer object is not created, and copySwiftReflectionMetadata calls through to a member method of the DwarfStreamer Object. I also moved reflection-metadata.test to the X86 folder because some non X86 tests failed due to target triple issues

Jan 24 2022, 11:14 AM · Restricted Project, debug-info

Jan 21 2022

rastogishubham added a reverting change for rGd84d1135d80c: Emit swift5 reflection section data in dsym bundle generated by dsymutil in the…: rG6103b2d45bfb: Revert "Emit swift5 reflection section data in dsym bundle generated by….
Jan 21 2022, 1:46 PM
rastogishubham committed rG6103b2d45bfb: Revert "Emit swift5 reflection section data in dsym bundle generated by… (authored by rastogishubham).
Revert "Emit swift5 reflection section data in dsym bundle generated by…
Jan 21 2022, 1:46 PM
rastogishubham committed rGd84d1135d80c: Emit swift5 reflection section data in dsym bundle generated by dsymutil in the… (authored by rastogishubham).
Emit swift5 reflection section data in dsym bundle generated by dsymutil in the…
Jan 21 2022, 1:23 PM

Jan 20 2022

rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Added early return and change else { if .. to and else if

Jan 20 2022, 11:36 AM · Restricted Project, debug-info

Jan 19 2022

rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Added the comments as Adrian suggested, and removed the check Adrian suggested as well

Jan 19 2022, 11:08 AM · Restricted Project, debug-info

Jan 18 2022

rastogishubham added inline comments to D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.
Jan 18 2022, 2:20 PM · Restricted Project, debug-info
rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Changed the logic for binaryHasSwiftReflectionSections to remove the NoError bool flag, made LinkOpts const, passed DebugMapObject and DwarfStreamer Objects as pointers to copySwiftReflectionMetadata, removed auto where it isn't obvious, removed braces from single line if, used llvm style if statement for dyn_cast

Jan 18 2022, 2:20 PM · Restricted Project, debug-info

Jan 11 2022

rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Removed the argument Swift5ReflectionSectionName from initMachOMCObjectFileInfo function and get the name from the Ctx object present within the MCObjectFileInfo object instead

Jan 11 2022, 4:11 PM · Restricted Project, debug-info
rastogishubham added inline comments to D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.
Jan 11 2022, 3:40 PM · Restricted Project, debug-info

Jan 9 2022

rastogishubham updated the diff for D116790: C++ -gmodules .pcm files don't have the same DW_AT_language dialect.

This change broke the test in ModuleDebugInfo.cpp, I have fixed that issue, and this also will act as a test for this change

Jan 9 2022, 9:34 PM · Restricted Project, debug-info

Jan 6 2022

rastogishubham updated the summary of D116790: C++ -gmodules .pcm files don't have the same DW_AT_language dialect.
Jan 6 2022, 8:43 PM · Restricted Project, debug-info
rastogishubham added inline comments to D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.
Jan 6 2022, 8:40 PM · Restricted Project, debug-info
rastogishubham requested review of D116790: C++ -gmodules .pcm files don't have the same DW_AT_language dialect.
Jan 6 2022, 8:38 PM · Restricted Project, debug-info

Dec 20 2021

rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Put StringRef Swift5ReflectionSegmentName in MCContext, made the SwiftReflectionSections Array the size of enum::Last instead of harcoding.

Dec 20 2021, 2:09 PM · Restricted Project, debug-info
rastogishubham added inline comments to D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.
Dec 20 2021, 2:07 PM · Restricted Project, debug-info

Dec 14 2021

rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Removed StringRef pointer and replaced it with a default empty StringRef argument. Changed Unkown to -1 and removed distinct swift5 sections in MOFI to one std::array. Changed names from Swift5ReflectionSectionType to Swift5ReflectionSectionKind.

Dec 14 2021, 12:49 PM · Restricted Project, debug-info
rastogishubham added inline comments to D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.
Dec 14 2021, 12:44 PM · Restricted Project, debug-info
rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Fixed comments

Dec 14 2021, 2:02 AM · Restricted Project, debug-info
rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Added a new file called Swift.def, it contains macros that define the various swift reflection section names and contents so we can use them throughout the code, and code changes that come with using the def file. Also added a change to have dwarflinker pass in the segment "__DWARF" to the streamer and the MC to create the reflection sections in the dwarf segment

Dec 14 2021, 2:00 AM · Restricted Project, debug-info

Dec 10 2021

rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Reduced the testcase yaml files, made the Swift5ReflectionSection creation confirgurable, also moved the copying of the reflection section metadata to its own function called copySwiftReflectionMetadata

Dec 10 2021, 12:22 PM · Restricted Project, debug-info

Dec 8 2021

rastogishubham updated the diff for D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.

Added the changes as mentioned by Adrian, based on my comments in response to him

Dec 8 2021, 9:49 AM · Restricted Project, debug-info
rastogishubham added inline comments to D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.
Dec 8 2021, 9:48 AM · Restricted Project, debug-info

Dec 2 2021

rastogishubham requested review of D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil.
Dec 2 2021, 4:22 PM · Restricted Project, debug-info

Nov 10 2021

rastogishubham added inline comments to D113630: Add support for chained fixup load commands to MachOObjectFile.
Nov 10 2021, 5:00 PM · Restricted Project

Oct 7 2021

rastogishubham added a comment to D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.

@probinson Hi Paul, is it possible for you to take another look? I have updated the test files to be more strict with the prologue_ends.

Oct 7 2021, 10:10 AM · Restricted Project, debug-info

Oct 4 2021

rastogishubham updated the diff for D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.

Added a regex check for ensuring no prologue_end is there on no-non-zero-debug-loc-prologue.ll

Oct 4 2021, 10:48 AM · Restricted Project, debug-info

Oct 1 2021

rastogishubham updated the diff for D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.

Updated the test files make sure there are check's for where prologue_end's should not be present. Added a better comment to explain the change made to findPrologueEndLoc as suggested

Oct 1 2021, 2:30 PM · Restricted Project, debug-info
rastogishubham added inline comments to D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.
Oct 1 2021, 11:54 AM · Restricted Project, debug-info

Sep 30 2021

rastogishubham updated the diff for D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.

Fixed the clang-tidy warnings

Sep 30 2021, 12:02 PM · Restricted Project, debug-info

Sep 29 2021

rastogishubham retitled D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present from Do not emit prologue_end for line 0 locs to Do not emit prologue_end for line 0 locs if there is a non-zero loc present.
Sep 29 2021, 6:43 PM · Restricted Project, debug-info
rastogishubham updated the diff for D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.

As suggested by Adrian and Paul, I have reduced the original testcase to be smaller by using a small C sample and compiling only with -gline-tables-only. I have also added another test case where if the only .loc is a line 0 loc, we want to have a prologue_end there, and only move the prologue_end to a non-zero .loc if it exists.

Sep 29 2021, 6:42 PM · Restricted Project, debug-info
rastogishubham added inline comments to D110740: Do not emit prologue_end for line 0 locs if there is a non-zero loc present.
Sep 29 2021, 2:32 PM · Restricted Project, debug-info