Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| mlir/test/CMakeLists.txt | ||
|---|---|---|
| 41 | I think we should use something like if (MLIR_INCLUDE_INTEGRATION_TESTS) if (MLIR_ENABLE_CUDA_CUSPARSE)
set(MLIR_RUN_CUDA_SM80_TESTS)
if(MLIR_ENABLE_CUDA_CUSPARSELT)
set(MLIR_RUN_CUDA_SM80_LT_TESTS ON)i.e. the INTEGRATION flag and the two CUDA flags automatically set the SM80 | |
| mlir/test/CMakeLists.txt | ||
|---|---|---|
| 41 | probably document our decision
| |
| mlir/test/CMakeLists.txt | ||
|---|---|---|
| 46 | you are missing the outermost if (MLIR_INCLUDE_INTEGRATION_TESTS) | |
| mlir/test/CMakeLists.txt | ||
|---|---|---|
| 46 | Actually, L16 does this guard | |
| mlir/test/CMakeLists.txt | ||
|---|---|---|
| 46 | Ah, apologies, I did not scroll up enough ;-) | |
| mlir/test/CMakeLists.txt | ||
|---|---|---|
| 46 | No problem! Thanks for keeping a sharp eye! | |
I think we should use something like
if (MLIR_INCLUDE_INTEGRATION_TESTS)
if (MLIR_ENABLE_CUDA_CUSPARSE) set(MLIR_RUN_CUDA_SM80_TESTS) if(MLIR_ENABLE_CUDA_CUSPARSELT) set(MLIR_RUN_CUDA_SM80_LT_TESTS ON)i.e. the INTEGRATION flag and the two CUDA flags automatically set the SM80