Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/AMDGPU/function-args.ll | ||
---|---|---|
89 | The changes to llvm.amdgcn.raw.buffer.store.ll and llvm.amdgcn.struct.buffer.store.ll LGTM. The changes to function-args.ll, I'm not so sure about. There are a lot of not lines. I don't know what properties these are ensuring, but I know something was being checked. When we remove those and go to auto-generated, there is no evidence some property was being checked. A use of v0 in this case. |
llvm/test/CodeGen/AMDGPU/function-args.ll | ||
---|---|---|
89 | From what I see the -NOT lines just make sure there are no redefinitions or extra uses of the registers of interest and no extra s_waitcnt instructions, deviations from which in all cases should be easy to catch by the usual examination of changes in the autogenerated checks. |
Aggressive -NEXT checks are usually safer then -NOT anyway. I think this was mostly looking for accidental clobbers.
The changes to llvm.amdgcn.raw.buffer.store.ll and llvm.amdgcn.struct.buffer.store.ll LGTM.
The changes to function-args.ll, I'm not so sure about. There are a lot of not lines. I don't know what properties these are ensuring, but I know something was being checked. When we remove those and go to auto-generated, there is no evidence some property was being checked. A use of v0 in this case.