This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GFX11] Add test coverage for 16-bit conversions, part 5.
ClosedPublic

Authored by kosarev on Jun 13 2023, 5:36 AM.

Diff Detail

Event Timeline

kosarev created this revision.Jun 13 2023, 5:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 5:36 AM
kosarev requested review of this revision.Jun 13 2023, 5:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 5:36 AM
arsenm added inline comments.Jun 13 2023, 5:40 AM
llvm/test/CodeGen/AMDGPU/function-returns.ll
1 ↗(On Diff #530872)

Switching to generated checks should be done in a precommit

kosarev updated this revision to Diff 530961.Jun 13 2023, 10:02 AM

Removed unused prefixes.

kosarev added inline comments.Jun 13 2023, 10:10 AM
llvm/test/CodeGen/AMDGPU/function-returns.ll
1 ↗(On Diff #530872)

I don't see how that can be useful in this case. There are no functional changes and the new checks are all as visible here as they would be in a separate patch.

Joe_Nash added inline comments.Jun 13 2023, 2:06 PM
llvm/test/CodeGen/AMDGPU/function-returns.ll
1 ↗(On Diff #530872)

I think adding a GFX11 runline to existing tests (manual or autogenerated) is fine as long as the test is relevant to GFX11. The questionable part for me comes in when we are converting manually written tests to autogenerated. These need some level of judgement to determine if the clarity of the test is lost by making it auto generated. I think it would ease review if you resorted tests in the unlanded patches in this series into a format where a patch contains only one of 1) adding GFX11 runlines or 2) converting a test to autogenerated and adding GFX11 runlines. Patches with 1) only should be easy to approve. Then we can take a closer look at if those cases in 2) should really be manually updated.

kosarev updated this revision to Diff 531281.Jun 14 2023, 5:39 AM

Removed converted manual tests.

kosarev marked an inline comment as done.Jun 14 2023, 5:47 AM
Joe_Nash accepted this revision.Jun 14 2023, 6:35 AM
This revision is now accepted and ready to land.Jun 14 2023, 6:35 AM