This is an archive of the discontinued LLVM Phabricator instance.

LowerMemIntrinsics: Handle inserting addrspacecast for memmove lowering
ClosedPublic

Authored by arsenm on Jun 12 2023, 4:30 AM.

Details

Summary

We're missing a trivial non-AA way to check for non-aliasing address
spaces.

Diff Detail

Event Timeline

arsenm created this revision.Jun 12 2023, 4:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 4:30 AM
arsenm requested review of this revision.Jun 12 2023, 4:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 4:30 AM
arsenm added inline comments.Jun 12 2023, 4:32 AM
llvm/test/CodeGen/AMDGPU/lower-mem-intrinsics.ll
1498

These should probably have expanded and isValidAddrSpaceCast is wrong for random address space numbers

nikic accepted this revision.Jun 12 2023, 6:00 AM

LGTM

This revision is now accepted and ready to land.Jun 12 2023, 6:00 AM