This is an archive of the discontinued LLVM Phabricator instance.

[DWARF][M68k] Add new DW_CC for the new M68kRTD calling convention
ClosedPublic

Authored by myhsu on Jun 9 2023, 2:48 PM.

Details

Summary

Add DW_CC_LLVM_M68kRTD to model the new llvm::CallingConv::M68kRTD (see D149864 and D149867).

To my best understanding since DW_CC_LLVM_* are considered vendor extensions, we can just add it to LLVM without being ratified or even adding into GCC/GDB. Please let me know if I'm wrong.

Diff Detail

Event Timeline

myhsu created this revision.Jun 9 2023, 2:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2023, 2:48 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
myhsu requested review of this revision.Jun 9 2023, 2:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2023, 2:48 PM
myhsu edited the summary of this revision. (Show Details)Jun 9 2023, 2:56 PM

LGTM, is it easy to add a test that runs llvm-dwarfdump on some yaml2obj or llc output?

myhsu updated this revision to Diff 530347.Jun 11 2023, 3:57 PM

Add a llc test to check if DW_CC_LLVM_M68kRTD is printed correctly in llvm-dwarfdump.

aprantl accepted this revision.Jun 12 2023, 7:26 AM
This revision is now accepted and ready to land.Jun 12 2023, 7:26 AM
This revision was landed with ongoing or failed builds.Oct 15 2023, 4:15 PM
This revision was automatically updated to reflect the committed changes.