This is an archive of the discontinued LLVM Phabricator instance.

[flang] Improve compiler_version test (NFC)
ClosedPublic

Authored by kkwli0 on Jun 9 2023, 11:29 AM.

Details

Summary

This patch is to improve the compiler_version test. Some downstream implementations may prepend a string to the compiler_version in addition to "flang version ...". Our internal build breakage is due to this issue. In addition, the check is modified to verify that "flang version" is followed by numbers in the form of "n.n.n".

Diff Detail

Event Timeline

kkwli0 created this revision.Jun 9 2023, 11:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2023, 11:29 AM
Herald added a subscriber: sunshaoce. · View Herald Transcript
kkwli0 requested review of this revision.Jun 9 2023, 11:29 AM
kkwli0 added a project: Restricted Project.
This revision is now accepted and ready to land.Jun 9 2023, 11:32 AM
kkwli0 updated this revision to Diff 530043.Jun 9 2023, 11:50 AM

Remove the extra space in the string

This revision was automatically updated to reflect the committed changes.