This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Remove r600 local id annotations in AMDGPULowerIntrinsics
ClosedPublic

Authored by arsenm on Jun 7 2023, 11:31 AM.

Details

Reviewers
rampitec
Pierre-vh
mareko
nhaehnle
jdoerfert
sstefan1
Group Reviewers
Restricted Project
Summary

With these dropped and memory intrinsic moved into a generic pass, we
can drop the whole pass.

No tests fail with this removed. The new amdgcn intrinsics are
annotated in clang up front. Theoretically may regress r600, but that
would need new testing and support work (r600 ideally would also
follow the clang handling).

If we wanted to refine these values, a better place would be in
AMDGPUAttributor.

Diff Detail

Event Timeline

arsenm created this revision.Jun 7 2023, 11:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 11:31 AM
arsenm requested review of this revision.Jun 7 2023, 11:31 AM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: wdng. · View Herald Transcript
rampitec accepted this revision.Jun 7 2023, 11:32 AM
This revision is now accepted and ready to land.Jun 7 2023, 11:32 AM
arsenm closed this revision.Jun 7 2023, 11:57 AM

8eae660ae0bd0eaded7fca2bdc6002a3444aabaf

I remembered I taught the DAG computeKnownBits about this directly, so the r600 regression would only be from IR passes using known bits between here and the DAG, and I don't know what that would be