This commit introduces a test for the upcoming change addressing
the following issue: https://github.com/llvm/llvm-project/issues/62736
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/Transforms/LICM/expr-reassociate.ll | ||
---|---|---|
3 | Usually the tests for a specific transform shouldn't depend on other passes; You could add a test to PhaseOrdering that tests the end-to-end flow (e.g. with -O2) and then here have just the ones that run licm on the input IR that requires reassoication to move it out of the loop |
llvm/test/Transforms/LICM/expr-reassociate.ll | ||
---|---|---|
3 | I was about to move a vital part of this test into the Transforms/PhaseOrdering but I was encouraged not to. The test as it is now captures the interplay between those two passes quite well and is self-contained. Those end-to-end tests are pretty rare. |
Extending it with an additional test case exposing shortcomings that have been fixed.
Followed a reviewer's suggestion to limit the applicability of the attempted transformation.
Usually the tests for a specific transform shouldn't depend on other passes; You could add a test to PhaseOrdering that tests the end-to-end flow (e.g. with -O2) and then here have just the ones that run licm on the input IR that requires reassoication to move it out of the loop