User Details
- User Since
- Feb 5 2016, 9:28 AM (399 w, 5 d)
Aug 1 2023
Jul 31 2023
following reviewer's advice
Jul 28 2023
One more change.
Added new option, as suggested by the reviewer.
a missing change instantiated
Following reviewer's advice.
Jul 26 2023
more changes
One more test case added.
Jul 25 2023
Jul 21 2023
more post-review changes.
Post-review changes again.
Jul 20 2023
Following the reviewer's suggestions.
Followed a reviewer's suggestion to limit the applicability of the attempted transformation.
Jul 15 2023
post-review changes
Jul 6 2023
Reaction to the review comments.
Jun 21 2023
I had to simplify this logic. After some time even I couldn't understand it.
Jun 13 2023
Fixing the problem I've found while using this patch with a larger codebase.
Extending it with an additional test case exposing shortcomings that have been fixed.
Jun 9 2023
Back to the drawing board: my patch can’t cope with IR emitted by flang-new: Instruction does not dominate all uses
Jun 7 2023
Overriden by D152281
Overriden by D152282
Jun 6 2023
Making it slightly less readable, per clang-format request.
May 31 2023
May 30 2023
Review comments addressed.
May 27 2023
After the precommit comes the real thing.
May 23 2023
May 16 2023
I was hoping this patch could address my problem reported here: https://github.com/llvm/llvm-project/issues/62736
Sadly, it isn't. Maybe it's worth to extend it?
Apr 25 2023
Changes applied according to the reviewer's suggestion. With summary update.
Extended with one more variant of the same test case, as requested.
Apr 18 2023
Hi @fhahn, are you happy with the current shape?
Apr 17 2023
a short comment added as requested
Apr 4 2023
following reviewer's advice.
wrong diff file picked; this is the correct one.
Following reviewer's advice.
the context also restored
BTW, is there any one-button-click way of rebasing?
context will return soon
restored what was lost
seems I had a wrong understanding of the reviewer's intent.
I hope reupload of the same diff causes rebase...
Apr 2 2023
Mar 29 2023
Mar 28 2023
post-review changes again
removed extra spaces that suddenly appeared in two lines.
Restored to the previous idea. And added default param value as suggested.
Test case simplified, as per the reviewer request.
Test updated as per the reviewer request.
Mar 27 2023
formatting changes again