Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People pawosm01

pawosm01 (Paul Osmialowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2016, 9:28 AM (399 w, 5 d)

Recent Activity
View All

Aug 1 2023

pawosm01 committed rG89e25a3d6527: [Transforms][LICM] A test case for the upcoming fix D152281 for the issue with… (authored by pawosm01).
[Transforms][LICM] A test case for the upcoming fix D152281 for the issue with…
Aug 1 2023, 8:43 AM · Restricted Project, Restricted Project
pawosm01 committed rG8698d56d996a: [Transforms][LICM] Add the ability to undo unprofitable reassociation (authored by pawosm01).
[Transforms][LICM] Add the ability to undo unprofitable reassociation
Aug 1 2023, 8:43 AM · Restricted Project, Restricted Project
pawosm01 closed D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Aug 1 2023, 8:43 AM · Restricted Project, Restricted Project
pawosm01 closed D152282: [Transforms][LICM] A test case for the upcoming fix D152281 for the issue with reassociation profitability.
Aug 1 2023, 8:43 AM · Restricted Project, Restricted Project

Jul 31 2023

pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 31 2023, 1:01 PM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

following reviewer's advice

Jul 31 2023, 1:00 PM · Restricted Project, Restricted Project

Jul 28 2023

pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 28 2023, 3:37 PM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

One more change.

Jul 28 2023, 3:36 PM · Restricted Project, Restricted Project
pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 28 2023, 3:26 PM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

Added new option, as suggested by the reviewer.

Jul 28 2023, 3:23 PM · Restricted Project, Restricted Project
pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 28 2023, 3:05 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

a missing change instantiated

Jul 28 2023, 3:04 AM · Restricted Project, Restricted Project
pawosm01 added a comment to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 28 2023, 2:21 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 28 2023, 2:17 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

Following reviewer's advice.

Jul 28 2023, 2:11 AM · Restricted Project, Restricted Project

Jul 26 2023

pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 26 2023, 10:21 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

more changes

Jul 26 2023, 10:16 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152282: [Transforms][LICM] A test case for the upcoming fix D152281 for the issue with reassociation profitability.

One more test case added.

Jul 26 2023, 10:16 AM · Restricted Project, Restricted Project

Jul 25 2023

pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 25 2023, 6:15 AM · Restricted Project, Restricted Project

Jul 21 2023

pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 21 2023, 8:10 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

more post-review changes.

Jul 21 2023, 8:10 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 21 2023, 5:53 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

Post-review changes again.

Jul 21 2023, 5:51 AM · Restricted Project, Restricted Project

Jul 20 2023

pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 20 2023, 5:48 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

Following the reviewer's suggestions.

Jul 20 2023, 5:46 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152282: [Transforms][LICM] A test case for the upcoming fix D152281 for the issue with reassociation profitability.

Followed a reviewer's suggestion to limit the applicability of the attempted transformation.

Jul 20 2023, 5:44 AM · Restricted Project, Restricted Project

Jul 15 2023

pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 15 2023, 11:56 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

post-review changes

Jul 15 2023, 11:26 AM · Restricted Project, Restricted Project

Jul 6 2023

pawosm01 added inline comments to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jul 6 2023, 3:00 PM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

Reaction to the review comments.

Jul 6 2023, 2:59 PM · Restricted Project, Restricted Project

Jun 21 2023

pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

I had to simplify this logic. After some time even I couldn't understand it.

Jun 21 2023, 2:05 AM · Restricted Project, Restricted Project

Jun 13 2023

pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

Fixing the problem I've found while using this patch with a larger codebase.

Jun 13 2023, 4:17 PM · Restricted Project, Restricted Project
pawosm01 updated the diff for D152282: [Transforms][LICM] A test case for the upcoming fix D152281 for the issue with reassociation profitability.

Extending it with an additional test case exposing shortcomings that have been fixed.

Jun 13 2023, 4:16 PM · Restricted Project, Restricted Project

Jun 9 2023

pawosm01 added a comment to D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

Back to the drawing board: my patch can’t cope with IR emitted by flang-new: Instruction does not dominate all uses

Jun 9 2023, 6:30 AM · Restricted Project, Restricted Project

Jun 7 2023

pawosm01 abandoned D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.

Overriden by D152281

Jun 7 2023, 9:21 AM · Restricted Project, Restricted Project
pawosm01 abandoned D151617: A test case for the revision D151616.

Overriden by D152282

Jun 7 2023, 9:18 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D152282: [Transforms][LICM] A test case for the upcoming fix D152281 for the issue with reassociation profitability.
Jun 7 2023, 6:08 AM · Restricted Project, Restricted Project

Jun 6 2023

pawosm01 updated the diff for D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.

Making it slightly less readable, per clang-format request.

Jun 6 2023, 12:09 PM · Restricted Project, Restricted Project
pawosm01 requested review of D152282: [Transforms][LICM] A test case for the upcoming fix D152281 for the issue with reassociation profitability.
Jun 6 2023, 9:11 AM · Restricted Project, Restricted Project
pawosm01 requested review of D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation.
Jun 6 2023, 9:09 AM · Restricted Project, Restricted Project

May 31 2023

pawosm01 added inline comments to D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
May 31 2023, 3:09 PM · Restricted Project, Restricted Project

May 30 2023

pawosm01 added a comment to D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
In D151616#4381099, @fhahn wrote:

There's been some work to reassoicate in LICM to enable hoisting: D148001. It would probably be more general to extend the logic in LICM to handle those cases, which would also trigger if the user wrote the expression like reassociate creates at the moment.

May 30 2023, 1:18 PM · Restricted Project, Restricted Project
pawosm01 added a comment to D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
In D151616#4381099, @fhahn wrote:

There's been some work to reassoicate in LICM to enable hoisting: D148001. It would probably be more general to extend the logic in LICM to handle those cases, which would also trigger if the user wrote the expression like reassociate creates at the moment.

May 30 2023, 9:02 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
May 30 2023, 8:33 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
May 30 2023, 8:29 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
May 30 2023, 8:27 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.

Review comments addressed.

May 30 2023, 8:23 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
May 30 2023, 7:13 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
May 30 2023, 7:10 AM · Restricted Project, Restricted Project

May 27 2023

pawosm01 requested review of D151617: A test case for the revision D151616.
May 27 2023, 11:57 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.

After the precommit comes the real thing.

May 27 2023, 11:51 AM · Restricted Project, Restricted Project
pawosm01 requested review of D151616: [Transforms][Reassociate] "Reassociate expressions" pass optimizations not always profitable.
May 27 2023, 11:49 AM · Restricted Project, Restricted Project

May 23 2023

pawosm01 added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.
In D147457#4348901, @qcolombet wrote:

I was hoping this patch could address my problem reported here: https://github.com/llvm/llvm-project/issues/62736
Sadly, it isn't. Maybe it's worth to extend it?

Let me take a look. Thanks for the pointer.

May 23 2023, 1:40 PM · Restricted Project, Restricted Project

May 16 2023

pawosm01 added a comment to D147457: [Reassociation] Only form CSE expressions for local operands.

I was hoping this patch could address my problem reported here: https://github.com/llvm/llvm-project/issues/62736
Sadly, it isn't. Maybe it's worth to extend it?

May 16 2023, 10:52 AM · Restricted Project, Restricted Project

Apr 25 2023

pawosm01 committed rG9cf1881f8f12: [SCEV] Do not plant SCEV checks unnecessarily (authored by pawosm01).
[SCEV] Do not plant SCEV checks unnecessarily
Apr 25 2023, 1:48 PM · Restricted Project, Restricted Project
pawosm01 closed D146958: [SCEV] Do not plant SCEV checks unnecessarily.
Apr 25 2023, 1:48 PM · Restricted Project, Restricted Project
pawosm01 committed rG20d0f80dd356: [test] A test case for D146958 (authored by pawosm01).
[test] A test case for D146958
Apr 25 2023, 1:37 PM · Restricted Project, Restricted Project
pawosm01 closed D146974: [test] A test case for D146958.
Apr 25 2023, 1:37 PM · Restricted Project, Restricted Project
pawosm01 added inline comments to D146958: [SCEV] Do not plant SCEV checks unnecessarily.
Apr 25 2023, 7:10 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D146958: [SCEV] Do not plant SCEV checks unnecessarily.
Apr 25 2023, 7:07 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146958: [SCEV] Do not plant SCEV checks unnecessarily.

Changes applied according to the reviewer's suggestion. With summary update.

Apr 25 2023, 7:06 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D146974: [test] A test case for D146958.
Apr 25 2023, 7:03 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146974: [test] A test case for D146958.

Extended with one more variant of the same test case, as requested.

Apr 25 2023, 7:01 AM · Restricted Project, Restricted Project

Apr 18 2023

pawosm01 added a comment to D146974: [test] A test case for D146958.

Hi @fhahn, are you happy with the current shape?

Apr 18 2023, 1:17 AM · Restricted Project, Restricted Project

Apr 17 2023

pawosm01 updated the diff for D146974: [test] A test case for D146958.

a short comment added as requested

Apr 17 2023, 7:30 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D146974: [test] A test case for D146958.
Apr 17 2023, 7:18 AM · Restricted Project, Restricted Project

Apr 4 2023

pawosm01 updated the summary of D146974: [test] A test case for D146958.
Apr 4 2023, 12:13 PM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146958: [SCEV] Do not plant SCEV checks unnecessarily.

following reviewer's advice.

Apr 4 2023, 12:11 PM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146974: [test] A test case for D146958.

wrong diff file picked; this is the correct one.

Apr 4 2023, 11:59 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146974: [test] A test case for D146958.

Following reviewer's advice.

Apr 4 2023, 11:55 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146958: [SCEV] Do not plant SCEV checks unnecessarily.

I'm trying to build a relation between D146974 and D146958.

Apr 4 2023, 11:09 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146974: [test] A test case for D146958.

I'll try to build a relation between D146974 and D146958.

Apr 4 2023, 11:06 AM · Restricted Project, Restricted Project
pawosm01 added reviewers for D146974: [test] A test case for D146958: sdesmalen, david-arm.
Apr 4 2023, 10:52 AM · Restricted Project, Restricted Project
pawosm01 updated the summary of D146974: [test] A test case for D146958.
Apr 4 2023, 10:51 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D146958: [SCEV] Do not plant SCEV checks unnecessarily.
Apr 4 2023, 9:46 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146958: [SCEV] Do not plant SCEV checks unnecessarily.

the context also restored

Apr 4 2023, 9:14 AM · Restricted Project, Restricted Project
pawosm01 added a comment to D146958: [SCEV] Do not plant SCEV checks unnecessarily.

BTW, is there any one-button-click way of rebasing?

Apr 4 2023, 9:09 AM · Restricted Project, Restricted Project
pawosm01 added a comment to D146958: [SCEV] Do not plant SCEV checks unnecessarily.

context will return soon

Apr 4 2023, 9:06 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146958: [SCEV] Do not plant SCEV checks unnecessarily.

restored what was lost

Apr 4 2023, 9:05 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146974: [test] A test case for D146958.

seems I had a wrong understanding of the reviewer's intent.

Apr 4 2023, 8:57 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146958: [SCEV] Do not plant SCEV checks unnecessarily.

I hope reupload of the same diff causes rebase...

Apr 4 2023, 8:53 AM · Restricted Project, Restricted Project

Apr 2 2023

pawosm01 added a reviewer for D146958: [SCEV] Do not plant SCEV checks unnecessarily: sdesmalen.
Apr 2 2023, 2:28 AM · Restricted Project, Restricted Project

Mar 29 2023

pawosm01 committed rG6b6f312ccedf: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions (authored by pawosm01).
[TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions
Mar 29 2023, 5:07 AM · Restricted Project, Restricted Project
pawosm01 closed D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.
Mar 29 2023, 5:07 AM · Restricted Project, Restricted Project
pawosm01 added a reverting change for rG59dcf927ee43: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions: rGf8f1909d36b2: Revert "[TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA….
Mar 29 2023, 4:55 AM · Restricted Project, Restricted Project
pawosm01 committed rGf8f1909d36b2: Revert "[TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA… (authored by pawosm01).
Revert "[TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA…
Mar 29 2023, 4:55 AM · Restricted Project, Restricted Project
pawosm01 committed rG59dcf927ee43: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions (authored by pawosm01).
[TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions
Mar 29 2023, 3:08 AM · Restricted Project, Restricted Project
pawosm01 committed rGe9db4fc4db79: NFC: remove stray extra space from llvm.spec.in (authored by pawosm01).
NFC: remove stray extra space from llvm.spec.in
Mar 29 2023, 3:02 AM · Restricted Project, Restricted Project

Mar 28 2023

pawosm01 added inline comments to D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.
Mar 28 2023, 10:58 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.

post-review changes again

Mar 28 2023, 10:56 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.

removed extra spaces that suddenly appeared in two lines.

Mar 28 2023, 8:46 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.
Mar 28 2023, 8:41 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.
Mar 28 2023, 8:40 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.

Restored to the previous idea. And added default param value as suggested.

Mar 28 2023, 8:38 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146958: [SCEV] Do not plant SCEV checks unnecessarily.

Test case simplified, as per the reviewer request.

Mar 28 2023, 7:02 AM · Restricted Project, Restricted Project
pawosm01 added a reviewer for D146974: [test] A test case for D146958: fhahn.
Mar 28 2023, 7:00 AM · Restricted Project, Restricted Project
pawosm01 updated the diff for D146974: [test] A test case for D146958.

Test updated as per the reviewer request.

Mar 28 2023, 6:59 AM · Restricted Project, Restricted Project
pawosm01 added inline comments to D146974: [test] A test case for D146958.
Mar 28 2023, 6:58 AM · Restricted Project, Restricted Project
pawosm01 added a reviewer for D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions: sdesmalen.
Mar 28 2023, 5:12 AM · Restricted Project, Restricted Project

Mar 27 2023

pawosm01 updated the diff for D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.

formatting changes again

Mar 27 2023, 2:14 PM · Restricted Project, Restricted Project