This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] WQM: Ensure exact mode placement before branches
ClosedPublic

Authored by critson on Jun 5 2023, 10:59 PM.

Details

Summary

Fix for D151797 where the change accidentally allowed exit to
exact mode between branch instructions.

Diff Detail

Event Timeline

critson created this revision.Jun 5 2023, 10:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 10:59 PM
critson requested review of this revision.Jun 5 2023, 10:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 10:59 PM
critson updated this revision to Diff 528716.Jun 6 2023, 12:02 AM

Rebase on to pre-commit test.

dstuttard accepted this revision.Jun 6 2023, 12:23 AM

Tested this on the failing case I observed and it fixes the issue.
The change look reasonable to me.

This revision is now accepted and ready to land.Jun 6 2023, 12:23 AM
This revision was landed with ongoing or failed builds.Jun 6 2023, 2:14 AM
This revision was automatically updated to reflect the committed changes.