This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fix regressions in integer mad matching
ClosedPublic

Authored by arsenm on Jun 5 2023, 1:12 PM.

Details

Reviewers
cfang
Pierre-vh
rampitec
foad
Group Reviewers
Restricted Project
Summary

Undo the canonicalize done in
0cfc6510323fbb5a56a5de23cbc65f7cc30fd34c. Restores some regressed
matching of integer mad. The selection patterns fo the actual mads
don't seem to be properly commuting, so some of the commuted cases are
still missed.

Fixes: SWDEV-363009

Diff Detail

Event Timeline

arsenm created this revision.Jun 5 2023, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 1:12 PM
arsenm requested review of this revision.Jun 5 2023, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 1:12 PM
Herald added a subscriber: wdng. · View Herald Transcript
rampitec accepted this revision.Jun 5 2023, 2:37 PM

LGTM. I assume the baseline test is not committed yet.

This revision is now accepted and ready to land.Jun 5 2023, 2:37 PM